From patchwork Tue Feb 5 05:54:57 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 2096341 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 40FA1DF24C for ; Tue, 5 Feb 2013 05:57:31 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1U2bUw-000890-6V; Tue, 05 Feb 2013 05:55:14 +0000 Received: from co9ehsobe002.messaging.microsoft.com ([207.46.163.25] helo=co9outboundpool.messaging.microsoft.com) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1U2bUs-00087w-UY for linux-arm-kernel@lists.infradead.org; Tue, 05 Feb 2013 05:55:12 +0000 Received: from mail220-co9-R.bigfish.com (10.236.132.237) by CO9EHSOBE015.bigfish.com (10.236.130.78) with Microsoft SMTP Server id 14.1.225.23; Tue, 5 Feb 2013 05:55:09 +0000 Received: from mail220-co9 (localhost [127.0.0.1]) by mail220-co9-R.bigfish.com (Postfix) with ESMTP id 158FC4C02EE; Tue, 5 Feb 2013 05:55:09 +0000 (UTC) X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPV:NLI; H:mail.freescale.net; RD:none; EFVD:NLI X-SpamScore: -3 X-BigFish: VS-3(zz98dI1454I1432Izz1ee6h1de0h1202h1e76h1d1ah1d2ahzz8275bhz2dh2a8h668h839h944hd25hd2bhf0ah1220h1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh162dh1631h1758h18e1h1946h1155h) Received: from mail220-co9 (localhost.localdomain [127.0.0.1]) by mail220-co9 (MessageSwitch) id 1360043707420831_12264; Tue, 5 Feb 2013 05:55:07 +0000 (UTC) Received: from CO9EHSMHS002.bigfish.com (unknown [10.236.132.228]) by mail220-co9.bigfish.com (Postfix) with ESMTP id 63F37380048; Tue, 5 Feb 2013 05:55:07 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by CO9EHSMHS002.bigfish.com (10.236.130.12) with Microsoft SMTP Server (TLS) id 14.1.225.23; Tue, 5 Feb 2013 05:55:05 +0000 Received: from tx30smr01.am.freescale.net (10.81.153.31) by 039-SN1MMR1-001.039d.mgd.msft.net (10.84.1.13) with Microsoft SMTP Server (TLS) id 14.2.318.3; Tue, 5 Feb 2013 05:55:04 +0000 Received: from nchen-desktop (nchen-desktop.ap.freescale.net [10.192.242.40]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id r155sx1a004224; Mon, 4 Feb 2013 22:55:00 -0700 Date: Tue, 5 Feb 2013 13:54:57 +0800 From: Peter Chen To: Sascha Hauer Subject: Re: [PATCH v4] USB: add devicetree helpers for determining dr_mode and phy_type Message-ID: <20130205055456.GA6234@nchen-desktop> References: <1359984275-24646-1-git-send-email-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1359984275-24646-1-git-send-email-s.hauer@pengutronix.de> User-Agent: Mutt/1.5.20 (2009-06-14) X-OriginatorOrg: freescale.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130205_005511_120684_968256B6 X-CRM114-Status: GOOD ( 17.22 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-4.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [207.46.163.25 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: alexander.shishkin@linux.intel.com, linux-usb@vger.kernel.org, Matthieu CASTET , kishon , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Mon, Feb 04, 2013 at 02:24:26PM +0100, Sascha Hauer wrote: > 4th round of patches. > > Peter, I would be glad if you could test them before your holiday. I rebased > your last round of Chipidea OTG patches onto this series which you can pull > here: > > git://git.pengutronix.de/git/imx/linux-2.6.git tags/usb-chipidea-otg-for-next > > I couldn't really test the otg patches since my current hardware does not have > the ID pin connected, but I can verify that my usecase still works with your > patches applied. Sascha, I have tested your patchset, it works after adding a few of changes at my otg patchset (we still need to read otgsc for gadget-only function). I use my mx6q sabrelite board to test. I have tested all roles with below diff: So, feel free to add my Tested-by: Peter Chen Besides, if you have a mx51 bbg board, you can test id-switch function. For mx5x, you may need a phy driver. My git: https://github.com/hzpeterchen/linux-usb.git master It is based on your tag, and add latest otg patch. Besides, it has Michael Grzeschik/Marc Kleine-Budde usb misc patch as well as my platform changes for mx6q board. > > Alex, should the patches work for you and are fine otherwise, could you apply > them for v3.9? > > Sascha > > diff --git a/arch/arm/boot/dts/imx6q-sabrelite.dts b/arch/arm/boot/dts/imx6q-sabrelite.dts index 49527d7..cdbf2ec 100644 --- a/arch/arm/boot/dts/imx6q-sabrelite.dts +++ b/arch/arm/boot/dts/imx6q-sabrelite.dts @@ -72,6 +72,10 @@ pinctrl-0 = <&pinctrl_usbotg_1>; disable-over-current; otg_id_pin_select_change; + /* dr_mode = "peripheral"; */ + /* dr_mode = "host"; */ + dr_mode = "otg"; + phy_type = "utmi_wide"; status = "okay"; };