From patchwork Tue Feb 12 17:12:17 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Rutland X-Patchwork-Id: 2130161 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 67E773FD4F for ; Tue, 12 Feb 2013 17:15:42 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1U5JPH-0000YH-PH; Tue, 12 Feb 2013 17:12:35 +0000 Received: from service87.mimecast.com ([91.220.42.44]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1U5JPD-0000XR-NP for linux-arm-kernel@lists.infradead.org; Tue, 12 Feb 2013 17:12:32 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Tue, 12 Feb 2013 17:12:28 +0000 Received: from e106331-lin.cambridge.arm.com ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Tue, 12 Feb 2013 17:12:18 +0000 Date: Tue, 12 Feb 2013 17:12:17 +0000 From: Mark Rutland To: Russell King - ARM Linux Subject: Re: [PATCH] HACK: ARM: Fix generic timer broadcast for TWD Message-ID: <20130212171217.GB13775@e106331-lin.cambridge.arm.com> References: <1360684194-10894-1-git-send-email-thierry.reding@avionic-design.de> <20130212155516.GP17833@n2100.arm.linux.org.uk> MIME-Version: 1.0 In-Reply-To: <20130212155516.GP17833@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.20 (2009-06-14) X-OriginalArrivalTime: 12 Feb 2013 17:12:18.0153 (UTC) FILETIME=[1C899D90:01CE0944] X-MC-Unique: 113021217122801901 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130212_121231_934382_446C0CE9 X-CRM114-Status: GOOD ( 12.58 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [91.220.42.44 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: "linux-tegra@vger.kernel.org" , Thierry Reding , Santosh Shilimkar , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org [...] > So, things to be done here: > 1. Fix the #else part of the code. > 2. Fix the reported oops. I believe the patch below solves point 1. Nothing refers to smp_timer_broadcast any more (as I've tested with git grep), so removing it shouldn't create any additional problems. Russell, are you happy for me to drop this in the patch system? Thanks, Mark. ---->8---- From 1954a075d0ce7f5ce5466b20f7aee9a0ac044cda Mon Sep 17 00:00:00 2001 From: Mark Rutland Date: Tue, 12 Feb 2013 16:50:18 +0000 Subject: [PATCH] arm: remove unused smp_timer_broadcast #define The assignment of clock_event_device::broadcast can be done by timer core as of 12ad100046: "clockevents: Add generic timer broadcast function", and the arm code moved over to this as of 3d06770eef: "arm: Add generic timer broadcast support", but left a dangling #define when !CONFIG_GENERIC_TIMER_BROADCAST. This patch removes the now unused #define. Signed-off-by: Mark Rutland --- arch/arm/kernel/smp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c index b7e3b50..ab9458d 100644 --- a/arch/arm/kernel/smp.c +++ b/arch/arm/kernel/smp.c @@ -480,8 +480,6 @@ void tick_broadcast(const struct cpumask *mask) { smp_cross_call(mask, IPI_TIMER); } -#else -#define smp_timer_broadcast NULL #endif static void broadcast_timer_set_mode(enum clock_event_mode mode,