From patchwork Mon Mar 18 13:58:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Magnus Damm X-Patchwork-Id: 2293431 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 3C7053FCF6 for ; Mon, 18 Mar 2013 15:10:45 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UHbeh-0004fg-2w; Mon, 18 Mar 2013 15:07:19 +0000 Received: from mail-pb0-f41.google.com ([209.85.160.41]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UHaUI-0000ko-2l for linux-arm-kernel@lists.infradead.org; Mon, 18 Mar 2013 13:52:30 +0000 Received: by mail-pb0-f41.google.com with SMTP id um15so6465769pbc.14 for ; Mon, 18 Mar 2013 06:52:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:date:message-id:subject; bh=22tG6GTi9fTSunBeObkiNnl7UUakzQce+9+JkeAQ6Ak=; b=W6W63odpEOirIsQD6mUKHSKW7b3eI9PfKZ1KYXXh74Vw5H3cul7mrfoSBo3ww9yZdI ip6/7m/nqEQ7UCiBH716IKJOCTnOntl1NgKA+HOGQZtZSrREMF22pHGUNQ5psw/HVXce 85zsIAcw9b77vRAGBcFMGN49mo3DeDkGDwerXLNUTROdvEr8IQyF/npqplXPT7MwEPit QFIG3j+4YqUmIq40gseerN2LuXI48StsBk1duxVxj9hsqPl5gObPtFB8y/+H+57UwDke he7vo4x+VzIC3IiHEwy6sgGJwVQbMsHmI2e2yg650Haeoqyc4P0izf4GJsNKjsjni61/ q33g== X-Received: by 10.66.121.133 with SMTP id lk5mr10516688pab.171.1363614745408; Mon, 18 Mar 2013 06:52:25 -0700 (PDT) Received: from [127.0.0.1] (FLH1All083.tky.mesh.ad.jp. [211.13.49.83]) by mx.google.com with ESMTPS id pb3sm10222186pbc.7.2013.03.18.06.52.22 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 18 Mar 2013 06:52:24 -0700 (PDT) From: Magnus Damm To: linux-sh@vger.kernel.org Date: Mon, 18 Mar 2013 22:58:18 +0900 Message-Id: <20130318135818.23765.51686.sendpatchset@w520> Subject: [PATCH/RFC] ARM: shmobile: Disallow PINCTRL without GPIOLIB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130318_095230_206412_949B9D5C X-CRM114-Status: UNSURE ( 9.36 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.160.41 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (magnus.damm[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: laurent.pinchart+renesas@ideasonboard.com, linus.walleij@linaro.org, Magnus Damm , grant.likely@secretlab.ca, horms@verge.net.au, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Magnus Damm Modify mach-shmobile to only select PINCTRL in case of ARCH_WANT_OPTIONAL_GPIOLIB is set. This fixes a build error triggered when adding a new SoC lacking GPIO software support (ARCH_WANT_OPTIONAL_GPIOLIB=n): CC drivers/tty/vt/keyboard.o In file included from drivers/pinctrl/core.c:30:0: include/asm-generic/gpio.h: In function 'gpio_get_value_cansleep': include/asm-generic/gpio.h:270:2: error: implicit declaration of function '__gpio_get_value' include/asm-generic/gpio.h: In function 'gpio_set_value_cansleep': include/asm-generic/gpio.h:276:2: error: implicit declaration of function '__gpio_set_value' drivers/pinctrl/core.c: In function 'pinctrl_ready_for_gpio_range': drivers/pinctrl/core.c:297:9: error: implicit declaration of function 'gpio_to_chip' drivers/pinctrl/core.c:297:27: warning: initialization makes pointer from integer without a cast drivers/pinctrl/core.c:304:45: error: dereferencing pointer to incomplete type drivers/pinctrl/core.c:305:26: error: dereferencing pointer to incomplete type drivers/pinctrl/core.c:305:39: error: dereferencing pointer to incomplete type make[2]: *** [drivers/pinctrl/core.o] Error 1 make[1]: *** [drivers/pinctrl] Error 2 make[1]: *** Waiting for unfinished jobs.... LD drivers/sh/built-in.o Signed-off-by: Magnus Damm --- Using renesas.git "next" 811689afc214564c4a5f238ecf4d8bdc0e52b615 Trigger using the r8a73a4 patches that lack GPIO and PFC support. I am more than happy to replace this patch with something cleaner. arch/arm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- 0001/arch/arm/Kconfig +++ work/arch/arm/Kconfig 2013-03-18 14:56:17.000000000 +0900 @@ -725,7 +725,7 @@ config ARCH_SHMOBILE select MULTI_IRQ_HANDLER select NEED_MACH_MEMORY_H select NO_IOPORT - select PINCTRL + select PINCTRL if ARCH_WANT_OPTIONAL_GPIOLIB select PM_GENERIC_DOMAINS if PM select SPARSE_IRQ help