diff mbox

[v2] ARM: dove: add more hardware description in the DT

Message ID 20130325202408.0337ab6f@armhf (mailing list archive)
State New, archived
Headers show

Commit Message

Jean-Francois Moine March 25, 2013, 7:24 p.m. UTC
The 88AP510 chip (Marvell Dove) contains a LCD controller, a display
controller and two audio controllers.

Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
---
v2 from Sebastian Hesselbarth remarks
   - better names for the devices
   - fix bad i2s interrupt controller
   - 2 irq's by audio controller
   - display controller added
---
 arch/arm/boot/dts/dove.dtsi |   38 +++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

Comments

Sebastian Hesselbarth March 25, 2013, 8:44 p.m. UTC | #1
On 03/25/2013 08:24 PM, Jean-Francois Moine wrote:
> The 88AP510 chip (Marvell Dove) contains a LCD controller, a display
> controller and two audio controllers.
>
> Signed-off-by: Jean-Francois Moine<moinejf@free.fr>
> ---
> v2 from Sebastian Hesselbarth remarks
>     - better names for the devices
>     - fix bad i2s interrupt controller
>     - 2 irq's by audio controller
>     - display controller added
> ---
>   arch/arm/boot/dts/dove.dtsi |   38 +++++++++++++++++++++++++++++++
>   1 file changed, 38 insertions(+)
>
> diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi
> index f7509ca..4f5cfbf 100644
> --- a/arch/arm/boot/dts/dove.dtsi
> +++ b/arch/arm/boot/dts/dove.dtsi
> @@ -253,5 +253,43 @@
>   				dmacap,xor;
>   			};
>   		};
> +
> +		lcd0: lcd-controller@820000 {
> +			compatible = "marvell,dove-lcd";
> +			reg =<0x820000 0x1c8>;
> +			interrupts =<47>;
> +			status = "disabled";
> +		};
> +
> +		lcd1: lcd-controller@810000 {
> +			compatible = "marvell,dove-lcd";
> +			reg =<0x810000 0x1c8>;
> +			interrupts =<46>;
> +			status = "disabled";
> +		};
> +
> +		i2s0: audio-controller@b0000 {
> +			compatible = "marvell,kirkwood-i2s";
> +			reg =<0xb0000 0x4000>;
> +			interrupts =<19>,<20>;
> +			clocks =<&gate_clk 12>;
> +			status = "disabled";
> +		};
> +
> +		i2s1: audio-controller@b4000 {
> +			compatible = "marvell,kirkwood-i2s";
> +			reg =<0xb4000 0x4000>;
> +			interrupts =<21>,<22>;
> +			clocks =<&gate_clk 13>;
> +			status = "disabled";
> +		};
> +
> +		/* display controller and image rotation engine */
> +		dcon: display-controller@830000 {
> +			compatible = "marvell,dove-dcon";
> +			reg =<0x830000 0xc8>,<0x831000 0x8c>;

nit: first dcon register block ends at 0xc4 not 0xc8

Otherwise,

Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>

> +			interrupts =<45>;
> +			status = "disabled";
> +		};
>   	};
>   };
diff mbox

Patch

diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi
index f7509ca..4f5cfbf 100644
--- a/arch/arm/boot/dts/dove.dtsi
+++ b/arch/arm/boot/dts/dove.dtsi
@@ -253,5 +253,43 @@ 
 				dmacap,xor;
 			};
 		};
+
+		lcd0: lcd-controller@820000 {
+			compatible = "marvell,dove-lcd";
+			reg = <0x820000 0x1c8>;
+			interrupts = <47>;
+			status = "disabled";
+		};
+
+		lcd1: lcd-controller@810000 {
+			compatible = "marvell,dove-lcd";
+			reg = <0x810000 0x1c8>;
+			interrupts = <46>;
+			status = "disabled";
+		};
+
+		i2s0: audio-controller@b0000 {
+			compatible = "marvell,kirkwood-i2s";
+			reg = <0xb0000 0x4000>;
+			interrupts = <19>, <20>;
+			clocks = <&gate_clk 12>;
+			status = "disabled";
+		};
+
+		i2s1: audio-controller@b4000 {
+			compatible = "marvell,kirkwood-i2s";
+			reg = <0xb4000 0x4000>;
+			interrupts = <21>, <22>;
+			clocks = <&gate_clk 13>;
+			status = "disabled";
+		};
+
+		/* display controller and image rotation engine */
+		dcon: display-controller@830000 {
+			compatible = "marvell,dove-dcon";
+			reg = <0x830000 0xc8>, <0x831000 0x8c>;
+			interrupts = <45>;
+			status = "disabled";
+		};
 	};
 };