From patchwork Thu May 9 00:36:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Cooper X-Patchwork-Id: 2542361 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork1.kernel.org (Postfix) with ESMTP id F0EAA3FC5A for ; Thu, 9 May 2013 00:36:44 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UaEqa-0000pP-NL; Thu, 09 May 2013 00:36:36 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UaEqY-0005Bt-1C; Thu, 09 May 2013 00:36:34 +0000 Received: from mho-03-ewr.mailhop.org ([204.13.248.66] helo=mho-01-ewr.mailhop.org) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UaEqV-0005AU-Ol for linux-arm-kernel@lists.infradead.org; Thu, 09 May 2013 00:36:32 +0000 Received: from pool-72-84-113-162.nrflva.fios.verizon.net ([72.84.113.162] helo=titan) by mho-01-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1UaEqA-000IvZ-Iq; Thu, 09 May 2013 00:36:10 +0000 Received: from titan.lakedaemon.net (localhost [127.0.0.1]) by titan (Postfix) with ESMTP id D1251427353; Wed, 8 May 2013 20:36:06 -0400 (EDT) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 72.84.113.162 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX180jyjxLLyFh2Juj+T+sjBy+lZdYWJ7HvM= Date: Wed, 8 May 2013 20:36:06 -0400 From: Jason Cooper To: Tony Lindgren Subject: Re: [RFC PATCH 0/3] ARM: omap3: add Seagate Wireless Plus board Message-ID: <20130509003606.GE31290@titan.lakedaemon.net> References: <20130508194504.GD32546@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130508194504.GD32546@atomide.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130508_203631_833201_CAF047CC X-CRM114-Status: GOOD ( 18.08 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [204.13.248.66 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Wed, May 08, 2013 at 12:45:04PM -0700, Tony Lindgren wrote: > * Jason Cooper [130508 12:29]: > > > > Tony has been helping me out offline with this, and he suggested trying the > > gpmc against Linus' ToT. Which locks up before it even has a chance to get > > going. So this series is against v3.9. > > You may have better luck with today's mainline treeand the following fix: > > http://lkml.org/lkml/2013/5/8/374# Ok, I'm attempting to do that, but got this for 'make dtbs': ERROR (phandle_references): Reference to non-existent node or label "usb2_phy" ERROR: Input tree has errors, aborting (use -f to force output) make[1]: *** [arch/arm/boot/dts/omap3-wireless_plus.dtb] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [dtbs] Error 2 which was created by: ad871c10 ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards It assumes the board has twl4030 (and then includes it). Bootlogs from the vendor provided kernel don't show a single message from twl4030, so I've omitted it. Assuming I did the correct thing by omitting the twl4030, I think the correct answer is to declare the phy in the dts files, like so: ---->8----- commit c369d84600bd85b35d83807ce7ba893cea116fb4 Author: Jason Cooper Date: Thu May 9 00:33:48 2013 +0000 ARM: omap3: dts: don't assume boards are using twl4030 If a board isn't using twl4030, then dtc will complain about the missing phandle (which is in twl4030.dtsi). Move the phy declaration to the dts files. Signed-off-by: Jason Cooper diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts index 5a31964..3046d1f 100644 --- a/arch/arm/boot/dts/omap3-beagle-xm.dts +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts @@ -122,6 +122,7 @@ &usb_otg_hs { interface-type = <0>; + usb-phy = <&usb2_phy>; mode = <3>; power = <50>; }; diff --git a/arch/arm/boot/dts/omap3-evm.dts b/arch/arm/boot/dts/omap3-evm.dts index 05f51e1..96d1c20 100644 --- a/arch/arm/boot/dts/omap3-evm.dts +++ b/arch/arm/boot/dts/omap3-evm.dts @@ -68,6 +68,7 @@ &usb_otg_hs { interface-type = <0>; + usb-phy = <&usb2_phy>; mode = <3>; power = <50>; }; diff --git a/arch/arm/boot/dts/omap3-overo.dtsi b/arch/arm/boot/dts/omap3-overo.dtsi index d4a7280..a626c50 100644 --- a/arch/arm/boot/dts/omap3-overo.dtsi +++ b/arch/arm/boot/dts/omap3-overo.dtsi @@ -73,6 +73,7 @@ &usb_otg_hs { interface-type = <0>; + usb-phy = <&usb2_phy>; mode = <3>; power = <50>; }; diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi index 4ad03d9..82a404d 100644 --- a/arch/arm/boot/dts/omap3.dtsi +++ b/arch/arm/boot/dts/omap3.dtsi @@ -519,7 +519,6 @@ interrupts = <0 92 0x4>, <0 93 0x4>; interrupt-names = "mc", "dma"; ti,hwmods = "usb_otg_hs"; - usb-phy = <&usb2_phy>; multipoint = <1>; num-eps = <16>; ram-bits = <12>;