From patchwork Tue Jun 4 18:10:30 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Russell King - ARM Linux X-Patchwork-Id: 2661371 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork2.kernel.org (Postfix) with ESMTP id 5FC9EDF2A1 for ; Tue, 4 Jun 2013 18:11:33 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Ujvhj-0006qF-J5; Tue, 04 Jun 2013 18:11:31 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Ujvhg-0004C1-Oh; Tue, 04 Jun 2013 18:11:28 +0000 Received: from caramon.arm.linux.org.uk ([78.32.30.218]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Ujvhc-0004BD-Tf for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2013 18:11:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=arm.linux.org.uk; s=caramon; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=ROVsh8IUxx9wXkczfi8+R8EHOUhrE3Kw/icFGn9H+QM=; b=dAEa27ODTCyoYr/jOZUtta0Yv5asf61uBz1zqJIcB+3KfiydGfcnYJr05APAtP6DCq9NTkD8Ewc1uvBloZWZihgMsWMgZLuXzg8AYbyI/OSETpxGBvuc4Rdsc5WGUoEAwrcp6jgj+9GmrzYR5u/bJeNp6d0Pk5AxlrC3DlVNIJM=; Received: from n2100.arm.linux.org.uk ([2002:4e20:1eda:1:214:fdff:fe10:4f86]:39402) by caramon.arm.linux.org.uk with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1Ujvgm-0000JM-BQ; Tue, 04 Jun 2013 19:10:32 +0100 Received: from linux by n2100.arm.linux.org.uk with local (Exim 4.76) (envelope-from ) id 1Ujvgk-0000ds-Uq; Tue, 04 Jun 2013 19:10:31 +0100 Date: Tue, 4 Jun 2013 19:10:30 +0100 From: Russell King - ARM Linux To: Nicolas Pitre Subject: Re: [PATCH v2 1/2] ARM PJ4B: Add support for errata 4742 Message-ID: <20130604181030.GA18614@n2100.arm.linux.org.uk> References: <1370354598-12920-1-git-send-email-gregory.clement@free-electrons.com> <1370354598-12920-2-git-send-email-gregory.clement@free-electrons.com> <20130604145958.GY18614@n2100.arm.linux.org.uk> <51AE21A7.5080907@free-electrons.com> <20130604173737.GZ18614@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130604_141125_320030_3685AAF6 X-CRM114-Status: GOOD ( 13.05 ) X-Spam-Score: -4.8 (----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-4.8 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [78.32.30.218 listed in list.dnswl.org] -0.5 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Lior Amsalem , Thomas Petazzoni , Yehuda Yitschak , Ike Pan , Jason Cooper , Tawfik Bayouk , Andrew Lunn , Dan Frazier , Chris Van Hoof , Will Deacon , Eran Ben-Avi , Nadav Haklai , Maen Suleiman , Shadi Ammouri , Ezequiel Garcia , Jon Masters , Gregory CLEMENT , Sebastian Hesselbarth , David Marlin , linux-arm-kernel@lists.infradead.org, Leif Lindholm X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Tue, Jun 04, 2013 at 02:07:29PM -0400, Nicolas Pitre wrote: > It could be nicer on the symbol table especially when debugging if the > pj4b was made into a separate branch table e.g.: > > ENTRY(cpu_pj4b_switch_mm) > b cpu_v7_switch_mm > ENDPROC(cpu_pj4b_switch_mm) > > Otherwise the objdump output will always select the first symbol for any > given address in alphabetical order, masking away cpu_v7_switch_mm. That adds unnecessary runtime expense. > Alternatively, the following could be done: > > #ifdef CONFIG_CPU_PJ4B > > .equ cpu_pj4b_switch_mm, cpu_v7_switch_mm > .equ cpu_pj4b_set_pte_ex, cpu_v7_set_pte_ex No, that doesn't work. I did forget a hunk from my patch though, which needs the pj4b symbols to be global: diff --git a/arch/arm/include/asm/glue-proc.h b/arch/arm/include/asm/glue-proc.h index ac1dd54..8017e94 100644 --- a/arch/arm/include/asm/glue-proc.h +++ b/arch/arm/include/asm/glue-proc.h @@ -230,6 +230,15 @@ # endif #endif +#ifdef CONFIG_CPU_PJ4B +# ifdef CPU_NAME +# undef MULTI_CPU +# define MULTI_CPU +# else +# define CPU_NAME cpu_pj4b +# endif +#endif + #ifndef MULTI_CPU #define cpu_proc_init __glue(CPU_NAME,_proc_init) #define cpu_proc_fin __glue(CPU_NAME,_proc_fin)