From patchwork Wed Jun 19 17:40:47 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 2751031 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A297C9F8E1 for ; Wed, 19 Jun 2013 17:41:34 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8026D2028F for ; Wed, 19 Jun 2013 17:41:33 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F8DF2026D for ; Wed, 19 Jun 2013 17:41:32 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UpMNq-0002yQ-9v; Wed, 19 Jun 2013 17:41:26 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UpMNn-0000ty-4s; Wed, 19 Jun 2013 17:41:23 +0000 Received: from [2001:41c8:1:5384::2] (helo=cassiel.sirena.org.uk) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UpMNh-0000tF-Pg for linux-arm-kernel@lists.infradead.org; Wed, 19 Jun 2013 17:41:20 +0000 Received: from cpc2-sgyl4-0-0-cust177.18-2.cable.virginmedia.com ([82.42.102.178] helo=finisterre) by cassiel.sirena.org.uk with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1UpMNE-0005mZ-Nn; Wed, 19 Jun 2013 18:40:50 +0100 Received: from broonie by finisterre with local (Exim 4.80) (envelope-from ) id 1UpMND-0008EJ-3b; Wed, 19 Jun 2013 18:40:47 +0100 Date: Wed, 19 Jun 2013 18:40:47 +0100 From: Mark Brown To: Tomasz Figa Message-ID: <20130619174047.GB1403@sirena.org.uk> References: <1371416058-22047-1-git-send-email-tomasz.figa@gmail.com> MIME-Version: 1.0 In-Reply-To: <1371416058-22047-1-git-send-email-tomasz.figa@gmail.com> X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 82.42.102.178 X-SA-Exim-Mail-From: broonie@sirena.org.uk X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Subject: Re: [RFC PATCH 00/11] ARM: s3c64xx: Let amba-pl08x driver handle DMA X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:57:07 +0000) X-SA-Exim-Scanned: Yes (on cassiel.sirena.org.uk) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130619_134118_388816_A82D9F72 X-CRM114-Status: GOOD ( 21.36 ) X-Spam-Score: -1.1 (-) Cc: alsa-devel@alsa-project.org, Heiko =?iso-8859-1?Q?St=FCbner?= , Padmavathi Venna , Takashi Iwai , Linus Walleij , linux-kernel@vger.kernel.org, Giancarlo Asnaghi , Kukjin Kim , Russell King - ARM Linux , Vinod Koul , Thomas Abraham , Grant Likely , Alessandro Rubini , Arnd Bergmann , linux-samsung-soc@vger.kernel.org, Sylwester Nawrocki , Jaroslav Kysela , linux-arm-kernel@lists.infradead.org, Sangbeom Kim , Liam Girdwood , linux-spi@vger.kernel.org, Dan Williams , Olof Johansson , Alban Bedel X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Sun, Jun 16, 2013 at 10:54:07PM +0200, Tomasz Figa wrote: > One of the biggest roadblocks on the way of S3C64xx to DeviceTree support > is its DMA driver, which is completely platform-specific and provides > private API (s3c-dma), not even saying that its design is completely > against multiplatform-awareness. I tried to test this on my s3c64xx based system but it gave me a kernel that didn't boot far enough to give console output (there's some early init stuff that uses SPI...). That said, I needed: to get it to build which makes me suspect the compiler a bit as well... the system has audio, SPI and MMC enabled. I was applying this to -next, are there any other dependencies I need or anything? diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index 210a893..0f49707 100644 --- a/drivers/dma/amba-pl08x.c +++ b/drivers/dma/amba-pl08x.c @@ -313,7 +313,7 @@ static int pl08x_request_mux(struct pl08x_dma_chan *plchan) int ret; if (plchan->mux_use++ == 0 && pd->get_signal) { - ret = pd->get_signal(plchan->cd); + ret = (pd->get_signal)(plchan->cd); if (ret < 0) { plchan->mux_use = 0; return ret;