From patchwork Wed Jul 17 15:18:16 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Russell King - ARM Linux X-Patchwork-Id: 2828776 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id CB552C0AB2 for ; Wed, 17 Jul 2013 15:21:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0312E20348 for ; Wed, 17 Jul 2013 15:20:59 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27C3820324 for ; Wed, 17 Jul 2013 15:20:57 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UzTVd-0000qX-7T; Wed, 17 Jul 2013 15:19:17 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UzTVO-0006ns-U8; Wed, 17 Jul 2013 15:19:02 +0000 Received: from caramon.arm.linux.org.uk ([78.32.30.218]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UzTVH-0006jz-Nb for linux-arm-kernel@lists.infradead.org; Wed, 17 Jul 2013 15:18:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=arm.linux.org.uk; s=caramon; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=j+HZlpUQ1zQLn5PHSOFFk1pU6eEChx2xJjz9mTL27KU=; b=fubzSs9OmdCSD/UjCulF5lG5Q4IyfzlarVKF02RXRrbVGrODAdDwP5LkJwc7oto7PMBQI7hN7dqHPPs+WSu8GBuj21p2FX+LKW0AGNB6TesRyAvvt6RIoWT5lfLV6dKkkvSuJumxHzXtoT/76KBPfEfJliJ1Qe+jJBou/QIb384=; Received: from n2100.arm.linux.org.uk ([2002:4e20:1eda:1:214:fdff:fe10:4f86]:42371) by caramon.arm.linux.org.uk with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1UzTUh-0000bx-1O; Wed, 17 Jul 2013 16:18:19 +0100 Received: from linux by n2100.arm.linux.org.uk with local (Exim 4.76) (envelope-from ) id 1UzTUe-000175-OH; Wed, 17 Jul 2013 16:18:16 +0100 Date: Wed, 17 Jul 2013 16:18:16 +0100 From: Russell King - ARM Linux To: Stefano Stabellini Subject: Re: [PATCH] arm: choose debug/uncompress.h include when uncompress debug is disabled Message-ID: <20130717151816.GN24642@n2100.arm.linux.org.uk> References: <1373897706-15331-1-git-send-email-julien.grall@linaro.org> <20130717151148.GM24642@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130717151148.GM24642@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.19 (2009-01-05) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130717_111856_151780_BCF5FD5C X-CRM114-Status: GOOD ( 25.88 ) X-Spam-Score: -4.7 (----) Cc: Ian Campbell , Arnd Bergmann , patches@linaro.org, Julien Grall , linux-kernel@vger.kernel.org, Olof Johansson , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Jul 17, 2013 at 04:11:48PM +0100, Russell King - ARM Linux wrote: > On Wed, Jul 17, 2013 at 02:25:38PM +0100, Stefano Stabellini wrote: > > On Mon, 15 Jul 2013, Julien Grall wrote: > > > Even if uncompress debug is disabled, some board will continue to print > > > information during uncompress step. > > > > Are you talking about DEBUG_UNCOMPRESS? > > Should I read the sentence as "even if DEBUG_UNCOMPRESS is not selected, > > some board will continue to print information during the uncompress step"? > > > > Isn't this a bug in the platform specific code that should be fixed anyway? > > Hang on, let's be clear what's going on here. > > 1. The normal output from the decompressor is *not* debugging. By that > I mean the "Uncompressing kernel... done" message. That is part of > user output. > > 2. In non-multiplatform environments, the decompressor will normally use > the putc/flush functions found in arch/arm/mach-*/include/mach/uncompress.h > to implement its output, irrespective of the DEBUG_UNCOMPRESS setting. > (An interesting point is that DEBUG_UNCOMPRESS really should depend on > MULTIPLATFORM so that this point is explicit - the option requires > MULTIPLATFORM to be set.) > > 3. DEBUG_UNCOMPRESS allows the functions which we've implemented for LL > debug to be re-used for decompressor output. > > 4. When DEBUG_UNCOMPRESS is not set in a multiplatform kernel, the > decompressors putc() and flush() functions are stubbed out. > > So, it's quite right that you get output from the decompressor even when > DEBUG_UNCOMPRESS is not set. There's no problem with that. Does this patch help to explain this? arch/arm/Kconfig.debug | 14 ++++++++++++-- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index e401a76..583f4a0 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -804,9 +804,19 @@ config DEBUG_LL_INCLUDE config DEBUG_UNCOMPRESS bool - default y if ARCH_MULTIPLATFORM && DEBUG_LL && \ - !DEBUG_OMAP2PLUS_UART && \ + depends on ARCH_MULTIPLATFORM + default y if DEBUG_LL && !DEBUG_OMAP2PLUS_UART && \ !DEBUG_TEGRA_UART + help + This option influences the normal decompressor output only for + multiplatform kernels. Normally, multiplatform kernels disable + decompressor output because it is not possible to know where to + send the decompressor output. + + When this option is set, the selected DEBUG_LL output method + will be re-used for normal decompressor output on multiplatform + kernels. + config UNCOMPRESS_INCLUDE string