diff mbox

Inte IOP Xscale updates

Message ID 20130903134516.GH6617@n2100.arm.linux.org.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Russell King - ARM Linux Sept. 3, 2013, 1:45 p.m. UTC
On Tue, Sep 03, 2013 at 02:01:45PM +0200, Linus Walleij wrote:
> Hi XScale folks,
> 
> I haven't really seen any functional patches or confirmation that the
> XScale machines in arch/arm/iop* are even booting since 2010 or
> so.
> 
> Can you confirm that you boot-test these machines regularly?
> 
> I am worried that we maintain code that is not used or even working
> see.
> 
> What are your thought about multiplatform and device tree? I am
> pretty certain that if the iop machines were converted to device tree
> we could collapse these machines into one directory with few files,
> but I may be wrong.

Just because code doesn't get touched doesn't mean it doesn't work.  In
some cases, that means that the code has reached stability.

The IOP platforms are in regular use.  IOP platforms include such
things as TheCUS machines such as the N2100 and others.  The two N2100s
I have here run 3.1.8 and 3.9.5.  3.9.5 did not require any changes to
arch/arm code for it to work - though it did require a minor change
to the IOP watchdog driver so it would build, namely:

Comments

Mikael Pettersson Sept. 7, 2013, 10:45 a.m. UTC | #1
Russell King - ARM Linux writes:
 > On Tue, Sep 03, 2013 at 02:01:45PM +0200, Linus Walleij wrote:
 > > Hi XScale folks,
 > > 
 > > I haven't really seen any functional patches or confirmation that the
 > > XScale machines in arch/arm/iop* are even booting since 2010 or
 > > so.
 > > 
 > > Can you confirm that you boot-test these machines regularly?
 > > 
 > > I am worried that we maintain code that is not used or even working
 > > see.
 > > 
 > > What are your thought about multiplatform and device tree? I am
 > > pretty certain that if the iop machines were converted to device tree
 > > we could collapse these machines into one directory with few files,
 > > but I may be wrong.
 > 
 > Just because code doesn't get touched doesn't mean it doesn't work.  In
 > some cases, that means that the code has reached stability.
 > 
 > The IOP platforms are in regular use.  IOP platforms include such
 > things as TheCUS machines such as the N2100 and others.  The two N2100s
 > I have here run 3.1.8 and 3.9.5.

I just booted 3.9, 3.10, and 3.11 on my N2100, without problems.

Compared to the Kirkwood Qnaps the N2100 is quite slow and noisy,
so I haven't actually used mine in years.

As long as they doesn't cause any maintenance problems I think we
should just leave the IOP platforms as-is.
Russell King - ARM Linux Sept. 7, 2013, 11:14 a.m. UTC | #2
On Sat, Sep 07, 2013 at 12:45:12PM +0200, Mikael Pettersson wrote:
> Compared to the Kirkwood Qnaps the N2100 is quite slow and noisy,
> so I haven't actually used mine in years.

"noisy" is not something I recognise from my two.  The standard fan
was noisy, but that's because its rather cheap.  There's replacements
available on the net - NF-A4x10 - which are dead silent, plug in to
the existing fan connector, and give a proper fan RPM speed so it's
possible to configure the F75375 to do automatic fan speed control on
its own.
Mikael Pettersson Sept. 7, 2013, 1:19 p.m. UTC | #3
Russell King - ARM Linux writes:
 > On Sat, Sep 07, 2013 at 12:45:12PM +0200, Mikael Pettersson wrote:
 > > Compared to the Kirkwood Qnaps the N2100 is quite slow and noisy,
 > > so I haven't actually used mine in years.
 > 
 > "noisy" is not something I recognise from my two.  The standard fan
 > was noisy, but that's because its rather cheap.  There's replacements
 > available on the net - NF-A4x10 - which are dead silent, plug in to
 > the existing fan connector, and give a proper fan RPM speed so it's
 > possible to configure the F75375 to do automatic fan speed control on
 > its own.

That's good to know, thanks.
Linus Walleij Sept. 9, 2013, 6:37 a.m. UTC | #4
On Sat, Sep 7, 2013 at 12:45 PM, Mikael Pettersson <mikpe@it.uu.se> wrote:

> As long as they doesn't cause any maintenance problems I think we
> should just leave the IOP platforms as-is.

Well I looked over all machines last week and for IOP there is
one thing that stand out, and it's that iop32x and iop33x are
using <mach/gpio.h> and that is a headache for me as GPIO
maintainer, as I want to consolidate that subsystem and get
away from custom GPIO headers.

But I take it that you're ready to test patches for me, so
I'll hopefully get around to propose something for the
iop32x :-)

Basically I'd move <asm/hardware/iop3xx-gpio.h> down
into drivers/gpio as a gpiochip instead.

Yours,
Linus Walleij
diff mbox

Patch

diff --git a/drivers/watchdog/iop_wdt.c b/drivers/watchdog/iop_wdt.c
index d964faf..3841120 100644
--- a/drivers/watchdog/iop_wdt.c
+++ b/drivers/watchdog/iop_wdt.c
@@ -234,7 +234,7 @@  static int __init iop_wdt_init(void)
        /* Configure Watchdog Timeout to cause an Internal Bus (IB) Reset
         * NOTE: An IB Reset will Reset both cores in the IOP342
         */
-       write_wdtsr(IOP13XX_WDTCR_IB_RESET);
+//     write_wdtsr(IOP13XX_WDTCR_IB_RESET);
 
        /* Register after we have the device set up so we cannot race
           with an open */