diff mbox

[1/1] imx51.dtsi: fix PATA device clock

Message ID 20130907132507.353801753@rtp-net.org (mailing list archive)
State New, archived
Headers show

Commit Message

Arnaud Patard (Rtp) Sept. 7, 2013, 1:23 p.m. UTC
Commit 718a35006f3fa48540d69bd649ff76ea4cdc1ef2 adds pata support to the
imx51.dtsi file and is using clock 161. The problem is that the right clock
is 172, according to 5d530bb0ad84d403d1aac79a8a8acf2c2b0a8dd7.
Using the clock 172 makes things work again (and kills a nasty system freeze)


Tested-by: Steve Klimaszewski <steev@gentoo.org>
Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>

Comments

Steev Klimaszewski Sept. 7, 2013, 1:32 p.m. UTC | #1
Minor nit: It's Steev Klimaszewski, not Steve.

On Sat, Sep 7, 2013 at 8:23 AM, Arnaud Patard <arnaud.patard@rtp-net.org> wrote:
> Commit 718a35006f3fa48540d69bd649ff76ea4cdc1ef2 adds pata support to the
> imx51.dtsi file and is using clock 161. The problem is that the right clock
> is 172, according to 5d530bb0ad84d403d1aac79a8a8acf2c2b0a8dd7.
> Using the clock 172 makes things work again (and kills a nasty system freeze)
>
>
> Tested-by: Steve Klimaszewski <steev@gentoo.org>
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
>
> Index: linux-next/arch/arm/boot/dts/imx51.dtsi
> ===================================================================
> --- linux-next.orig/arch/arm/boot/dts/imx51.dtsi        2013-09-07 15:08:05.042280170 +0200
> +++ linux-next/arch/arm/boot/dts/imx51.dtsi     2013-09-07 15:08:37.338278750 +0200
> @@ -490,7 +490,7 @@
>                                 compatible = "fsl,imx51-pata", "fsl,imx27-pata";
>                                 reg = <0x83fe0000 0x4000>;
>                                 interrupts = <70>;
> -                               clocks = <&clks 161>;
> +                               clocks = <&clks 172>;
>                                 status = "disabled";
>                         };
>
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Sergei Shtylyov Sept. 7, 2013, 1:36 p.m. UTC | #2
Hello.

On 07-09-2013 17:23, Arnaud Patard (Rtp) wrote:

    Why you sent the patch as attachment?

> Commit 718a35006f3fa48540d69bd649ff76ea4cdc1ef2 adds pata support to the
> imx51.dtsi file and is using clock 161. The problem is that the right clock
> is 172, according to 5d530bb0ad84d403d1aac79a8a8acf2c2b0a8dd7.

    Please specify those commits' summaries in paren

> Using the clock 172 makes things work again (and kills a nasty system freeze)


> Tested-by: Steve Klimaszewski<steev@gentoo.org>
> Signed-off-by: Arnaud Patard<arnaud.patard@rtp-net.org>

WBR, Sergei
Shawn Guo Sept. 9, 2013, 2:41 p.m. UTC | #3
On Sat, Sep 07, 2013 at 03:23:14PM +0200, Arnaud Patard wrote:
> Commit 718a35006f3fa48540d69bd649ff76ea4cdc1ef2 adds pata support to the
> imx51.dtsi file and is using clock 161. The problem is that the right clock
> is 172, according to 5d530bb0ad84d403d1aac79a8a8acf2c2b0a8dd7.
> Using the clock 172 makes things work again (and kills a nasty system freeze)
> 
> 
> Tested-by: Steve Klimaszewski <steev@gentoo.org>
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>

Applied with the commit log as below.

ARM: imx51.dtsi: fix PATA device clock

Commit 718a350 (ARM: i.MX51: Add PATA support) adds pata support to the
imx51.dtsi file and is using clock 161. The problem is that the right
clock is 172, according to commit 5d530bb (ARM: i.MX5: Add PATA and SRTC
clocks).  Using the clock 172 makes things work again (and kills a nasty
system freeze).

Tested-by: Steev Klimaszewski <steev@gentoo.org>
Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>

Shawn

> 
> Index: linux-next/arch/arm/boot/dts/imx51.dtsi
> ===================================================================
> --- linux-next.orig/arch/arm/boot/dts/imx51.dtsi	2013-09-07 15:08:05.042280170 +0200
> +++ linux-next/arch/arm/boot/dts/imx51.dtsi	2013-09-07 15:08:37.338278750 +0200
> @@ -490,7 +490,7 @@
>  				compatible = "fsl,imx51-pata", "fsl,imx27-pata";
>  				reg = <0x83fe0000 0x4000>;
>  				interrupts = <70>;
> -				clocks = <&clks 161>;
> +				clocks = <&clks 172>;
>  				status = "disabled";
>  			};
>  
> 
>
diff mbox

Patch

Index: linux-next/arch/arm/boot/dts/imx51.dtsi
===================================================================
--- linux-next.orig/arch/arm/boot/dts/imx51.dtsi	2013-09-07 15:08:05.042280170 +0200
+++ linux-next/arch/arm/boot/dts/imx51.dtsi	2013-09-07 15:08:37.338278750 +0200
@@ -490,7 +490,7 @@ 
 				compatible = "fsl,imx51-pata", "fsl,imx27-pata";
 				reg = <0x83fe0000 0x4000>;
 				interrupts = <70>;
-				clocks = <&clks 161>;
+				clocks = <&clks 172>;
 				status = "disabled";
 			};