From patchwork Fri Sep 13 16:17:10 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaro Koskinen X-Patchwork-Id: 2890711 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 94E23BFF05 for ; Fri, 13 Sep 2013 16:18:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8C49F2024A for ; Fri, 13 Sep 2013 16:18:57 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DEA520233 for ; Fri, 13 Sep 2013 16:18:52 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VKW4r-0000SQ-1N; Fri, 13 Sep 2013 16:18:37 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VKW4i-0008Uj-I5; Fri, 13 Sep 2013 16:18:28 +0000 Received: from casper.infradead.org ([2001:770:15f::2]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VKW4f-0008TK-MH for linux-arm-kernel@merlin.infradead.org; Fri, 13 Sep 2013 16:18:25 +0000 Received: from filtteri1.pp.htv.fi ([213.243.153.184]) by casper.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VKW4N-0008F7-0p for linux-arm-kernel@lists.infradead.org; Fri, 13 Sep 2013 16:18:08 +0000 Received: from localhost (localhost [127.0.0.1]) by filtteri1.pp.htv.fi (Postfix) with ESMTP id 7E67F21B941; Fri, 13 Sep 2013 19:17:22 +0300 (EEST) X-Virus-Scanned: Debian amavisd-new at pp.htv.fi Received: from smtp5.welho.com ([213.243.153.39]) by localhost (filtteri1.pp.htv.fi [213.243.153.184]) (amavisd-new, port 10024) with ESMTP id 8r9XiT9FtA6Z; Fri, 13 Sep 2013 19:17:17 +0300 (EEST) Received: from musicnaut.iki.fi (cs181064211.pp.htv.fi [82.181.64.211]) by smtp5.welho.com (Postfix) with SMTP id 81CC55BC003; Fri, 13 Sep 2013 19:17:16 +0300 (EEST) Received: by musicnaut.iki.fi (sSMTP sendmail emulation); Fri, 13 Sep 2013 19:17:10 +0300 Date: Fri, 13 Sep 2013 19:17:10 +0300 From: Aaro Koskinen To: Linus Walleij Subject: Re: [PATCH 0/8] IOP GPIO refactoring Message-ID: <20130913161710.GA22033@blackmetal.musicnaut.iki.fi> References: <1378741198-12847-1-git-send-email-linus.walleij@linaro.org> <20130910141434.GD3379@blackmetal.musicnaut.iki.fi> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130913_171807_445439_FDB72C45 X-CRM114-Status: GOOD ( 16.43 ) X-Spam-Score: -1.9 (-) Cc: Mikael Pettersson , "linux-gpio@vger.kernel.org" , Alexandre Courbot , Dan Williams , Lennert Buytenhek , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, On Fri, Sep 13, 2013 at 10:15:58AM +0200, Linus Walleij wrote: > On Tue, Sep 10, 2013 at 4:14 PM, Aaro Koskinen wrote: > > With patch 6 it starts to crash on first gpio_get_value(), I guess > > because gpio-iop platform device is not registered on N2100...? > > I think I've fixed this with the v2 versions of patches 1-3, you can > pull in and test the entire stack on Torvalds HEAD from here: > > git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git iop-cleanup It's still crashing. This should be done somewhere in the series: A. diff --git a/arch/arm/mach-iop32x/n2100.c b/arch/arm/mach-iop32x/n2100.c index bc40a97..6266f0e 100644 --- a/arch/arm/mach-iop32x/n2100.c +++ b/arch/arm/mach-iop32x/n2100.c @@ -343,8 +343,14 @@ static int __init n2100_request_gpios(void) } device_initcall(n2100_request_gpios); +static struct resource n2100_gpio_res[] = { + DEFINE_RES_MEM((IOP3XX_PERIPHERAL_PHYS_BASE + 0x07c4), 0x10), +}; + static void __init n2100_init_machine(void) { + platform_device_register_simple("gpio-iop", 0, n2100_gpio_res, + ARRAY_SIZE(n2100_gpio_res)); platform_device_register(&iop3xx_i2c0_device); platform_device_register(&n2100_flash_device); platform_device_register(&n2100_serial_device);