From patchwork Fri Dec 6 20:46:29 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 3299551 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 937ABC0D4A for ; Fri, 6 Dec 2013 20:48:04 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 921E0203E6 for ; Fri, 6 Dec 2013 20:48:03 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88743201FD for ; Fri, 6 Dec 2013 20:48:02 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vp2JP-0001HR-J6; Fri, 06 Dec 2013 20:47:47 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vp2JN-0000zJ-2V; Fri, 06 Dec 2013 20:47:45 +0000 Received: from arroyo.ext.ti.com ([192.94.94.40]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vp2JK-0000yb-8v for linux-arm-kernel@lists.infradead.org; Fri, 06 Dec 2013 20:47:43 +0000 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id rB6Kl6EP026985; Fri, 6 Dec 2013 14:47:06 -0600 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id rB6Kl6AM031282; Fri, 6 Dec 2013 14:47:06 -0600 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.2.342.3; Fri, 6 Dec 2013 14:47:05 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id rB6Kl6QM021717; Fri, 6 Dec 2013 14:47:06 -0600 Date: Fri, 6 Dec 2013 14:46:29 -0600 From: Felipe Balbi To: Aaro Koskinen Subject: Re: [PATCH v4 4/4] USB: OMAP1: Tahvo USB transceiver driver Message-ID: <20131206204629.GL21086@saruman.home> References: <1386339187-28466-1-git-send-email-aaro.koskinen@iki.fi> <1386339187-28466-5-git-send-email-aaro.koskinen@iki.fi> MIME-Version: 1.0 In-Reply-To: <1386339187-28466-5-git-send-email-aaro.koskinen@iki.fi> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131206_154742_410518_0AD91F3E X-CRM114-Status: GOOD ( 14.55 ) X-Spam-Score: -7.1 (-------) Cc: linux-omap@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Felipe Balbi X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: balbi@ti.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Dec 06, 2013 at 04:13:07PM +0200, Aaro Koskinen wrote: > Add Tahvo USB transceiver driver. > > Based on old code from linux-omap tree. The original driver was written > by Juha Yrjölä, Tony Lindgren, and Timo Teräs. > > Signed-off-by: Aaro Koskinen compile error: CC [M] drivers/usb/phy/phy-tahvo.o drivers/usb/phy/phy-tahvo.c: In function ‘tahvo_usb_probe’: drivers/usb/phy/phy-tahvo.c:371:2: error: too many arguments to function ‘extcon_dev_register’ ret = extcon_dev_register(&tu->extcon, &pdev->dev); ^ In file included from drivers/usb/phy/phy-tahvo.c:26:0: include/linux/extcon.h:186:12: note: declared here extern int extcon_dev_register(struct extcon_dev *edev); ^ make[1]: *** [drivers/usb/phy/phy-tahvo.o] Error 1 make: *** [drivers/usb/phy/] Error 2 fixed it up with: please make sure it still works with v3.13-rc2 + this patch. diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c index 7cf1766..8bb833e 100644 --- a/drivers/usb/phy/phy-tahvo.c +++ b/drivers/usb/phy/phy-tahvo.c @@ -368,7 +368,9 @@ static int tahvo_usb_probe(struct platform_device *pdev) tu->extcon.name = DRIVER_NAME; tu->extcon.supported_cable = tahvo_cable; - ret = extcon_dev_register(&tu->extcon, &pdev->dev); + tu->extcon.dev.parent = &pdev->dev; + + ret = extcon_dev_register(&tu->extcon); if (ret) { dev_err(&pdev->dev, "could not register extcon device: %d\n", ret);