From patchwork Tue Dec 10 20:16:40 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 3320231 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 755519F1F0 for ; Tue, 10 Dec 2013 20:18:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7E57C2061E for ; Tue, 10 Dec 2013 20:18:20 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED12F20614 for ; Tue, 10 Dec 2013 20:18:18 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VqTl1-0002Vx-Aq; Tue, 10 Dec 2013 20:18:15 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VqTky-0004l9-Rm; Tue, 10 Dec 2013 20:18:12 +0000 Received: from arroyo.ext.ti.com ([192.94.94.40]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VqTkw-0004k8-Aw for linux-arm-kernel@lists.infradead.org; Tue, 10 Dec 2013 20:18:11 +0000 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id rBAKHLoC025313; Tue, 10 Dec 2013 14:17:21 -0600 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id rBAKHLAR002642; Tue, 10 Dec 2013 14:17:21 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.2.342.3; Tue, 10 Dec 2013 14:17:20 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id rBAKHKIF014786; Tue, 10 Dec 2013 14:17:20 -0600 Date: Tue, 10 Dec 2013 14:16:40 -0600 From: Felipe Balbi To: Felipe Balbi Subject: Re: OMAP still fails - usb phy stuff Message-ID: <20131210201639.GD2464@saruman.home> References: <20131210130926.GZ4360@n2100.arm.linux.org.uk> <20131210183809.GL13171@atomide.com> <20131210192508.GB2464@saruman.home> MIME-Version: 1.0 In-Reply-To: <20131210192508.GB2464@saruman.home> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131210_151810_456384_BF499DD7 X-CRM114-Status: GOOD ( 20.11 ) X-Spam-Score: -7.1 (-------) Cc: Tony Lindgren , gregkh@linuxfoundation.org, Russell King - ARM Linux , linux-arm-kernel@lists.infradead.org, Kishon Vijay Abraham I X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: balbi@ti.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, On Tue, Dec 10, 2013 at 01:25:08PM -0600, Felipe Balbi wrote: > On Tue, Dec 10, 2013 at 10:38:10AM -0800, Tony Lindgren wrote: > > * Russell King - ARM Linux [131210 05:10]: > > > I still see some OMAP randconfigs failing with this: > > > > > > arch/arm/mach-omap2/built-in.o: In function `usbhs_init_phys': > > > dss-common.c:(.text+0x1396c): undefined reference to `usb_bind_phy' > > > arch/arm/mach-omap2/built-in.o: In function `omap_2430sdp_init': > > > dss-common.c:(.init.text+0x6c90): undefined reference to `usb_bind_phy' > > > drivers/built-in.o: In function `omap_usb2_remove': > > > powercap_sys.c:(.text+0x3520): undefined reference to `usb_remove_phy' > > > drivers/built-in.o: In function `omap_usb_power_off': > > > powercap_sys.c:(.text+0x3544): undefined reference to `omap_control_usb_phy_power' > > > drivers/built-in.o: In function `omap_usb_power_on': > > > powercap_sys.c:(.text+0x3568): undefined reference to `omap_control_usb_phy_power' > > > drivers/built-in.o: In function `omap_usb2_probe': > > > powercap_sys.c:(.text+0x3638): undefined reference to `omap_control_usb_phy_power' > > > powercap_sys.c:(.text+0x36d4): undefined reference to `usb_add_phy_dev' > > > drivers/built-in.o: In function `omap_usb2_suspend': > > > powercap_sys.c:(.text+0x37d0): undefined reference to `omap_control_usb_phy_power' > > > powercap_sys.c:(.text+0x37f4): undefined reference to `omap_control_usb_phy_power' > > > drivers/built-in.o: In function `omap_usb2_set_comparator': > > > powercap_sys.c:(.text+0x3844): undefined reference to `usb_get_phy' > > > drivers/built-in.o: In function `isp1704_charger_remove': > > > powercap_sys.c:(.text+0x48d5ec): undefined reference to `usb_put_phy' > > > drivers/built-in.o: In function `isp1704_charger_probe': > > > powercap_sys.c:(.text+0x48d64c): undefined reference to `usb_get_phy' > > > powercap_sys.c:(.text+0x48d884): undefined reference to `usb_put_phy' > > > drivers/built-in.o: In function `twl4030_bci_probe': > > > powercap_sys.c:(.init.text+0x13fd4): undefined reference to `usb_get_phy' > > > powercap_sys.c:(.init.text+0x14114): undefined reference to `usb_put_phy' > > > > > > Probably caused by over-use of the damned select statement: > > > > > > warning: (OMAP_USB2 && TWL4030_USB) selects USB_PHY which has unmet direct dependencies (USB_SUPPORT) > > > warning: (OMAP_USB2) selects OMAP_CONTROL_USB which has unmet direct dependencies (USB_SUPPORT && (ARCH_OMAP2PLUS || COMPILE_TEST)) > > > warning: (OMAP_USB2 && TWL4030_USB) selects USB_PHY which has unmet direct dependencies (USB_SUPPORT) > > > warning: (OMAP_USB2) selects OMAP_CONTROL_USB which has unmet direct dependencies (USB_SUPPORT && (ARCH_OMAP2PLUS || COMPILE_TEST)) > > > > > > You have to wonder why OMAP_USB2 can be enabled when USB_SUPPORT is > > > disabled. > > > > Yeah this causes constant randconfig errors. Felipe, I thought you > > had some fixes lined up for these few weeks ago already when we > > last talked about it? > > For the warnings, yeah. Greg's pull request hasn't been appliet yet > (need to check again, checked yesterday). > > For the build error, I'll send something today. this should fix it (checked with RMK's defconfig): i'll send it as a proper patch now. diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index a344f3d..d8b1a9a 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -24,9 +24,9 @@ config PHY_EXYNOS_MIPI_VIDEO config OMAP_USB2 tristate "OMAP USB2 PHY Driver" depends on ARCH_OMAP2PLUS + depends on OMAP_CONTROL_USB select GENERIC_PHY select USB_PHY - select OMAP_CONTROL_USB help Enable this to support the transceiver that is part of SOC. This driver takes care of all the PHY functionality apart from comparator.