From patchwork Fri Dec 20 16:10:02 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 3389791 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 521F1C0D4A for ; Fri, 20 Dec 2013 16:13:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F0EBC206E0 for ; Fri, 20 Dec 2013 16:13:06 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF09D204AF for ; Fri, 20 Dec 2013 16:13:02 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vu2g9-00042r-Aq; Fri, 20 Dec 2013 16:11:59 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vu2fo-0008SA-Vg; Fri, 20 Dec 2013 16:11:37 +0000 Received: from comal.ext.ti.com ([198.47.26.152]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vu2fR-0008Ou-UU for linux-arm-kernel@lists.infradead.org; Fri, 20 Dec 2013 16:11:22 +0000 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id rBKGAekO004860; Fri, 20 Dec 2013 10:10:40 -0600 Received: from DLEE70.ent.ti.com (dlemailx.itg.ti.com [157.170.170.113]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id rBKGAe3x024153; Fri, 20 Dec 2013 10:10:40 -0600 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.2.342.3; Fri, 20 Dec 2013 10:10:40 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id rBKGAdmO006754; Fri, 20 Dec 2013 10:10:39 -0600 Date: Fri, 20 Dec 2013 10:10:02 -0600 From: Felipe Balbi To: Tero Kristo Subject: Re: [PATCHv10 00/41] ARM: TI SoC clock DT conversion Message-ID: <20131220161001.GB5957@saruman.home> References: <1385453182-24421-1-git-send-email-t-kristo@ti.com> MIME-Version: 1.0 In-Reply-To: <1385453182-24421-1-git-send-email-t-kristo@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131220_111114_281593_43B9E2F3 X-CRM114-Status: GOOD ( 40.60 ) X-Spam-Score: -7.4 (-------) Cc: nm@ti.com, devicetree@vger.kernel.org, paul@pwsan.com, mturquette@linaro.org, tony@atomide.com, rnayak@ti.com, bcousson@baylibre.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: balbi@ti.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY, UPPERCASE_50_75 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, On Tue, Nov 26, 2013 at 10:05:41AM +0200, Tero Kristo wrote: > Changes compared to v9: > - rebased on top of 3.13-rc1 > - modified the low level clk register API to provide SoC specific clk_readl > and clk_writel support which can be registered during boot, TI SoC variant > uses regmap on low level > - dropped regmap parameter from clock init calls, instead a helper is used > for getting regmap index along with the register offset from DT > - dropped regmap parameter from clock structs, instead platform specific > clk_readl / clk_writel are used to parse reg parameter according to > platform, for TI SoC:s, this is encoded as: > struct clk_omap_reg { > u16 offset; /* register offset */ > u16 index; /* regmap index */ > } > - Nishanth's comments to v9 mostly addressed, except for the CLK_OF_DECLARE > tweak which I would actually want some feedback upon, basically the problem > is I need to return status from the clk init functions so I can see if > -EAGAIN is passed, in which case init will be retried later, maybe some of > this can be made generic, like converting all the CLK_OF_DECLARE type > functions to return status > > Testing done: > - omap3-beagle : boot + suspend/resume > - omap3-beagle-xm : boot (thanks to Nishanth) > - omap4-panda-es : boot + suspend/resume > - omap5-uevm : boot > - dra7-evm : boot > - am335x-bone : boot > > Separate branches available at https://github.com/t-kristo/linux-pm.git > > - full: 3.13-rc1-dt-clks-v10 (should be merged last, contains everything) > - clk driver only: 3.13-rc1-dt-clks-v10-for-mike > - DT data only: 3.13-rc1-dt-clks-v10-for-benoit OMAP5-only configuration doesn't build. Attached .config Below patch fixed it for me, but I'm not sure if it's the right fix: diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile index 088305f..1a627c6 100644 --- a/arch/arm/mach-omap2/Makefile +++ b/arch/arm/mach-omap2/Makefile @@ -189,7 +189,7 @@ obj-$(CONFIG_ARCH_OMAP3) += clkt_iclk.o obj-$(CONFIG_ARCH_OMAP4) += $(clock-common) obj-$(CONFIG_ARCH_OMAP4) += dpll3xxx.o dpll44xx.o obj-$(CONFIG_SOC_AM33XX) += $(clock-common) dpll3xxx.o -obj-$(CONFIG_SOC_OMAP5) += $(clock-common) +obj-$(CONFIG_SOC_OMAP5) += $(clock-common) clkt_iclk.o obj-$(CONFIG_SOC_OMAP5) += dpll3xxx.o dpll44xx.o # OMAP2 clock rate set data (old "OPP" data)