From patchwork Tue Mar 18 00:42:16 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Finn Thain X-Patchwork-Id: 3847071 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 56C7F9F370 for ; Tue, 18 Mar 2014 01:06:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 93806202A1 for ; Tue, 18 Mar 2014 01:06:57 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A53D20270 for ; Tue, 18 Mar 2014 01:06:56 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WPiU2-0007W0-80; Tue, 18 Mar 2014 01:06:22 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WPiTu-000410-CZ; Tue, 18 Mar 2014 01:06:14 +0000 Received: from kvm5.telegraphics.com.au ([98.124.60.144]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WPiTh-0003yu-Re for linux-arm-kernel@lists.infradead.org; Tue, 18 Mar 2014 01:06:02 +0000 Received: by kvm5.telegraphics.com.au (Postfix, from userid 502) id D53602494D; Mon, 17 Mar 2014 20:43:14 -0400 (EDT) Message-Id: <20140318004213.812935479@telegraphics.com.au> User-Agent: quilt/0.50-1 Date: Tue, 18 Mar 2014 11:42:16 +1100 From: Finn Thain To: "James E.J. Bottomley" , Subject: [PATCH 04/12] scsi/NCR5380: use NCR5380_dprint() instead of NCR5380_print() References: <20140318004212.612472697@telegraphics.com.au> Content-Disposition: inline; filename=ncr5380-debug-macros-sun3-NCR5380_print X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140317_210601_933160_4163565A X-CRM114-Status: UNSURE ( 6.92 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) Cc: Sam Creasey , linux-m68k@vger.kernel.org, Russell King , Michael Schmitz , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Only the NCR5380_dprint() macro should invoke the NCR5380_print() function. That's why NCR5380.c only defines the function #if NDEBUG. Use the standard macro. Signed-off-by: Finn Thain Reviewed-by: Christoph Hellwig --- drivers/scsi/sun3_scsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Index: linux-m68k/drivers/scsi/sun3_scsi.c =================================================================== --- linux-m68k.orig/drivers/scsi/sun3_scsi.c 2014-03-18 00:18:32.000000000 +1100 +++ linux-m68k/drivers/scsi/sun3_scsi.c 2014-03-18 00:18:33.000000000 +1100 @@ -79,8 +79,6 @@ #include #include "sun3_scsi.h" -static void NCR5380_print(struct Scsi_Host *instance); - /* #define OLDDMA */ #define USE_WRAPPER @@ -463,7 +461,7 @@ static unsigned long sun3scsi_dma_setup( printk("scsi%d: fifo_mismatch %04x not %04x\n", default_instance->host_no, dregs->fifo_count, (unsigned int) count); - NCR5380_print(default_instance); + NCR5380_dprint(NDEBUG_DMA, default_instance); } /* setup udc */