From patchwork Mon Apr 28 16:44:03 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 4080251 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id DF96B9F169 for ; Mon, 28 Apr 2014 16:48:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1F14B20274 for ; Mon, 28 Apr 2014 16:48:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 421DC201F4 for ; Mon, 28 Apr 2014 16:48:02 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Weog0-0003S0-6n; Mon, 28 Apr 2014 16:45:08 +0000 Received: from top.free-electrons.com ([176.31.233.9] helo=mail.free-electrons.com) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Weofu-0002cE-VU for linux-arm-kernel@lists.infradead.org; Mon, 28 Apr 2014 16:45:03 +0000 Received: by mail.free-electrons.com (Postfix, from userid 106) id 5BDF9807; Mon, 28 Apr 2014 18:44:35 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from localhost (unknown [190.2.108.30]) by mail.free-electrons.com (Postfix) with ESMTPSA id 53E757AE; Mon, 28 Apr 2014 18:44:34 +0200 (CEST) Date: Mon, 28 Apr 2014 13:44:03 -0300 From: Ezequiel Garcia To: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 10/10] ARM: mvebu: Enable the thermal sensor in Armada 380/385 SoC Message-ID: <20140428164403.GA17824@arch.cereza> References: <1398371004-15807-1-git-send-email-ezequiel.garcia@free-electrons.com> <1398371004-15807-11-git-send-email-ezequiel.garcia@free-electrons.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1398371004-15807-11-git-send-email-ezequiel.garcia@free-electrons.com> User-Agent: Mutt/1.5.22 (2013-10-16) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140428_094503_210349_2F5DB9E7 X-CRM114-Status: GOOD ( 11.62 ) X-Spam-Score: 0.3 (/) Cc: Thomas Petazzoni , Andrew Lunn , Jason Cooper , Tawfik Bayouk , devicetree@vger.kernel.org, Lior Amsalem , Gregory Clement , Zhang Rui , Sebastian Hesselbarth X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Apr 24, Ezequiel Garcia wrote: > This commit enables the thermal sensor found in Armada 380/385 SoCs. > > Signed-off-by: Ezequiel Garcia > --- > arch/arm/boot/dts/armada-38x.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi > index a064f59..02c6139 100644 > --- a/arch/arm/boot/dts/armada-38x.dtsi > +++ b/arch/arm/boot/dts/armada-38x.dtsi > @@ -346,6 +346,12 @@ > clock-output-names = "nand"; > }; > > + thermal@e8078 { > + compatible = "marvell,armada380-thermal"; > + reg = <0xe4078 0x4>, <0xe404 0x4>; Dammit, there's a stupid typo in the register offset. I never noticed this, because the initialization sequence does not do much, and this register is not really used (for now). The fix is this: Want me to send a follow-up patch? diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi index 02c6139..370220f 100644 --- a/arch/arm/boot/dts/armada-38x.dtsi +++ b/arch/arm/boot/dts/armada-38x.dtsi @@ -348,7 +348,7 @@ thermal@e8078 { compatible = "marvell,armada380-thermal"; - reg = <0xe4078 0x4>, <0xe404 0x4>; + reg = <0xe4078 0x4>, <0xe4074 0x4>; status = "okay"; };