From patchwork Fri May 9 02:19:09 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 4140021 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id BBE69BFF02 for ; Fri, 9 May 2014 02:23:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BEE37202EA for ; Fri, 9 May 2014 02:23:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86F59201F7 for ; Fri, 9 May 2014 02:23:05 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WiaPa-00011Q-1o; Fri, 09 May 2014 02:19:46 +0000 Received: from mail-bn1blp0181.outbound.protection.outlook.com ([207.46.163.181] helo=na01-bn1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WiaPW-0000xO-My for linux-arm-kernel@lists.infradead.org; Fri, 09 May 2014 02:19:44 +0000 Received: from BY2PR03CA057.namprd03.prod.outlook.com (10.141.249.30) by BY2PR03MB254.namprd03.prod.outlook.com (10.242.37.17) with Microsoft SMTP Server (TLS) id 15.0.934.12; Fri, 9 May 2014 02:19:17 +0000 Received: from BN1AFFO11FD054.protection.gbl (2a01:111:f400:7c10::181) by BY2PR03CA057.outlook.office365.com (2a01:111:e400:2c5d::30) with Microsoft SMTP Server (TLS) id 15.0.939.12 via Frontend Transport; Fri, 9 May 2014 02:19:17 +0000 Received: from az84smr01.freescale.net (192.88.158.2) by BN1AFFO11FD054.mail.protection.outlook.com (10.58.53.69) with Microsoft SMTP Server (TLS) id 15.0.929.8 via Frontend Transport; Fri, 9 May 2014 02:19:17 +0000 Received: from dragon ([10.192.185.1]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id s492JA6U021529; Thu, 8 May 2014 19:19:11 -0700 Date: Fri, 9 May 2014 10:19:09 +0800 From: Shawn Guo To: Iain Paton Subject: Re: [PATCH v2] ARM: dts: imx6: add new board RIoTboard Message-ID: <20140509021908.GJ2794@dragon> References: <53695C34.5000604@gmail.com> <536B9654.7020509@gmail.com> <1399560632.547109991@f294.i.mail.ru> <536BBAE2.7060203@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <536BBAE2.7060203@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:192.88.158.2; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009001)(6009001)(6029001)(24454002)(189002)(199002)(51704005)(479174003)(97736001)(97756001)(81156002)(19580395003)(99396002)(81542001)(2009001)(87936001)(21056001)(83506001)(33716001)(80022001)(47776003)(6806004)(69596002)(44976005)(83322001)(19580405001)(20776003)(79102001)(64706001)(84676001)(57986002)(4396001)(46406003)(77982001)(1411001)(50466002)(86362001)(76482001)(33656001)(50986999)(76176999)(77096999)(81342001)(54356999)(74502001)(74662001)(46102001)(92726001)(23726002)(92566001)(85852003)(31966008)(83072002); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR03MB254; H:az84smr01.freescale.net; FPR:; MLV:sfv; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Forefront-PRVS: 02065A9E77 Received-SPF: Fail (: domain of freescale.com does not designate 192.88.158.2 as permitted sender) receiver=; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=Shawn.Guo@freescale.com; X-OriginatorOrg: freescale.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140508_191942_983008_04F55830 X-CRM114-Status: GOOD ( 14.14 ) X-Spam-Score: -0.0 (/) Cc: Fabio Estevam , Fabio Estevam , Eric =?iso-8859-1?Q?B=E9nard?= , Alexander Shiyan , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, May 08, 2014 at 06:12:02PM +0100, Iain Paton wrote: > On 08/05/14 15:50, Alexander Shiyan wrote: > > > I think you should make patch series: > > 1. Add missing clock into imx6dl.dtsi > > 2. Add label to AIPS2 to imx6qdl.dtsi and use this label in imx6dl.dtsi > > 3. This patch > > I'm not sure I follow 1/2. You mean something like this > > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi > index eca0971..0645069 100644 > --- a/arch/arm/boot/dts/imx6qdl.dtsi > +++ b/arch/arm/boot/dts/imx6qdl.dtsi > @@ -767,7 +767,7 @@ > }; > }; > > - aips-bus@02100000 { /* AIPS2 */ > + aips2: aips-bus@02100000 { /* AIPS2 */ > compatible = "fsl,aips-bus", "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > > followed by > > > diff --git a/arch/arm/boot/dts/imx6dl.dtsi b/arch/arm/boot/dts/imx6dl.dtsi > index 5c5f574..81b7501 100644 > --- a/arch/arm/boot/dts/imx6dl.dtsi > +++ b/arch/arm/boot/dts/imx6dl.dtsi > @@ -80,16 +80,6 @@ > }; > }; > > - aips2: aips-bus@02100000 { > - i2c4: i2c@021f8000 { > - #address-cells = <1>; > - #size-cells = <0>; > - compatible = "fsl,imx1-i2c"; > - reg = <0x021f8000 0x4000>; > - interrupts = <0 35 IRQ_TYPE_LEVEL_HIGH>; > - status = "disabled"; > - }; > - }; > }; > > display-subsystem { > @@ -98,6 +88,18 @@ > }; > }; > > +&aips2 { > + i2c4: i2c@021f8000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "fsl,imx1-i2c"; > + reg = <0x021f8000 0x4000>; > + interrupts = <0 35 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clks 116>; > + status = "disabled"; > + }; > +}; > + > &hdmi { > compatible = "fsl,imx6dl-hdmi"; > }; I do not think we need so many changes. The only necessary changes would be something like below. diff --git a/arch/arm/boot/dts/imx6dl.dtsi b/arch/arm/boot/dts/imx6dl.dtsi index 5c5f574..12d582a 100644 --- a/arch/arm/boot/dts/imx6dl.dtsi +++ b/arch/arm/boot/dts/imx6dl.dtsi @@ -84,9 +84,10 @@ i2c4: i2c@021f8000 { #address-cells = <1>; #size-cells = <0>; - compatible = "fsl,imx1-i2c"; + compatible = "fsl,imx6q-i2c", "fsl,imx21-i2c"; reg = <0x021f8000 0x4000>; interrupts = <0 35 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clks 116>; status = "disabled"; }; };