From patchwork Thu Jun 12 14:17:51 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Russell King - ARM Linux X-Patchwork-Id: 4342341 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 470789F333 for ; Thu, 12 Jun 2014 14:20:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 53D7E2035C for ; Thu, 12 Jun 2014 14:20:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5906C20303 for ; Thu, 12 Jun 2014 14:20:25 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wv5pj-0006p5-JV; Thu, 12 Jun 2014 14:18:27 +0000 Received: from pandora.arm.linux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wv5pf-0006gA-9e for linux-arm-kernel@lists.infradead.org; Thu, 12 Jun 2014 14:18:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=arm.linux.org.uk; s=pandora; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=mFSwiHpeA2CO7ZVlw2+IEMBp4Aj8odE6Pdz6wJToz04=; b=I23zwCWPIbG8VAnmYGfVvNYFiBexLKQEE5iNDA+wt7KfiObssSHbwRdidJzGVKimGkAG1ddGYParYS+PKpzKtADtIWUKEmtZiVrFrM6+9TV7gLEDZuzTpA9RL9uvK/RWNyN80iDXLCoA4vZ5xHCSCC3D6K2BV0SuhXquo8slTR8=; Received: from n2100.arm.linux.org.uk ([2002:4e20:1eda:1:214:fdff:fe10:4f86]:36779) by pandora.arm.linux.org.uk with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1Wv5pC-0001pE-0x; Thu, 12 Jun 2014 15:17:54 +0100 Received: from linux by n2100.arm.linux.org.uk with local (Exim 4.76) (envelope-from ) id 1Wv5pA-0000Sc-C9; Thu, 12 Jun 2014 15:17:52 +0100 Date: Thu, 12 Jun 2014 15:17:51 +0100 From: Russell King - ARM Linux To: Arnd Bergmann Subject: Re: Kconfig fails: big select-based circular dependency Message-ID: <20140612141751.GH23430@n2100.arm.linux.org.uk> References: <20140607090944.GL23430@n2100.arm.linux.org.uk> <10376496.xoRI3F9EzH@wuerfel> <20140612130330.GG23430@n2100.arm.linux.org.uk> <6046244.oz0lY2JOaZ@wuerfel> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6046244.oz0lY2JOaZ@wuerfel> User-Agent: Mutt/1.5.19 (2009-01-05) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140612_071823_661514_6DA51AD6 X-CRM114-Status: GOOD ( 21.82 ) X-Spam-Score: -0.8 (/) Cc: linux-kernel@vger.kernel.org, Tomasz Figa , linux-arm-kernel@lists.infradead.org, Mark Brown X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Jun 12, 2014 at 03:37:18PM +0200, Arnd Bergmann wrote: > I didn't say we should not fix it, I just meant we don't need to spend > too much time on a perfect solution for code that is going away and that > is already not used anywhere. > > I've just replied to an older thread "Re: [PATCH 1/2] [RFC] ASoC: samsung: > move s3c24xx over to dmaengine" with a patch that would let us kill off > the code right away, or at least disable it in Kconfig. > > For some reason, I can't reproduce the failure you see in your build system, > I tried torvalds/master and next/master today and I have also done > allmodconfig and randconfig builds in the past few days on slightly > older versions. That's because you don't have this commit: Author: Philipp Zabel Date: Thu Mar 6 14:54:39 2014 +0100 imx-drm: imx-ldb: add drm_panel support This patch allows to optionally attach the lvds-channel to a panel supported by a drm_panel driver instead of supplying the modes via device tree. Signed-off-by: Philipp Zabel [Fixed build error due to missing select on DRM_PANEL --rmk] Signed-off-by: Russell King which introduces the final nail in the loop - and as imx-ldb really does require DRM_PANEL support, and DRM_PANEL is not a user selectable symbol, the above addition is an entirely reasonable thing to do. The above commit /was/ going to go in during this merge window (along with three others) had I not been soo hacked off with the crap change handling and the general dysfunctional ARM community that we seem to have in the kernel community now, and ended up walking totally away from kernel maintanence for much of the last cycle... we're only /just/ starting to find out all the problems that my MMC patch series caused... and there's /still/ outstanding issues with the L2C patch series which /still/ have not been resolved - both of which are now part of mainline so people will now be forced to deal with these issues. That's not the right way, but it seems to be the /only/ way to get things done in todays dysfunctional environment. diff --git a/drivers/staging/imx-drm/Kconfig b/drivers/staging/imx-drm/Kconfig index c6e8ba7b3e4e..92fb52cbd3a2 100644 --- a/drivers/staging/imx-drm/Kconfig +++ b/drivers/staging/imx-drm/Kconfig @@ -35,6 +35,7 @@ config DRM_IMX_TVE config DRM_IMX_LDB tristate "Support for LVDS displays" depends on DRM_IMX && MFD_SYSCON + select DRM_PANEL help Choose this to enable the internal LVDS Display Bridge (LDB) found on i.MX53 and i.MX6 processors.