From patchwork Thu Aug 21 21:11:00 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 4759941 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0A04E9F2E8 for ; Thu, 21 Aug 2014 21:13:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 43F9A2018B for ; Thu, 21 Aug 2014 21:13:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45F3C20172 for ; Thu, 21 Aug 2014 21:13:33 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XKZe8-0001hr-QE; Thu, 21 Aug 2014 21:11:48 +0000 Received: from devils.ext.ti.com ([198.47.26.153]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XKZe5-0001c1-Mb for linux-arm-kernel@lists.infradead.org; Thu, 21 Aug 2014 21:11:46 +0000 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id s7LLB6w1028407; Thu, 21 Aug 2014 16:11:06 -0500 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s7LLB5WM023507; Thu, 21 Aug 2014 16:11:06 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.3.174.1; Thu, 21 Aug 2014 16:11:05 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s7LLB5N2001601; Thu, 21 Aug 2014 16:11:05 -0500 Date: Thu, 21 Aug 2014 16:11:00 -0500 From: Felipe Balbi To: Russell King Subject: Build failure with v3.17-rc1 Message-ID: <20140821211100.GS11146@saruman.home> MIME-Version: 1.0 User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140821_141145_823741_9019F686 X-CRM114-Status: GOOD ( 11.60 ) X-Spam-Score: -5.7 (-----) Cc: Linux ARM Kernel Mailing List X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: balbi@ti.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Russell, When running my randconfig build tests, I noticed that I had a build failure at arch/arm/kernel/patch.c KCONFIG_SEED=0x26B77624 arch/arm/kernel/patch.c: In function ‘__patch_text’: arch/arm/kernel/patch.c:35:4: error: implicit declaration of function ‘__opcode_to_mem_thumb32’ [-Werror=implicit-function-declaration] insn = __opcode_to_mem_thumb32(insn); ^ cc1: some warnings being treated as errors make[1]: *** [arch/arm/kernel/patch.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [arch/arm/kernel] Error 2 make: *** Waiting for unfinished jobs.... Looking at the definition of __opcode_to_mem_thumb32 it's easy to see that it's not defined when ! CONFIG_CPU_ENDIAN_BE8 and that's exactly what I have in my generated defconfig (attached). Would below patch be the correct fix for this ? if it is, I can send it as a formal patch and/or add it to your patch tracking system. Otherwise, let me know what would be the best fix and I'll either fix or build-test a patch from you, whatever works best. cheers diff --git a/arch/arm/include/asm/opcodes.h b/arch/arm/include/asm/opcodes.h index e796c59..d74eb26 100644 --- a/arch/arm/include/asm/opcodes.h +++ b/arch/arm/include/asm/opcodes.h @@ -111,6 +111,7 @@ extern asmlinkage unsigned int arm_check_condition(u32 opcode, u32 psr); #define __opcode_to_mem_arm(x) ___opcode_identity32(x) #define __opcode_to_mem_thumb16(x) ___opcode_identity16(x) +#define __opcode_to_mem_thumb32(x) ___opcode_identity32(x) #define ___asm_opcode_to_mem_arm(x) ___asm_opcode_identity32(x) #define ___asm_opcode_to_mem_thumb16(x) ___asm_opcode_identity16(x) #ifndef CONFIG_CPU_ENDIAN_BE32