From patchwork Mon Oct 27 05:26:11 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Finn Thain X-Patchwork-Id: 5159191 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 498C09F30B for ; Mon, 27 Oct 2014 10:34:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 184FF2024D for ; Mon, 27 Oct 2014 10:34:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0EDB2026C for ; Mon, 27 Oct 2014 10:34:27 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Xihal-00041A-0a; Mon, 27 Oct 2014 10:32:03 +0000 Received: from kvm5.telegraphics.com.au ([98.124.60.144]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XihaT-0003mR-CC for linux-arm-kernel@lists.infradead.org; Mon, 27 Oct 2014 10:31:47 +0000 Received: by kvm5.telegraphics.com.au (Postfix, from userid 502) id 40E5227373; Mon, 27 Oct 2014 06:31:19 -0400 (EDT) Message-Id: <20141027052608.115425018@telegraphics.com.au> User-Agent: quilt/0.50-1 Date: Mon, 27 Oct 2014 16:26:11 +1100 From: Finn Thain To: "James E.J. Bottomley" Subject: [PATCH v2 04/36] ncr5380: Remove unused macros References: <20141027052607.105914311@telegraphics.com.au> Content-Disposition: inline; filename=ncr5380-remove-unused-macros X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141027_033145_693035_52BD3801 X-CRM114-Status: GOOD ( 13.25 ) X-Spam-Score: 0.5 (/) Cc: Michael Schmitz , Sam Creasey , linux-m68k@vger.kernel.org, Russell King , linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00, DATE_IN_PAST_03_06, RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Some macros are never evaluated (i.e. FOO, USLEEP, SCSI2 and USE_WRAPPER; and in some drivers, NCR5380_intr and NCR5380_proc_info). DRIVER_SETUP serves no purpose anymore. Remove these macro definitions. Signed-off-by: Finn Thain Reviewed-by: Hannes Reinecke --- drivers/scsi/NCR5380.c | 2 +- drivers/scsi/arm/oak.c | 1 - drivers/scsi/atari_scsi.h | 1 - drivers/scsi/g_NCR5380.c | 5 ----- drivers/scsi/g_NCR5380.h | 1 - drivers/scsi/mac_scsi.c | 3 --- drivers/scsi/pas16.c | 5 ----- drivers/scsi/sun3_scsi.c | 15 --------------- drivers/scsi/sun3_scsi.h | 1 - drivers/scsi/t128.c | 5 ----- 10 files changed, 1 insertion(+), 38 deletions(-) Index: linux/drivers/scsi/mac_scsi.c =================================================================== --- linux.orig/drivers/scsi/mac_scsi.c 2014-10-27 16:25:07.000000000 +1100 +++ linux/drivers/scsi/mac_scsi.c 2014-10-27 16:25:09.000000000 +1100 @@ -55,7 +55,6 @@ #include "NCR5380.h" #define RESET_BOOT -#define DRIVER_SETUP extern void via_scsi_clear(void); @@ -113,7 +112,6 @@ static __inline__ void macscsi_write(str */ static int __init mac_scsi_setup(char *str) { -#ifdef DRIVER_SETUP int ints[7]; (void)get_options( str, ARRAY_SIZE(ints), ints); @@ -166,7 +164,6 @@ static int __init mac_scsi_setup(char *s } #endif /* SUPPORT_TAGS */ -#endif /* DRIVER_SETUP */ return 1; } Index: linux/drivers/scsi/sun3_scsi.c =================================================================== --- linux.orig/drivers/scsi/sun3_scsi.c 2014-10-27 16:25:07.000000000 +1100 +++ linux/drivers/scsi/sun3_scsi.c 2014-10-27 16:25:09.000000000 +1100 @@ -43,10 +43,6 @@ * Options : * * PARITY - enable parity checking. Not supported. - * - * SCSI2 - enable support for SCSI-II tagged queueing. Untested. - * - * USLEEP - enable support for devices that don't disconnect. Untested. */ #define AUTOSENSE @@ -79,18 +75,7 @@ extern int sun3_map_test(unsigned long, char *); -#define USE_WRAPPER /*#define RESET_BOOT */ -#define DRIVER_SETUP - -/* - * BUG can be used to trigger a strange code-size related hang on 2.1 kernels - */ -#ifdef BUG -#undef RESET_BOOT -#undef DRIVER_SETUP -#endif - /* #define SUPPORT_TAGS */ #ifdef SUN3_SCSI_VME Index: linux/drivers/scsi/NCR5380.c =================================================================== --- linux.orig/drivers/scsi/NCR5380.c 2014-10-27 16:18:00.000000000 +1100 +++ linux/drivers/scsi/NCR5380.c 2014-10-27 16:25:09.000000000 +1100 @@ -649,7 +649,7 @@ NCR5380_print_options(struct Scsi_Host * " UNSAFE " #endif ); - printk(" USLEEP, USLEEP_POLL=%d USLEEP_SLEEP=%d", USLEEP_POLL, USLEEP_SLEEP); + printk(" USLEEP_POLL=%d USLEEP_SLEEP=%d", USLEEP_POLL, USLEEP_SLEEP); printk(" generic release=%d", NCR5380_PUBLIC_RELEASE); if (((struct NCR5380_hostdata *) instance->hostdata)->flags & FLAG_NCR53C400) { printk(" ncr53c400 release=%d", NCR53C400_PUBLIC_RELEASE); Index: linux/drivers/scsi/pas16.c =================================================================== --- linux.orig/drivers/scsi/pas16.c 2014-10-27 16:25:08.000000000 +1100 +++ linux/drivers/scsi/pas16.c 2014-10-27 16:25:09.000000000 +1100 @@ -1,6 +1,5 @@ #define AUTOSENSE #define PSEUDO_DMA -#define FOO #define UNSAFE /* Not unsafe for PAS16 -- use it */ #define PDEBUG 0 @@ -52,8 +51,6 @@ * increase compared to polled I/O. * * PARITY - enable parity checking. Not supported. - * - * SCSI2 - enable support for SCSI-II tagged queueing. Untested. * * UNSAFE - leave interrupts enabled during pseudo-DMA transfers. This * parameter comes from the NCR5380 code. It is NOT unsafe with @@ -63,8 +60,6 @@ * want to use UNSAFE you can try defining LIMIT_TRANSFERSIZE or * twiddle with the transfer size in the high level code. * - * USLEEP - enable support for devices that don't disconnect. Untested. - * * The card is detected and initialized in one of several ways : * 1. Autoprobe (default) - There are many different models of * the Pro Audio Spectrum/Studio 16, and I only have one of Index: linux/drivers/scsi/g_NCR5380.c =================================================================== --- linux.orig/drivers/scsi/g_NCR5380.c 2014-10-27 16:18:00.000000000 +1100 +++ linux/drivers/scsi/g_NCR5380.c 2014-10-27 16:25:09.000000000 +1100 @@ -44,10 +44,6 @@ * * PARITY - enable parity checking. Not supported. * - * SCSI2 - enable support for SCSI-II tagged queueing. Untested. - * - * USLEEP - enable support for devices that don't disconnect. Untested. - * * The card is detected and initialized in one of several ways : * 1. With command line overrides - NCR5380=port,irq may be * used on the LILO command line to override the defaults. @@ -79,7 +75,6 @@ */ /* settings for DTC3181E card with only Mustek scanner attached */ -#define USLEEP #define USLEEP_POLL 1 #define USLEEP_SLEEP 20 #define USLEEP_WAITLONG 500 Index: linux/drivers/scsi/arm/oak.c =================================================================== --- linux.orig/drivers/scsi/arm/oak.c 2014-10-27 16:18:00.000000000 +1100 +++ linux/drivers/scsi/arm/oak.c 2014-10-27 16:25:09.000000000 +1100 @@ -29,7 +29,6 @@ #define NCR5380_read(reg) readb(_base + ((reg) << 2)) #define NCR5380_write(reg, value) writeb(value, _base + ((reg) << 2)) -#define NCR5380_intr oakscsi_intr #define NCR5380_queue_command oakscsi_queue_command #define NCR5380_show_info oakscsi_show_info #define NCR5380_write_info oakscsi_write_info Index: linux/drivers/scsi/g_NCR5380.h =================================================================== --- linux.orig/drivers/scsi/g_NCR5380.h 2014-10-27 16:18:00.000000000 +1100 +++ linux/drivers/scsi/g_NCR5380.h 2014-10-27 16:25:09.000000000 +1100 @@ -118,7 +118,6 @@ static const char* generic_NCR5380_info( #define NCR5380_bus_reset generic_NCR5380_bus_reset #define NCR5380_pread generic_NCR5380_pread #define NCR5380_pwrite generic_NCR5380_pwrite -#define NCR5380_proc_info notyet_generic_proc_info #define BOARD_NCR5380 0 #define BOARD_NCR53C400 1 Index: linux/drivers/scsi/t128.c =================================================================== --- linux.orig/drivers/scsi/t128.c 2014-10-27 16:25:08.000000000 +1100 +++ linux/drivers/scsi/t128.c 2014-10-27 16:25:09.000000000 +1100 @@ -47,17 +47,12 @@ * increase compared to polled I/O. * * PARITY - enable parity checking. Not supported. - * - * SCSI2 - enable support for SCSI-II tagged queueing. Untested. - * * * UNSAFE - leave interrupts enabled during pseudo-DMA transfers. You * only really want to use this if you're having a problem with * dropped characters during high speed communications, and even * then, you're going to be better off twiddling with transfersize. * - * USLEEP - enable support for devices that don't disconnect. Untested. - * * The card is detected and initialized in one of several ways : * 1. Autoprobe (default) - since the board is memory mapped, * a BIOS signature is scanned for to locate the registers. Index: linux/drivers/scsi/sun3_scsi.h =================================================================== --- linux.orig/drivers/scsi/sun3_scsi.h 2014-10-27 16:25:07.000000000 +1100 +++ linux/drivers/scsi/sun3_scsi.h 2014-10-27 16:25:09.000000000 +1100 @@ -89,7 +89,6 @@ static int sun3scsi_release (struct Scsi #define NCR5380_read(reg) sun3scsi_read(reg) #define NCR5380_write(reg, value) sun3scsi_write(reg, value) -#define NCR5380_intr sun3scsi_intr #define NCR5380_queue_command sun3scsi_queue_command #define NCR5380_bus_reset sun3scsi_bus_reset #define NCR5380_abort sun3scsi_abort Index: linux/drivers/scsi/atari_scsi.h =================================================================== --- linux.orig/drivers/scsi/atari_scsi.h 2014-10-27 16:18:00.000000000 +1100 +++ linux/drivers/scsi/atari_scsi.h 2014-10-27 16:25:09.000000000 +1100 @@ -44,7 +44,6 @@ #define NCR5380_read(reg) atari_scsi_reg_read( reg ) #define NCR5380_write(reg, value) atari_scsi_reg_write( reg, value ) -#define NCR5380_intr atari_scsi_intr #define NCR5380_queue_command atari_scsi_queue_command #define NCR5380_abort atari_scsi_abort #define NCR5380_show_info atari_scsi_show_info