From patchwork Wed Nov 12 05:12:01 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Finn Thain X-Patchwork-Id: 5285441 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B5D7E9F440 for ; Wed, 12 Nov 2014 05:46:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6EA502010F for ; Wed, 12 Nov 2014 05:46:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E646820114 for ; Wed, 12 Nov 2014 05:46:16 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XoQiq-0003RZ-Io; Wed, 12 Nov 2014 05:44:04 +0000 Received: from kvm5.telegraphics.com.au ([98.124.60.144]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XoQiD-0002zN-M8 for linux-arm-kernel@lists.infradead.org; Wed, 12 Nov 2014 05:43:27 +0000 Received: by kvm5.telegraphics.com.au (Postfix, from userid 502) id 3D8DA2925F; Wed, 12 Nov 2014 00:42:37 -0500 (EST) Message-Id: <20141112051150.045932545@telegraphics.com.au> User-Agent: quilt/0.50-1 Date: Wed, 12 Nov 2014 16:12:01 +1100 From: Finn Thain To: "James E.J. Bottomley" Subject: [PATCH v3 15/37] ncr5380: Remove *_RELEASE macros References: <20141112051146.525489687@telegraphics.com.au> Content-Disposition: inline; filename=ncr5380-remove-RELEASE-macros X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141111_214325_928268_0B5FDA38 X-CRM114-Status: UNSURE ( 9.12 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.5 (/) Cc: Michael Schmitz , Sam Creasey , linux-m68k@vger.kernel.org, Russell King , linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The *_RELEASE macros don't tell me anything. In some cases the version in the macro contradicts the version in the comments. Anyway, the Linux kernel version is sufficient information. Remove these macros to improve readability. Signed-off-by: Finn Thain Reviewed-by: Hannes Reinecke Tested-by: Michael Schmitz --- drivers/scsi/NCR5380.c | 18 ------------------ drivers/scsi/NCR5380.h | 5 ----- drivers/scsi/arm/cumana_1.c | 2 -- drivers/scsi/arm/oak.c | 2 -- drivers/scsi/atari_NCR5380.c | 4 ---- drivers/scsi/dtc.c | 5 ----- drivers/scsi/dtc.h | 2 -- drivers/scsi/g_NCR5380.c | 2 -- drivers/scsi/g_NCR5380.h | 5 ----- drivers/scsi/mac_scsi.c | 2 -- drivers/scsi/mac_scsi.h | 4 ---- drivers/scsi/pas16.h | 2 -- drivers/scsi/sun3_NCR5380.c | 4 ---- drivers/scsi/sun3_scsi.c | 2 -- drivers/scsi/sun3_scsi.h | 4 ---- drivers/scsi/t128.c | 2 -- drivers/scsi/t128.h | 4 ---- 17 files changed, 69 deletions(-) Index: linux/drivers/scsi/NCR5380.c =================================================================== --- linux.orig/drivers/scsi/NCR5380.c 2014-11-12 16:11:10.000000000 +1100 +++ linux/drivers/scsi/NCR5380.c 2014-11-12 16:11:13.000000000 +1100 @@ -11,8 +11,6 @@ * drew@colorado.edu * +1 (303) 666-5836 * - * DISTRIBUTION RELEASE 6. - * * For more information, please consult * * NCR 5380 Family @@ -735,22 +733,6 @@ static int __maybe_unused NCR5380_show_i hostdata = (struct NCR5380_hostdata *) instance->hostdata; - SPRINTF("NCR5380 core release=%d. ", NCR5380_PUBLIC_RELEASE); - if (((struct NCR5380_hostdata *) instance->hostdata)->flags & FLAG_NCR53C400) - SPRINTF("ncr53c400 release=%d. ", NCR53C400_PUBLIC_RELEASE); -#ifdef DTC_PUBLIC_RELEASE - SPRINTF("DTC 3180/3280 release %d", DTC_PUBLIC_RELEASE); -#endif -#ifdef T128_PUBLIC_RELEASE - SPRINTF("T128 release %d", T128_PUBLIC_RELEASE); -#endif -#ifdef GENERIC_NCR5380_PUBLIC_RELEASE - SPRINTF("Generic5380 release %d", GENERIC_NCR5380_PUBLIC_RELEASE); -#endif -#ifdef PAS16_PUBLIC_RELEASE - SPRINTF("PAS16 release=%d", PAS16_PUBLIC_RELEASE); -#endif - #ifdef PSEUDO_DMA SPRINTF("Highwater I/O busy spin counts: write %d, read %d\n", hostdata->spin_max_w, hostdata->spin_max_r); Index: linux/drivers/scsi/atari_NCR5380.c =================================================================== --- linux.orig/drivers/scsi/atari_NCR5380.c 2014-11-12 16:11:06.000000000 +1100 +++ linux/drivers/scsi/atari_NCR5380.c 2014-11-12 16:11:13.000000000 +1100 @@ -11,8 +11,6 @@ * drew@colorado.edu * +1 (303) 666-5836 * - * DISTRIBUTION RELEASE 6. - * * For more information, please consult * * NCR 5380 Family @@ -741,7 +739,6 @@ static void NCR5380_print_status(struct hostdata = (struct NCR5380_hostdata *)instance->hostdata; - printk("\nNCR5380 core release=%d.\n", NCR5380_PUBLIC_RELEASE); local_irq_save(flags); printk("NCR5380: coroutine is%s running.\n", main_running ? "" : "n't"); @@ -785,7 +782,6 @@ static int __maybe_unused NCR5380_show_i hostdata = (struct NCR5380_hostdata *)instance->hostdata; - seq_printf(m, "NCR5380 core release=%d.\n", NCR5380_PUBLIC_RELEASE); local_irq_save(flags); seq_printf(m, "NCR5380: coroutine is%s running.\n", main_running ? "" : "n't"); Index: linux/drivers/scsi/sun3_NCR5380.c =================================================================== --- linux.orig/drivers/scsi/sun3_NCR5380.c 2014-11-12 16:11:06.000000000 +1100 +++ linux/drivers/scsi/sun3_NCR5380.c 2014-11-12 16:11:13.000000000 +1100 @@ -13,8 +13,6 @@ * drew@colorado.edu * +1 (303) 666-5836 * - * DISTRIBUTION RELEASE 6. - * * For more information, please consult * * NCR 5380 Family @@ -687,7 +685,6 @@ static void NCR5380_print_status(struct hostdata = (struct NCR5380_hostdata *)instance->hostdata; - printk("\nNCR5380 core release=%d.\n", NCR5380_PUBLIC_RELEASE); local_irq_save(flags); printk("NCR5380: coroutine is%s running.\n", main_running ? "" : "n't"); @@ -731,7 +728,6 @@ static int __maybe_unused NCR5380_show_i hostdata = (struct NCR5380_hostdata *)instance->hostdata; - seq_printf(m, "NCR5380 core release=%d.\n", NCR5380_PUBLIC_RELEASE); local_irq_save(flags); seq_printf(m, "NCR5380: coroutine is%s running.\n", main_running ? "" : "n't"); Index: linux/drivers/scsi/NCR5380.h =================================================================== --- linux.orig/drivers/scsi/NCR5380.h 2014-11-12 16:11:10.000000000 +1100 +++ linux/drivers/scsi/NCR5380.h 2014-11-12 16:11:13.000000000 +1100 @@ -7,8 +7,6 @@ * drew@colorado.edu * +1 (303) 666-5836 * - * DISTRIBUTION RELEASE 7 - * * For more information, please consult * * NCR 5380 Family @@ -27,9 +25,6 @@ #include #include -#define NCR5380_PUBLIC_RELEASE 7 -#define NCR53C400_PUBLIC_RELEASE 2 - #define NDEBUG_ARBITRATION 0x1 #define NDEBUG_AUTOSENSE 0x2 #define NDEBUG_DMA 0x4 Index: linux/drivers/scsi/arm/cumana_1.c =================================================================== --- linux.orig/drivers/scsi/arm/cumana_1.c 2014-11-12 16:11:06.000000000 +1100 +++ linux/drivers/scsi/arm/cumana_1.c 2014-11-12 16:11:13.000000000 +1100 @@ -20,8 +20,6 @@ #define PSEUDO_DMA -#define CUMANASCSI_PUBLIC_RELEASE 1 - #define priv(host) ((struct NCR5380_hostdata *)(host)->hostdata) #define NCR5380_local_declare() struct Scsi_Host *_instance #define NCR5380_setup(instance) _instance = instance Index: linux/drivers/scsi/arm/oak.c =================================================================== --- linux.orig/drivers/scsi/arm/oak.c 2014-11-12 16:11:10.000000000 +1100 +++ linux/drivers/scsi/arm/oak.c 2014-11-12 16:11:13.000000000 +1100 @@ -18,8 +18,6 @@ #include /*#define PSEUDO_DMA*/ - -#define OAKSCSI_PUBLIC_RELEASE 1 #define DONT_USE_INTR #define priv(host) ((struct NCR5380_hostdata *)(host)->hostdata) Index: linux/drivers/scsi/dtc.c =================================================================== --- linux.orig/drivers/scsi/dtc.c 2014-11-12 16:11:10.000000000 +1100 +++ linux/drivers/scsi/dtc.c 2014-11-12 16:11:13.000000000 +1100 @@ -17,8 +17,6 @@ * (Unix and Linux consulting and custom programming) * drew@colorado.edu * +1 (303) 440-4894 - * - * DISTRIBUTION RELEASE 1. */ /* @@ -66,9 +64,6 @@ #define AUTOPROBE_IRQ #include "NCR5380.h" - -#define DTC_PUBLIC_RELEASE 2 - /* * The DTC3180 & 3280 boards are memory mapped. * Index: linux/drivers/scsi/g_NCR5380.h =================================================================== --- linux.orig/drivers/scsi/g_NCR5380.h 2014-11-12 16:11:06.000000000 +1100 +++ linux/drivers/scsi/g_NCR5380.h 2014-11-12 16:11:13.000000000 +1100 @@ -9,16 +9,11 @@ * * NCR53C400 extensions (c) 1994,1995,1996, Kevin Lentin * K.Lentin@cs.monash.edu.au - * - * ALPHA RELEASE 1. */ #ifndef GENERIC_NCR5380_H #define GENERIC_NCR5380_H - -#define GENERIC_NCR5380_PUBLIC_RELEASE 1 - #ifdef NCR53C400 #define BIOSPARAM #define NCR5380_BIOSPARAM generic_NCR5380_biosparam Index: linux/drivers/scsi/mac_scsi.h =================================================================== --- linux.orig/drivers/scsi/mac_scsi.h 2014-11-12 16:11:11.000000000 +1100 +++ linux/drivers/scsi/mac_scsi.h 2014-11-12 16:11:13.000000000 +1100 @@ -6,15 +6,11 @@ * (Unix and Linux consulting and custom programming) * drew@colorado.edu * +1 (303) 440-4894 - * - * ALPHA RELEASE 1. */ #ifndef MAC_NCR5380_H #define MAC_NCR5380_H -#define MACSCSI_PUBLIC_RELEASE 2 - #ifndef ASM #include Index: linux/drivers/scsi/pas16.h =================================================================== --- linux.orig/drivers/scsi/pas16.h 2014-11-12 16:11:06.000000000 +1100 +++ linux/drivers/scsi/pas16.h 2014-11-12 16:11:13.000000000 +1100 @@ -24,8 +24,6 @@ #ifndef PAS16_H #define PAS16_H -#define PAS16_PUBLIC_RELEASE 3 - #define PDEBUG_INIT 0x1 #define PDEBUG_TRANSFER 0x2 Index: linux/drivers/scsi/sun3_scsi.h =================================================================== --- linux.orig/drivers/scsi/sun3_scsi.h 2014-11-12 16:11:11.000000000 +1100 +++ linux/drivers/scsi/sun3_scsi.h 2014-11-12 16:11:13.000000000 +1100 @@ -13,15 +13,11 @@ * (Unix and Linux consulting and custom programming) * drew@colorado.edu * +1 (303) 440-4894 - * - * ALPHA RELEASE 1. */ #ifndef SUN3_SCSI_H #define SUN3_SCSI_H -#define SUN3SCSI_PUBLIC_RELEASE 1 - /* * Int: level 2 autovector * IO: type 1, base 0x00140000, 5 bits phys space: A<4..0> Index: linux/drivers/scsi/t128.h =================================================================== --- linux.orig/drivers/scsi/t128.h 2014-11-12 16:11:06.000000000 +1100 +++ linux/drivers/scsi/t128.h 2014-11-12 16:11:13.000000000 +1100 @@ -8,8 +8,6 @@ * drew@colorado.edu * +1 (303) 440-4894 * - * DISTRIBUTION RELEASE 3. - * * For more information, please consult * * Trantor Systems, Ltd. @@ -25,8 +23,6 @@ #ifndef T128_H #define T128_H -#define T128_PUBLIC_RELEASE 3 - #define TDEBUG 0 #define TDEBUG_INIT 0x1 #define TDEBUG_TRANSFER 0x2 Index: linux/drivers/scsi/dtc.h =================================================================== --- linux.orig/drivers/scsi/dtc.h 2014-11-12 16:11:06.000000000 +1100 +++ linux/drivers/scsi/dtc.h 2014-11-12 16:11:13.000000000 +1100 @@ -5,8 +5,6 @@ * (Unix and Linux consulting and custom programming) * drew@colorado.edu * +1 (303) 440-4894 - * - * DISTRIBUTION RELEASE 2. */ #ifndef DTC3280_H Index: linux/drivers/scsi/g_NCR5380.c =================================================================== --- linux.orig/drivers/scsi/g_NCR5380.c 2014-11-12 16:11:06.000000000 +1100 +++ linux/drivers/scsi/g_NCR5380.c 2014-11-12 16:11:13.000000000 +1100 @@ -18,8 +18,6 @@ * * Added ISAPNP support for DTC436 adapters, * Thomas Sailer, sailer@ife.ee.ethz.ch - * - * ALPHA RELEASE 1. */ /* Index: linux/drivers/scsi/mac_scsi.c =================================================================== --- linux.orig/drivers/scsi/mac_scsi.c 2014-11-12 16:11:11.000000000 +1100 +++ linux/drivers/scsi/mac_scsi.c 2014-11-12 16:11:13.000000000 +1100 @@ -9,8 +9,6 @@ * Generic Generic NCR5380 driver * * Copyright 1995, Russell King - * - * ALPHA RELEASE 1. */ #include Index: linux/drivers/scsi/sun3_scsi.c =================================================================== --- linux.orig/drivers/scsi/sun3_scsi.c 2014-11-12 16:11:11.000000000 +1100 +++ linux/drivers/scsi/sun3_scsi.c 2014-11-12 16:11:13.000000000 +1100 @@ -20,8 +20,6 @@ * Generic Generic NCR5380 driver * * Copyright 1995, Russell King - * - * ALPHA RELEASE 1. */ #include Index: linux/drivers/scsi/t128.c =================================================================== --- linux.orig/drivers/scsi/t128.c 2014-11-12 16:11:06.000000000 +1100 +++ linux/drivers/scsi/t128.c 2014-11-12 16:11:13.000000000 +1100 @@ -11,8 +11,6 @@ * drew@colorado.edu * +1 (303) 440-4894 * - * DISTRIBUTION RELEASE 3. - * * For more information, please consult * * Trantor Systems, Ltd.