From patchwork Fri Jan 23 22:36:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Pali_Roh=C3=A1r?= X-Patchwork-Id: 5698091 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 314F29F2ED for ; Fri, 23 Jan 2015 22:39:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 64130202FE for ; Fri, 23 Jan 2015 22:39:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A44E200B4 for ; Fri, 23 Jan 2015 22:39:39 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YEmqy-0003vi-MT; Fri, 23 Jan 2015 22:37:24 +0000 Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YEmqa-0003PS-O6 for linux-arm-kernel@lists.infradead.org; Fri, 23 Jan 2015 22:37:01 +0000 Received: by mail-wi0-f177.google.com with SMTP id r20so63516wiv.4 for ; Fri, 23 Jan 2015 14:36:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; bh=ONrUOnpBSnUECkIO9MWfT1c5H6irlQBkQR6lMjQ15ec=; b=wDTvktUk51L5SRaOmjW9LliZEl9BBJToAlzQthitXdJ5CGGzpX8A257fgIV6U5VuOR KTVbx1C4MLM4PNaSAtqpGatc7kVxqxshSl6GEf9QXBThChx3JJIR43aM0TtrEGsG9SCc K4+0PM39kMepT6hR1A45ZWvH5HRGJimpmfK0uSG+Mb1+7AzqeUHh1MjQjn2zBfGdvBhj c/VKLgTO+LF7CLEvzx8ASB2kJ1GVxDkaZk9gj6uUjxPIyuGYzUTfA6KfQ+F6ZxB16Zng 0/1lfD1smXN+q+vn6mMKVRy+BzFL4aYL844eWWSK99yQC09zpJZva8a/obZB1kXUMvR/ HN/w== X-Received: by 10.194.109.9 with SMTP id ho9mr18796398wjb.29.1422052598218; Fri, 23 Jan 2015 14:36:38 -0800 (PST) Received: from pali-latitude.localnet ([2001:718:1e03:a01::1ca]) by mx.google.com with ESMTPSA id ei5sm3557904wid.2.2015.01.23.14.36.36 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 23 Jan 2015 14:36:37 -0800 (PST) From: Pali =?utf-8?q?Roh=C3=A1r?= To: "linux-omap" Subject: Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken Date: Fri, 23 Jan 2015 23:36:36 +0100 User-Agent: KMail/1.13.7 (Linux/3.13.0-44-generic; KDE/4.14.2; x86_64; ; ) References: <201501232239.55801@pali> In-Reply-To: <201501232239.55801@pali> MIME-Version: 1.0 Message-Id: <201501232336.36187@pali> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150123_143700_994278_FFEE9037 X-CRM114-Status: GOOD ( 14.38 ) X-Spam-Score: -0.8 (/) Cc: Ivaylo Dimitrov , Russell King , Aaro Koskinen , Tony Lindgren , Sebastian Reichel , Linux Kernel Mailing List , Pavel Machek , Laura Abbott , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Friday 23 January 2015 22:39:55 Pali Rohár wrote: > Hello, > > when I boot zImage with appended DT n900 in qemu > fdt_open_into() function called from file > arch/arm/boot/compressed/atags_to_fdt.c (in function > atags_to_fdt) always returns -FDT_ERR_NOSPACE. > > It means that all ATAGS (including cmdline arguments) passed > by bootloader are ignored. > > On real n900 device I see that booted DT version also ignore > cmdline arguments from bootloader. I cannot debug decompress > code on real device, but I think it is same problem as in > qemu. Looks like this quick patch is fixing above problem: diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S index 68be901..4a7d75b 100644 --- a/arch/arm/boot/compressed/head.S +++ b/arch/arm/boot/compressed/head.S @@ -268,7 +268,7 @@ restart: adr r0, LC0 * area. No GOT fixup has occurred yet, but none of the * code we're about to call uses any global variable. */ - add sp, sp, #0x10000 + add sp, sp, #0x20000 stmfd sp!, {r0-r3, ip, lr} mov r0, r8 mov r1, r6 @@ -289,7 +289,7 @@ restart: adr r0, LC0 bleq atags_to_fdt ldmfd sp!, {r0-r3, ip, lr} - sub sp, sp, #0x10000 + sub sp, sp, #0x20000 #endif mov r8, r6 @ use the appended device tree