From patchwork Sat Jan 24 12:00:00 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Pali_Roh=C3=A1r?= X-Patchwork-Id: 5699121 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2D635C058E for ; Sat, 24 Jan 2015 12:03:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3665720304 for ; Sat, 24 Jan 2015 12:03:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54A91200F0 for ; Sat, 24 Jan 2015 12:03:37 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YEzPJ-0006x8-2V; Sat, 24 Jan 2015 12:01:41 +0000 Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YEzO4-0005Jo-WB for linux-arm-kernel@lists.infradead.org; Sat, 24 Jan 2015 12:00:26 +0000 Received: by mail-wi0-f175.google.com with SMTP id fb4so1940307wid.2 for ; Sat, 24 Jan 2015 04:00:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; bh=f3UPmhL7ej4AqOMShb7+mWBAljCNG7ik9ueuFjsDOk0=; b=EE6eIyYLzpgGUJLWxtLRffJj6jeSl1AeZYsBYSfkzsEyZ1FiJRg1DuzRkjS9Nlv72Q SkPGudq9+uvdEgr+zp3Fo5hhD6DjKOkvbGYXmix66AHd9FhqMAKXGpnt5bkXM/lN9YPj ZkKnLmBx1jLOVRpPPvnBPBGW6aBdGRgAg+TDxGasJCwHLxZbYRFt7SKgRkSWGTlTpTku 1YYqQhJojl4SUTViA/66E986ti7hU6QKrUixXMn/DzPvpWhsBFHVmln8VTk8THD9ZCJq YA5SOCT0JGEtFj2D6zvrM7Nng7eDEPzo3g8jjrobMJTcJ1pOrEStGexVaqhMIO3ESl7e iuaQ== X-Received: by 10.180.198.209 with SMTP id je17mr12950427wic.17.1422100802723; Sat, 24 Jan 2015 04:00:02 -0800 (PST) Received: from pali-latitude.localnet ([2001:718:1e03:a01::1ca]) by mx.google.com with ESMTPSA id a1sm5969365wjx.28.2015.01.24.04.00.01 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 24 Jan 2015 04:00:01 -0800 (PST) From: Pali =?utf-8?q?Roh=C3=A1r?= To: Sebastian Reichel , Tony Lindgren Subject: Re: [PATCH 0/4] Drop legacy support for omap3517 Date: Sat, 24 Jan 2015 13:00:00 +0100 User-Agent: KMail/1.13.7 (Linux/3.13.0-44-generic; KDE/4.14.2; x86_64; ; ) References: <1421171865-5209-1-git-send-email-tony@atomide.com> <20150113204219.GJ2419@atomide.com> <20150115142536.GC512@earth.universe> In-Reply-To: <20150115142536.GC512@earth.universe> MIME-Version: 1.0 Message-Id: <201501241300.00723@pali> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150124_040025_282010_BDF53537 X-CRM114-Status: GOOD ( 28.01 ) X-Spam-Score: -0.8 (/) Cc: Ivaylo Dimitrov , Arnd Bergmann , Aaro Koskinen , Pavel Machek , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thursday 15 January 2015 15:25:36 Sebastian Reichel wrote: > On Tue, Jan 13, 2015 at 12:42:20PM -0800, Tony Lindgren wrote: > > * Arnd Bergmann [150113 12:27]: > > > On Tuesday 13 January 2015 09:57:41 Tony Lindgren wrote: > > > > It seems we can now drop omap3517 legacy booting support > > > > to get a bit closer to making all of omap3 boot in > > > > device tree only mode. > > > > > > > > All these boards have at least minimal support for > > > > booting with device tree, and pretty much anything > > > > supported with the legacy board files can be configured > > > > also for device tree based booting if not done already. > > > > > > Ah, very nice. > > > > > > Just out of curiosity, what are the remaining showstoppers > > > for the 3430 and 3530 based boards? > > > > Not much really. We're now printing a warning to get a > > people to upgrade their systems. So with some boards we > > need to wait a while. > > > > Then here are the remaining items that I'm aware of: > > > > - A regression at least on some n900 with appended DTB not > > booting > > > > properly any longer reported by Pali > > > > - A regression where the legacy ATAGs don't seem to get > > properly > > > > translated by the uncompress code for atag_rev at least > > reported by Pali > > > > - A few missing .dts files for devkit8000, omap3logic, > > omap3stalker, > > > > omap3pandora and omap3touchbook > > > > Pali and Sebastian probably know best of any other remaining > > issues to drop n900 legacy booting. > > Apart from the bugs there is only one feature-wise regression > when the system is booted via DT, which is the accelerometer. > I will (re)send patches for that in the next days. > > -- Sebastian Another regression for DT setup (which does not occur for board code): omap_hsmmc driver does not export slot_name sysfs entry because it not supported by DT yet. Entry slot_name is used by userspace application to determinate if mmc block device is internal eMMC memory or external uSD card. So support for this property also in DT is needed. Here is simple patch which fix this problem: With this patch identification works fine: / # cat /sys/block/mmcblk0/device/../slot_name external / # cat /sys/block/mmcblk1/device/../slot_name internal Without patch omap_hsmmc driver does not create slot_name. Acked-by: Pavel Machek diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts index 8571027..31ca609 100644 --- a/arch/arm/boot/dts/omap3-n900.dts +++ b/arch/arm/boot/dts/omap3-n900.dts @@ -665,6 +665,7 @@ }; &mmc1 { + slot-name = "external"; pinctrl-names = "default"; pinctrl-0 = <&mmc1_pins>; vmmc-supply = <&vmmc1>; @@ -674,6 +675,7 @@ /* most boards use vaux3, only some old versions use vmmc2 instead */ &mmc2 { + slot-name = "internal"; pinctrl-names = "default"; pinctrl-0 = <&mmc2_pins>; vmmc-supply = <&vaux3>; diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 7c71dcd..cd189eb 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -2021,6 +2021,8 @@ static struct omap_hsmmc_platform_data *of_get_hsmmc_pdata(struct device *dev) if (of_find_property(np, "enable-sdio-wakeup", NULL)) pdata->pm_caps |= MMC_PM_WAKE_SDIO_IRQ; + of_property_read_string(np, "slot-name", &pdata->name); + return pdata; } #else