| Message ID | 20150215173216.GA8660@linutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Sebastian, * Sebastian Andrzej Siewior <bigeasy@linutronix.de> [150215 09:35]: > This reverts commit 0aa525d11859c1a4d5b78fdc704148e2ae03ae13. > > The conditional RX-FIFO read seems to cause spurious interrupts and we > see just: > |serial8250: too much work for irq29 > > The previous behaviour was "default" for decades and Marvell's 88f6282 SoC > might not be the only that relies on it. Therefore the Omap fix is > reverted for now. > > Fixes: 0aa525d11859 ("tty: serial: 8250_core: read only RX if there is > something in the FIFO") > Reported-By: Nicolas Schichan <nschichan@freebox.fr> > Debuged-By: Peter Hurley <peter@hurleysoftware.com> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > --- > * Russell King - ARM Linux | 2015-02-13 23:15:19 [+0000]: > > >On Fri, Feb 13, 2015 at 07:51:16PM +0100, Sebastian Andrzej Siewior wrote: > >> Something like this maybe? > > > >My personal feeling is that as 0aa525d11859 was wrong, it should be > >reverted and this should be another attempt to fix the problem. In > >other words, there should be two patches, one a revert of the previously > >known bad commit and this one having another go at it. > > > >I feel that would be a better approach, since then we don't end up > >with this change building on a previously know buggy change. It > >would also make the changes to this solution from the previous, > >known-to-work-for-decades code more obvious. > > Okay. So here is the revert. After the revert looks like now we get the following on omaps with 8250.. Do you have a fix available somewhere on top of your revert? Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa06a000 ... [<c04217e8>] (mem_serial_in) from [<c0425480>] (serial8250_do_startup+0xe4/0x694) [<c0425480>] (serial8250_do_startup) from [<c0427e48>] (omap_8250_startup+0x70/0x144) [<c0427e48>] (omap_8250_startup) from [<c0425a54>] (serial8250_startup+0x24/0x30) [<c0425a54>] (serial8250_startup) from [<c04208e4>] (uart_startup.part.14+0x8c/0x1a0) [<c04208e4>] (uart_startup.part.14) from [<c0420fec>] (uart_open+0xd8/0x134) [<c0420fec>] (uart_open) from [<c0403e50>] (tty_open+0xdc/0x5e0) [<c0403e50>] (tty_open) from [<c018f008>] (chrdev_open+0xac/0x188) ... Regards, Tony
diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c index e3b9570a1eff..deae122c9c4b 100644 --- a/drivers/tty/serial/8250/8250_core.c +++ b/drivers/tty/serial/8250/8250_core.c @@ -2138,8 +2138,8 @@ int serial8250_do_startup(struct uart_port *port) /* * Clear the interrupt registers. */ - if (serial_port_in(port, UART_LSR) & UART_LSR_DR) - serial_port_in(port, UART_RX); + serial_port_in(port, UART_LSR); + serial_port_in(port, UART_RX); serial_port_in(port, UART_IIR); serial_port_in(port, UART_MSR); @@ -2300,8 +2300,8 @@ int serial8250_do_startup(struct uart_port *port) * saved flags to avoid getting false values from polling * routines or the previous session. */ - if (serial_port_in(port, UART_LSR) & UART_LSR_DR) - serial_port_in(port, UART_RX); + serial_port_in(port, UART_LSR); + serial_port_in(port, UART_RX); serial_port_in(port, UART_IIR); serial_port_in(port, UART_MSR); up->lsr_saved_flags = 0; @@ -2394,8 +2394,7 @@ void serial8250_do_shutdown(struct uart_port *port) * Read data port to reset things, and then unlink from * the IRQ chain. */ - if (serial_port_in(port, UART_LSR) & UART_LSR_DR) - serial_port_in(port, UART_RX); + serial_port_in(port, UART_RX); serial8250_rpm_put(up); del_timer_sync(&up->timer);
This reverts commit 0aa525d11859c1a4d5b78fdc704148e2ae03ae13. The conditional RX-FIFO read seems to cause spurious interrupts and we see just: |serial8250: too much work for irq29 The previous behaviour was "default" for decades and Marvell's 88f6282 SoC might not be the only that relies on it. Therefore the Omap fix is reverted for now. Fixes: 0aa525d11859 ("tty: serial: 8250_core: read only RX if there is something in the FIFO") Reported-By: Nicolas Schichan <nschichan@freebox.fr> Debuged-By: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- * Russell King - ARM Linux | 2015-02-13 23:15:19 [+0000]: >On Fri, Feb 13, 2015 at 07:51:16PM +0100, Sebastian Andrzej Siewior wrote: >> Something like this maybe? > >My personal feeling is that as 0aa525d11859 was wrong, it should be >reverted and this should be another attempt to fix the problem. In >other words, there should be two patches, one a revert of the previously >known bad commit and this one having another go at it. > >I feel that would be a better approach, since then we don't end up >with this change building on a previously know buggy change. It >would also make the changes to this solution from the previous, >known-to-work-for-decades code more obvious. Okay. So here is the revert. drivers/tty/serial/8250/8250_core.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)