From patchwork Thu Apr 9 12:31:55 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 6187861 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CB9EF9F1C4 for ; Thu, 9 Apr 2015 12:36:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BC2F2203AA for ; Thu, 9 Apr 2015 12:36:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D45B12037C for ; Thu, 9 Apr 2015 12:36:23 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YgBd7-0003y3-B6; Thu, 09 Apr 2015 12:32:21 +0000 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YgBd3-0003sG-Rv for linux-arm-kernel@lists.infradead.org; Thu, 09 Apr 2015 12:32:18 +0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 687B081F2C; Thu, 9 Apr 2015 14:31:56 +0200 (CEST) Date: Thu, 9 Apr 2015 14:31:55 +0200 From: Pavel Machek To: Sebastian Reichel Subject: [PATCHv7] media: i2c/adp1653: fix includes Message-ID: <20150409123155.GB9563@amd> References: <20150403202624.GA4308@amd> <20150403213655.GO20756@valkosipuli.retiisi.org.uk> <20150404074337.GA31064@amd> <20150404102435.GR20756@valkosipuli.retiisi.org.uk> <20150404171116.GA15025@Nokia-N900> <20150404200307.GS20756@valkosipuli.retiisi.org.uk> <20150409074238.GA22603@amd> <20150409091017.GA4526@earth> <20150409112943.GA31173@amd> <20150409121913.GB18713@earth> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150409121913.GB18713@earth> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150409_053218_133864_4F19AF2F X-CRM114-Status: GOOD ( 17.75 ) X-Spam-Score: -2.3 (--) Cc: Andrew Morton , devicetree@vger.kernel.org, ivo.g.dimitrov.75@gmail.com, khilman@kernel.org, tony@atomide.com, mchehab@osg.samsung.com, aaro.koskinen@iki.fi, kernel list , hverkuil@xs4all.nl, galak@codeaurora.org, Sakari Ailus , bcousson@baylibre.com, pali.rohar@gmail.com, linux-omap@vger.kernel.org, patrikbachan@gmail.com, linux-arm-kernel , m.chehab@samsung.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fix includes according to Sebastian. Signed-off-by: Pavel Machek --- On Thu 2015-04-09 14:19:14, Sebastian Reichel wrote: > On Thu, Apr 09, 2015 at 01:29:43PM +0200, Pavel Machek wrote: > > On Thu 2015-04-09 11:10:17, Sebastian Reichel wrote: > > > On Thu, Apr 09, 2015 at 09:42:38AM +0200, Pavel Machek wrote: > > > > [...] > > > > +#include > > > > +#include > > > > [...] > > > > > > This should probably be > > > > > > #include > > > #include > > > > And I thought people would only bikesched paint on the > > Documentation. Sakari, feel free to change that, but > > > a) I don't see why Sebastian's version is better > > You neither use nor . > > Well "include/linux/gpio.h" describes the old gpio API. The new > gpiod gpiod API is described in "include/linux/gpio/consumer.h" and > you use it, so the include should be included ;) > > You don't use anything from "include/linux/of_gpio.h", but it > includes "include/linux/of.h", which you are using. So you should > include instead ;) diff --git a/drivers/media/i2c/adp1653.c b/drivers/media/i2c/adp1653.c index d703636..7107ac2 100644 --- a/drivers/media/i2c/adp1653.c +++ b/drivers/media/i2c/adp1653.c @@ -35,8 +35,8 @@ #include #include #include -#include -#include +#include +#include #include #include