From patchwork Wed May 20 22:32:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 6450861 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 7091A9F1CC for ; Wed, 20 May 2015 22:36:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9173E202F2 for ; Wed, 20 May 2015 22:36:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D16A202F0 for ; Wed, 20 May 2015 22:36:17 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YvCYJ-0002e7-Hp; Wed, 20 May 2015 22:33:27 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YvCYD-0002Vj-Al for linux-arm-kernel@lists.infradead.org; Wed, 20 May 2015 22:33:21 +0000 Received: from smtp.codeaurora.org (localhost [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 71BCC14121D; Wed, 20 May 2015 22:33:00 +0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 486) id 6482A141435; Wed, 20 May 2015 22:33:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from localhost (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: sboyd@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id F0B3B14121D; Wed, 20 May 2015 22:32:59 +0000 (UTC) Date: Wed, 20 May 2015 15:32:59 -0700 From: Stephen Boyd To: Barry Song <21cnbao@gmail.com> Subject: Re: [PATCH 2/2 v4] ARM: dts: atlas7: add fixed frequency clocks in car node Message-ID: <20150520223259.GV31753@codeaurora.org> References: <1432111834-21178-1-git-send-email-21cnbao@gmail.com> <1432111834-21178-2-git-send-email-21cnbao@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1432111834-21178-2-git-send-email-21cnbao@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Scanned: ClamAV using ClamSMTP X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150520_153321_447214_48B87794 X-CRM114-Status: GOOD ( 15.90 ) X-Spam-Score: -0.0 (/) Cc: Guo Zeng , mturquette@linaro.org, workgroup.linux@csr.com, linux-arm-kernel@lists.infradead.org, Barry Song X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 05/20, Barry Song wrote: > From: Guo Zeng > > This patch adds the fixed clocks of external crystal oscillators. > > Signed-off-by: Guo Zeng > Signed-off-by: Barry Song > --- > -v4: move the clocks to be global; > > arch/arm/boot/dts/atlas7.dtsi | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm/boot/dts/atlas7.dtsi b/arch/arm/boot/dts/atlas7.dtsi > index a753178..1760dac 100644 > --- a/arch/arm/boot/dts/atlas7.dtsi > +++ b/arch/arm/boot/dts/atlas7.dtsi > @@ -38,6 +38,24 @@ > }; > }; > > + clocks { > + #address-cells = <1>; > + #size-cells = <1>; This isn't necessary right? I dropped it and applied it. ----8<----- diff --git a/arch/arm/boot/dts/atlas7.dtsi b/arch/arm/boot/dts/atlas7.dtsi index 1760dac6a2b0..5dfd3a44bf82 100644 --- a/arch/arm/boot/dts/atlas7.dtsi +++ b/arch/arm/boot/dts/atlas7.dtsi @@ -39,9 +39,6 @@ }; clocks { - #address-cells = <1>; - #size-cells = <1>; - xinw { compatible = "fixed-clock"; #clock-cells = <0>;