From patchwork Thu Jun 18 20:00:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 6640351 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 3432A9F358 for ; Thu, 18 Jun 2015 20:03:23 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 48F4E205B1 for ; Thu, 18 Jun 2015 20:03:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68C6020595 for ; Thu, 18 Jun 2015 20:03:21 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z5g05-0000ZT-Bx; Thu, 18 Jun 2015 20:01:25 +0000 Received: from mail-ig0-x236.google.com ([2607:f8b0:4001:c05::236]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z5g02-0000Ov-E3 for linux-arm-kernel@lists.infradead.org; Thu, 18 Jun 2015 20:01:23 +0000 Received: by igbzc4 with SMTP id zc4so3386707igb.0 for ; Thu, 18 Jun 2015 13:00:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=3ThicbuYACr2ThhbhHpuyeXZruMv5b1AueZelSW01OA=; b=DttjDRsGD8yf+EVa6gQIl5YKwahGJAGJrRlIyFDVkbiy1TzOUeyVYs/oPxkAiYmkCg uv+iOCUBlY2OTcPrVs4J+EoLJd0sgwInd78H4BX9BgN8Z+FI/CYr+GAVwgKm/Fa6KGXU ioPFiaB2vK7qxCYm8HF0uV+jSBTSdnOL2OdmATHicgXdYvwoRkOwVX4ta1leJaAa6jPR ZzLLIs32UAFr3VpbNiA7wTFJaUy26IbQoPopvtoeSwCXWNiZ2Wc/kTKyx1QYjjJxS3d3 bIyhDJrs2wiCFIZnbWbHQXtX+g2q+VE3qwoeQNeraEwURT89gWnEIczuJJsGOFAcCP3G yUqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=3ThicbuYACr2ThhbhHpuyeXZruMv5b1AueZelSW01OA=; b=h4mVBRwT55zmId5HTIqkq3BDljjAX83aQi7+zphmjPMbcsKnXM458q7C/K7Z5MzghL 2lk3y+Lz2wcLi1C5D9g/vjh3+8X1vKYwolf39ZiAmXX2E9sCgzu/R/NpfVkNSBHYtmuD FwXqDbUkP8hSSrkLMugnTq6N+uWQyBI4MRkjpidmLCbsAuQjybe1MjWYLdyPPvWtz1XH zBGOUGpevzD0B3Iq/9FPxSTH+aRqEkRAha/0hTxrEDqlW+4ZnwimLxQsqzB1UIpyjCXO 7iRM8hI20Sv0BDXcRV2CbgSiDHCBJipJG4izI3ZD/fPtMgLHGPAPS+U6/m2JXKs1HrcB vIew== X-Gm-Message-State: ALoCoQlg7AhEdInLVe8Kqs0EHVFJI9cRymZS8dkJCvci/ImNbsxGU2HsfbU6GXDOVpzUe8Diroxg X-Received: by 10.107.10.151 with SMTP id 23mr16780322iok.89.1434657657816; Thu, 18 Jun 2015 13:00:57 -0700 (PDT) Received: from google.com ([69.71.1.1]) by mx.google.com with ESMTPSA id f82sm5584606ioj.37.2015.06.18.13.00.54 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 18 Jun 2015 13:00:55 -0700 (PDT) Date: Thu, 18 Jun 2015 15:00:53 -0500 From: Bjorn Helgaas To: Duc Dang Subject: Re: [PATCH 1/1] PCI: xgene: Allow config access to Root Port even when link is down Message-ID: <20150618200053.GG7710@google.com> References: <1434653139-14461-1-git-send-email-dhdang@apm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1434653139-14461-1-git-send-email-dhdang@apm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150618_130122_544261_8D3199DF X-CRM114-Status: GOOD ( 16.21 ) X-Spam-Score: -1.1 (-) Cc: linux-pci@vger.kernel.org, patches@apm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tanmay Inamdar X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Jun 18, 2015 at 11:45:39AM -0700, Duc Dang wrote: > Even if a Root Port's link is down, we should still be able to access the > Port's configuration space. > > Suggested-by: Bjorn Helgaas > Signed-off-by: Duc Dang > Signed-off-by: Tanmay Inamdar > --- > drivers/pci/host/pci-xgene.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c > index 7e3cf28..2e66c87 100644 > --- a/drivers/pci/host/pci-xgene.c > +++ b/drivers/pci/host/pci-xgene.c > @@ -139,7 +139,7 @@ static void __iomem *xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn, > { > struct xgene_pcie_port *port = bus->sysdata; > > - if ((pci_is_root_bus(bus) && devfn != 0) || !port->link_up || > + if ((pci_is_root_bus(bus) && devfn != 0) || > xgene_pcie_hide_rc_bars(bus, offset)) > return NULL; > Applied with changelog as follows to pci/host-xgene for v4.2, thanks! commit 979595bcb8da04381ed85d3b0eb1f471cc5863e4 Author: Duc Dang Date: Thu Jun 18 11:45:39 2015 -0700 PCI: xgene: Allow config access to Root Port even when link is down Previously, when a Root Port's link was down, we didn't allow config access to the Root Port, which meant that if the Root Port led to an empty slot, "lspci" didn't even show the Root Port. Allow config access to Root Port even when link is down. [bhelgaas: changelog] Suggested-by: Bjorn Helgaas Signed-off-by: Duc Dang Signed-off-by: Tanmay Inamdar Signed-off-by: Bjorn Helgaas diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c index 70af714..1fc8910 100644 --- a/drivers/pci/host/pci-xgene.c +++ b/drivers/pci/host/pci-xgene.c @@ -139,7 +139,7 @@ static void __iomem *xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn, { struct xgene_pcie_port *port = bus->sysdata; - if ((pci_is_root_bus(bus) && devfn != 0) || !port->link_up || + if ((pci_is_root_bus(bus) && devfn != 0) || xgene_pcie_hide_rc_bars(bus, offset)) return NULL;