From patchwork Wed Nov 18 08:35:14 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Finn Thain X-Patchwork-Id: 7646051 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E9654BF90C for ; Wed, 18 Nov 2015 08:49:05 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 01DFB205FA for ; Wed, 18 Nov 2015 08:49:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB38920602 for ; Wed, 18 Nov 2015 08:49:03 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZyyO3-0003xf-Qk; Wed, 18 Nov 2015 08:46:43 +0000 Received: from kvm5.telegraphics.com.au ([98.124.60.144]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZyyNz-0003v1-JI for linux-arm-kernel@lists.infradead.org; Wed, 18 Nov 2015 08:46:40 +0000 Received: by kvm5.telegraphics.com.au (Postfix, from userid 502) id 366612294C; Wed, 18 Nov 2015 03:46:17 -0500 (EST) Message-Id: <20151118083500.331697270@telegraphics.com.au> User-Agent: quilt/0.50-1 Date: Wed, 18 Nov 2015 19:35:14 +1100 From: Finn Thain To: "James E.J. Bottomley" , Michael Schmitz , , , , Russell King , linux-arm-kernel@lists.infradead.org Subject: [PATCH 19/71] ncr5380: Cleanup bogus {request, release}_region() calls References: <20151118083455.331768508@telegraphics.com.au> Content-Disposition: inline; filename=ncr5380-cleanup-request_region-release_region X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151118_004639_714723_5D9215AE X-CRM114-Status: UNSURE ( 7.34 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.5 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 8b801ead3d7a ("[ARM] rpc: update Acorn SCSI drivers to modern ecard interfaces") neglected to remove a request_region() call in cumana_1.c. Commit eda32612f7b2 ("[PATCH] give all LLDD driver a ->release method") in history/history.git added some pointless release_region() calls in dtc.c, pas16.c and t128.c. Fix these issues. Signed-off-by: Finn Thain --- drivers/scsi/arm/cumana_1.c | 6 ------ drivers/scsi/dtc.c | 2 -- drivers/scsi/pas16.c | 2 -- drivers/scsi/t128.c | 2 -- 4 files changed, 12 deletions(-) Index: linux/drivers/scsi/arm/cumana_1.c =================================================================== --- linux.orig/drivers/scsi/arm/cumana_1.c 2015-11-18 19:33:10.000000000 +1100 +++ linux/drivers/scsi/arm/cumana_1.c 2015-11-18 19:33:26.000000000 +1100 @@ -245,12 +245,6 @@ static int cumanascsi1_probe(struct expa priv(host)->ctrl = 0; writeb(0, priv(host)->base + CTRL); - host->n_io_port = 255; - if (!(request_region(host->io_port, host->n_io_port, "CumanaSCSI-1"))) { - ret = -EBUSY; - goto out_unmap; - } - ret = request_irq(host->irq, cumanascsi_intr, 0, "CumanaSCSI-1", host); if (ret) { Index: linux/drivers/scsi/dtc.c =================================================================== --- linux.orig/drivers/scsi/dtc.c 2015-11-18 19:33:10.000000000 +1100 +++ linux/drivers/scsi/dtc.c 2015-11-18 19:33:26.000000000 +1100 @@ -423,8 +423,6 @@ static int dtc_release(struct Scsi_Host if (shost->irq != NO_IRQ) free_irq(shost->irq, shost); NCR5380_exit(shost); - if (shost->io_port && shost->n_io_port) - release_region(shost->io_port, shost->n_io_port); scsi_unregister(shost); iounmap(hostdata->base); return 0; Index: linux/drivers/scsi/pas16.c =================================================================== --- linux.orig/drivers/scsi/pas16.c 2015-11-18 19:33:10.000000000 +1100 +++ linux/drivers/scsi/pas16.c 2015-11-18 19:33:26.000000000 +1100 @@ -540,8 +540,6 @@ static int pas16_release(struct Scsi_Hos if (shost->irq != NO_IRQ) free_irq(shost->irq, shost); NCR5380_exit(shost); - if (shost->io_port && shost->n_io_port) - release_region(shost->io_port, shost->n_io_port); scsi_unregister(shost); return 0; } Index: linux/drivers/scsi/t128.c =================================================================== --- linux.orig/drivers/scsi/t128.c 2015-11-18 19:33:10.000000000 +1100 +++ linux/drivers/scsi/t128.c 2015-11-18 19:33:26.000000000 +1100 @@ -255,8 +255,6 @@ static int t128_release(struct Scsi_Host if (shost->irq != NO_IRQ) free_irq(shost->irq, shost); NCR5380_exit(shost); - if (shost->io_port && shost->n_io_port) - release_region(shost->io_port, shost->n_io_port); scsi_unregister(shost); iounmap(hostdata->base); return 0;