[question] kernel build fails with O0 gcc optimization flag

Commit Message

Yury Norov Nov. 25, 2015, 7:56 p.m. UTC

On Wed, Nov 25, 2015 at 06:06:08PM +0000, Russell King - ARM Linux wrote:
> On Wed, Nov 25, 2015 at 08:12:29PM +0300, Yury Norov wrote:
> > Hi all.
> > 
> > I changed optimization from O2 to O0 in Makefile:
> >         609 ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE
> >         610 KBUILD_CFLAGS   += -Os $(call cc-disable-warning,maybe-uninitialized,)
> >         611 else
> >         612 KBUILD_CFLAGS   += -O2 <-- here
> >         613 endif
> 
> -O0 is not supported, sorry.
> 

If so, why not to notify explicitly?

Signed-off-by: Yury Norov <[e-mail]>
---
 Makefile            | 2 +-
 arch/arm64/Makefile | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

Patch

diff --git a/Makefile b/Makefile
index 418e98a..a2e8d3a 100644
--- a/Makefile
+++ b/Makefile
@@ -602,7 +602,6 @@  all: vmlinux
 ARCH_CPPFLAGS :=
 ARCH_AFLAGS :=
 ARCH_CFLAGS :=
-include arch/$(SRCARCH)/Makefile
 
 KBUILD_CFLAGS	+= $(call cc-option,-fno-delete-null-pointer-checks,)
 
@@ -775,6 +774,7 @@  ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC)), y)
 	KBUILD_AFLAGS += -DCC_HAVE_ASM_GOTO
 endif
 
+include arch/$(SRCARCH)/Makefile
 include scripts/Makefile.kasan
 include scripts/Makefile.extrawarn
 
diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
index 432b69a..d865544 100644
--- a/arch/arm64/Makefile
+++ b/arch/arm64/Makefile
@@ -20,6 +20,10 @@  KBUILD_DEFCONFIG := defconfig
 # Check for binutils support for specific extensions
 lseinstr := $(call as-instr,.arch_extension lse,-DCONFIG_AS_LSE=1)
 
+# Check KBUILD_CFLAGS for  '-O0' as it's not supported now.
+$(if $(findstring -O0,$(KBUILD_CFLAGS)), \
+	$(error ARM64 does not support O0 optimization level. Try O1 or higher))
+
 ifeq ($(CONFIG_ARM64_LSE_ATOMICS), y)
   ifeq ($(lseinstr),)
 $(warning LSE atomics not supported by binutils)