From patchwork Fri Dec 11 12:41:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Petr Mladek X-Patchwork-Id: 7829301 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 79CDB9F387 for ; Fri, 11 Dec 2015 12:44:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id ABE5F20570 for ; Fri, 11 Dec 2015 12:44:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C649A204C9 for ; Fri, 11 Dec 2015 12:44:16 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1a7N1l-0001Pg-Vx; Fri, 11 Dec 2015 12:42:26 +0000 Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1a7N1j-00019Y-9e for linux-arm-kernel@lists.infradead.org; Fri, 11 Dec 2015 12:42:23 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 555D2AC08; Fri, 11 Dec 2015 12:42:00 +0000 (UTC) Date: Fri, 11 Dec 2015 13:41:59 +0100 From: Petr Mladek To: Geert Uytterhoeven Subject: Re: [PATCH v3 4/4] printk/nmi: Increase the size of NMI buffer and make it configurable Message-ID: <20151211124159.GB3729@pathway.suse.cz> References: <1449667265-17525-1-git-send-email-pmladek@suse.com> <1449667265-17525-5-git-send-email-pmladek@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151211_044223_560113_1E992C3E X-CRM114-Status: GOOD ( 12.82 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux MIPS Mailing List , Daniel Thompson , Jiri Kosina , Cris , linux-s390 , Peter Zijlstra , the arch/x86 maintainers , "linux-kernel@vger.kernel.org" , Steven Rostedt , "adi-buildroot-devel@lists.sourceforge.net" , Ingo Molnar , Linux-sh list , sparclinux , Russell King , Andrew Morton , "linuxppc-dev@lists.ozlabs.org" , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri 2015-12-11 12:10:02, Geert Uytterhoeven wrote: > On Wed, Dec 9, 2015 at 2:21 PM, Petr Mladek wrote: > > --- a/init/Kconfig > > +++ b/init/Kconfig > > @@ -866,6 +866,28 @@ config LOG_CPU_MAX_BUF_SHIFT > > 13 => 8 KB for each CPU > > 12 => 4 KB for each CPU > > > > +config NMI_LOG_BUF_SHIFT > > + int "Temporary per-CPU NMI log buffer size (12 => 4KB, 13 => 8KB)" > > + range 10 21 > > + default 13 > > + depends on PRINTK && HAVE_NMI > > Symbol NMI_LOG_BUF_SHIFT does not exist if its dependencies are not met. Åh, the NMI buffer is enabled on arm via NEED_PRINTK_NMI. The buffer is compiled when CONFIG_PRINTK_NMI is defined. I am going to fix it the following way: Thanks a lot for report, Petr Acked-by: Arnd Bergmann Acked-by: Geert Uytterhoeven diff --git a/init/Kconfig b/init/Kconfig index efcff25a112d..61cfd96a3c96 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -870,7 +870,7 @@ config NMI_LOG_BUF_SHIFT int "Temporary per-CPU NMI log buffer size (12 => 4KB, 13 => 8KB)" range 10 21 default 13 - depends on PRINTK && HAVE_NMI + depends on PRINTK_NMI help Select the size of a per-CPU buffer where NMI messages are temporary stored. They are copied to the main log buffer in a safe context