From patchwork Thu Dec 17 15:16:17 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Gortmaker X-Patchwork-Id: 7873981 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1DB8DBEEE5 for ; Thu, 17 Dec 2015 15:18:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2E94C20434 for ; Thu, 17 Dec 2015 15:18:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39EA8203E3 for ; Thu, 17 Dec 2015 15:18:23 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1a9aIc-0005od-CL; Thu, 17 Dec 2015 15:16:58 +0000 Received: from mail.windriver.com ([147.11.1.11]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1a9aIZ-0005iz-Kh; Thu, 17 Dec 2015 15:16:56 +0000 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id tBHFGLTO000328 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 17 Dec 2015 07:16:23 -0800 (PST) Received: from yow-pgortmak-d1 (128.224.56.57) by ALA-HCA.corp.ad.wrs.com (147.11.189.40) with Microsoft SMTP Server id 14.3.248.2; Thu, 17 Dec 2015 07:16:18 -0800 Received: by yow-pgortmak-d1 (Postfix, from userid 1000) id BF23E28000A; Thu, 17 Dec 2015 10:16:17 -0500 (EST) Date: Thu, 17 Dec 2015 10:16:17 -0500 From: Paul Gortmaker To: Daniel Kurtz Subject: Re: [PATCH v2] soc: mediatek: SCPSYS: use module_platform_driver Message-ID: <20151217151617.GY2772@windriver.com> References: <1450263656-12513-1-git-send-email-s.hauer@pengutronix.de> <1562792.sV6cmsyeOM@wuerfel> <56715136.3060908@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151217_071655_799788_88BE83C3 X-CRM114-Status: GOOD ( 23.13 ) X-Spam-Score: -4.2 (----) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Sascha Hauer , Dawei Chien =?utf-8?B?KOmMouWkp+ihmyk=?= , linux-mediatek@lists.infradead.org, Sasha Hauer , Matthias Brugger , "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP [Re: [PATCH v2] soc: mediatek: SCPSYS: use module_platform_driver] On 17/12/2015 (Thu 10:52) Daniel Kurtz wrote: [...] > > Also, since scpsys' Kconfig is "bool" not "tristate" it isn't a real > module so I think we should use: > builtin_platform_driver not module_platform_driver > > CC'ing Paul Gortmaker who seems to be on a mass > builtin_platform_driver conversion at the moment, see: > https://lkml.org/lkml/2015/12/9/952 > Good guess. In my giant queue I have that change. I just haven't got around to the requisite triple check and multi arch rebuild tests and put out a series for soc yet. Here is the short list for soc: drivers-soc-make-mediatek-mtk-scpsys.c-explicitly-no.patch drivers-soc-make-qcom-spm.c-explicitly-non-modular.patch drivers-soc-make-samsung-exynos-srom.c.c-explicitly-.patch drivers-soc-make-sunxi_sram.c-explicitly-non-modular.patch drivers-soc-tegra-make-fuse-tegra.c-explicitly-non-m.patch ...and here is the patch you predicted. If someone wants to fold the change into their work then great; I'll be happy to drop mine and be with one less patch to herd along. Paul. --- From eb32cc2c1db8192c08dd64af69cb172b3be4c98b Mon Sep 17 00:00:00 2001 From: Paul Gortmaker Date: Fri, 4 Sep 2015 19:33:54 -0400 Subject: [PATCH] drivers/soc: make mediatek/mtk-scpsys.c explicitly non-modular The Kconfig currently controlling compilation of this code is: drivers/soc/mediatek/Kconfig:config MTK_SCPSYS drivers/soc/mediatek/Kconfig: bool "MediaTek SCPSYS Support" ...meaning that it currently is not being built as a module by anyone. Lets remove the couple traces of modularity so that when reading the driver there is no doubt it is builtin-only. Since module_platform_driver() uses the same init level priority as builtin_platform_driver() the init ordering remains unchanged with this commit. Cc: Matthias Brugger Cc: Sascha Hauer Cc: Daniel Kurtz Cc: Paul Gortmaker Cc: Olof Johansson Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Signed-off-by: Paul Gortmaker diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c index 164a7d8439b1..ae0ca34e64dd 100644 --- a/drivers/soc/mediatek/mtk-scpsys.c +++ b/drivers/soc/mediatek/mtk-scpsys.c @@ -15,7 +15,7 @@ #include #include #include -#include +#include #include #include #include @@ -484,5 +484,4 @@ static struct platform_driver scpsys_drv = { .of_match_table = of_match_ptr(of_scpsys_match_tbl), }, }; - -module_platform_driver_probe(scpsys_drv, scpsys_probe); +builtin_platform_driver_probe(scpsys_drv, scpsys_probe);