From patchwork Sun Jan 10 15:38:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrew Lunn X-Patchwork-Id: 7997091 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 7B3F3BEEE5 for ; Sun, 10 Jan 2016 15:41:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7237A20222 for ; Sun, 10 Jan 2016 15:41:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5ACC2201F4 for ; Sun, 10 Jan 2016 15:41:17 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aII5M-0000sI-2k; Sun, 10 Jan 2016 15:39:16 +0000 Received: from vps0.lunn.ch ([178.209.37.122]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aII5J-0000hL-OL for linux-arm-kernel@lists.infradead.org; Sun, 10 Jan 2016 15:39:14 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.80) (envelope-from ) id 1aII4p-0005or-TO; Sun, 10 Jan 2016 16:38:43 +0100 Date: Sun, 10 Jan 2016 16:38:43 +0100 From: Andrew Lunn To: Martin Michlmayr Subject: Re: mvsdio not working on OpenRD Message-ID: <20160110153843.GA22229@lunn.ch> References: <20160110042619.GA22738@jirafa.cyrius.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160110042619.GA22738@jirafa.cyrius.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160110_073913_965879_7701167F X-CRM114-Status: GOOD ( 12.83 ) X-Spam-Score: -1.9 (-) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Petazzoni , Nicolas Pitre , francois.lorrain@gmail.com, Rick Thomas , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Sat, Jan 09, 2016 at 08:26:19PM -0800, Martin Michlmayr wrote: > Rick Thomas reported that MMC no longer works on his OpenRD Base. > > With Debian's 3.16 kernel (using mach ID): > > mvsdio mvsdio: no pins associated > mmc0: host does not support reading read-only switch. assuming write-enable. > mmc0: new high speed SDHC card at address 0007 > mmcblk0: mmc0:0007 SD4GB 3.70 GiB· > mmcblk0: p1 > > With Debian's 4.3 and 4.4-rc8 kernels (using Device Tree): > > kirkwood-pinctrl f1010000.pin-controller: pin PIN13 already requested by f1012100.serial; cannot claim for f1090000.mvsdio > kirkwood-pinctrl f1010000.pin-controller: pin-13 (f1090000.mvsdio) status -22 > kirkwood-pinctrl f1010000.pin-controller: could not request pin 13 (PIN13) from group mpp13 on device f1010000.pin-controller > mvsdio f1090000.mvsdio: Error applying setting, reverse things back > mvsdio f1090000.mvsdio: Got CD GPIO > [and no mmc0 or mmcblk0] > > -- > Martin Michlmayr > http://www.cyrius.com/ Hi Rick, Martin If i remember correctly, the OpenRD has some odd muxing going on with MMC and the second serial port. This fits the error message: pmx_uart1: pmx-uart1 { marvell,pins = "mpp13", "mpp14"; marvell,function = "uart1"; }; and pmx_sdio: pmx-sdio { marvell,pins = "mpp12", "mpp13", "mpp14", "mpp15", "mpp16", "mpp17"; marvell,function = "sdio"; }; Either you can have MMC, or you can have the RS-232/RS485 on a DB9 or you can have MMC. You cannot have both. It seems like older Debian kernels has defaulted to MMC, so we should probably disable the serial port. Please can you try the following patch. If this works, i can add it to mainline. The issue we might run into is that somebody else wants serial not MMC.... Andrew Reported-by: Rick Thomas Tested-by: Rick Thomas Reviewed-by: Martin Michlmayr diff --git a/arch/arm/boot/dts/kirkwood-openrd-base.dts b/arch/arm/boot/dts/kirkwood-openrd-base.dts index 8af58999606d..883bd416ba0b 100644 --- a/arch/arm/boot/dts/kirkwood-openrd-base.dts +++ b/arch/arm/boot/dts/kirkwood-openrd-base.dts @@ -18,11 +18,6 @@ / { model = "OpenRD Base"; compatible = "marvell,openrd-base", "marvell,openrd", "marvell,kirkwood-88f6281", "marvell,kirkwood"; - - ocp@f1000000 { - serial@12100 { - status = "okay"; - }; }; };