From patchwork Fri Jan 29 20:58:20 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 8167251 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 154F59F440 for ; Fri, 29 Jan 2016 21:00:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 47D6820361 for ; Fri, 29 Jan 2016 21:00:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 430AE201B9 for ; Fri, 29 Jan 2016 21:00:25 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aPG7z-0007yG-0v; Fri, 29 Jan 2016 20:58:47 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aPG7v-0007wO-Ih for linux-arm-kernel@lists.infradead.org; Fri, 29 Jan 2016 20:58:44 +0000 Received: from smtp.codeaurora.org (localhost [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 5E5F460248; Fri, 29 Jan 2016 20:58:22 +0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 50DE360492; Fri, 29 Jan 2016 20:58:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from localhost (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: sboyd@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 25DD460248; Fri, 29 Jan 2016 20:58:20 +0000 (UTC) Date: Fri, 29 Jan 2016 12:58:20 -0800 From: Stephen Boyd To: Loc Ho Subject: Re: [PATCH v2 2/3] clk: xgene: Add SoC and PMD PLL clocks with v2 hardware Message-ID: <20160129205820.GU12841@codeaurora.org> References: <1453256863-15092-1-git-send-email-lho@apm.com> <1453256863-15092-3-git-send-email-lho@apm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1453256863-15092-3-git-send-email-lho@apm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Scanned: ClamAV using ClamSMTP X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160129_125843_650262_DC23F412 X-CRM114-Status: GOOD ( 15.03 ) X-Spam-Score: -1.9 (-) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mturquette@baylibre.com, patches@apm.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 01/19, Loc Ho wrote: > Add X-Gene SoC and PMD PLL clocks support for v2 hardware. > X-Gene SoC v2 and above use an slightly different SoC > and PMD PLL hardware logic. > > Signed-off-by: Loc Ho > --- It's not from this patch, but I notice that we have a return inside a void function in this file... ---8<--- From: Stephen Boyd Subject: [PATCH] clk: xgene: Remove return from void function This function doesn't return anything because it's void. Drop the return statement. Cc: Loc Ho Signed-off-by: Stephen Boyd --- drivers/clk/clk-xgene.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk-xgene.c b/drivers/clk/clk-xgene.c index 266d573b9134..bd7156baa08b 100644 --- a/drivers/clk/clk-xgene.c +++ b/drivers/clk/clk-xgene.c @@ -50,7 +50,7 @@ static inline u32 xgene_clk_read(void __iomem *csr) static inline void xgene_clk_write(u32 data, void __iomem *csr) { - return writel_relaxed(data, csr); + writel_relaxed(data, csr); } /* PLL Clock */