From patchwork Mon Mar 21 16:48:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Zijlstra X-Patchwork-Id: 8634321 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 985ADC0553 for ; Mon, 21 Mar 2016 16:50:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C42D2202FE for ; Mon, 21 Mar 2016 16:50:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9743202E5 for ; Mon, 21 Mar 2016 16:50:42 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ai30b-0005Hj-4A; Mon, 21 Mar 2016 16:48:49 +0000 Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=twins) by bombadil.infradead.org with esmtpsa (Exim 4.80.1 #2 (Red Hat Linux)) id 1ai30Y-0005Gy-D8; Mon, 21 Mar 2016 16:48:46 +0000 Received: by twins (Postfix, from userid 1000) id 04E641257A0D9; Mon, 21 Mar 2016 17:48:44 +0100 (CET) Date: Mon, 21 Mar 2016 17:48:44 +0100 From: Peter Zijlstra To: Chris Metcalf Subject: Re: [PATCH v2 4/4] nmi_backtrace: generate one-line reports for idle cpus Message-ID: <20160321164843.GD6344@twins.programming.kicks-ass.net> References: <1458147733-29338-1-git-send-email-cmetcalf@mellanox.com> <1458147733-29338-5-git-send-email-cmetcalf@mellanox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1458147733-29338-5-git-send-email-cmetcalf@mellanox.com> User-Agent: Mutt/1.5.21 (2012-12-30) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Morton , linux-arch@vger.kernel.org, Daniel Thompson , Russell King , x86@kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , Aaron Tomlin , Thomas Gleixner , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The below annotates the two most used idle functions on x86 --- a/arch/x86/kernel/acpi/cstate.c +++ b/arch/x86/kernel/acpi/cstate.c @@ -152,7 +152,7 @@ int acpi_processor_ffh_cstate_probe(unsi } EXPORT_SYMBOL_GPL(acpi_processor_ffh_cstate_probe); -void acpi_processor_ffh_cstate_enter(struct acpi_processor_cx *cx) +__cpuidle void acpi_processor_ffh_cstate_enter(struct acpi_processor_cx *cx) { unsigned int cpu = smp_processor_id(); struct cstate_entry *percpu_entry; --- a/drivers/idle/intel_idle.c +++ b/drivers/idle/intel_idle.c @@ -725,7 +725,7 @@ static struct cpuidle_state avn_cstates[ * * Must be called under local_irq_disable(). */ -static int intel_idle(struct cpuidle_device *dev, +__cpuidle static int intel_idle(struct cpuidle_device *dev, struct cpuidle_driver *drv, int index) { unsigned long ecx = 1; /* break on interrupt flag */