From patchwork Wed Apr 6 08:11:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Petr_=C5=A0tetiar?= X-Patchwork-Id: 8759081 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 7CE009F372 for ; Wed, 6 Apr 2016 08:14:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9E4E120149 for ; Wed, 6 Apr 2016 08:14:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C20202013A for ; Wed, 6 Apr 2016 08:14:05 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aniZO-0003Rn-6j; Wed, 06 Apr 2016 08:12:10 +0000 Received: from ibawizard.net ([82.208.49.253] helo=mengele.ibawizard.net) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aniZL-0003Qv-6P for linux-arm-kernel@lists.infradead.org; Wed, 06 Apr 2016 08:12:08 +0000 Received: by mengele.ibawizard.net (Postfix, from userid 1002) id 0973E1D36050; Wed, 6 Apr 2016 10:11:40 +0200 (CEST) Date: Wed, 6 Apr 2016 10:11:40 +0200 From: Petr =?iso-8859-2?Q?=A9tetiar?= To: Fabio Estevam Subject: Re: [PATCH 2/2] PCI: imx6: Add reset-gpio-active-high boolean property to DT Message-ID: <20160406081140.GR20367@ibawizard.net> References: <1459514508-8557-1-git-send-email-ynezz@true.cz> <1459514508-8557-3-git-send-email-ynezz@true.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160406_011207_415390_4CBA612D X-CRM114-Status: GOOD ( 10.28 ) X-Spam-Score: -2.9 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr =?iso-8859-2?Q?=A9tetiar?= Cc: Mark Rutland , "devicetree@vger.kernel.org" , Russell King , Pawel Moll , Ian Campbell , Marcel Ziswiler , "linux-pci@vger.kernel.org" , Tim Harvey , Richard Zhu , Stefan Agner , Rob Herring , Krzysztof =?iso-8859-2?Q?Ha=B3asa?= , Sascha Hauer , Kumar Gala , Bjorn Helgaas , Petr =?iso-8859-2?Q?=A9tetiar?= , Shawn Guo , "linux-arm-kernel@lists.infradead.org" , Lucas Stach Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fabio Estevam [2016-04-05 12:46:53]: > > @@ -546,9 +549,14 @@ static int __init imx6_pcie_probe(struct platform_device *pdev) > > > > /* Fetch GPIOs */ > > imx6_pcie->reset_gpio = of_get_named_gpio(np, "reset-gpio", 0); > > + imx6_pcie->gpio_active_high = of_property_read_bool(np, > > + "reset-gpio-active-high"); > > You need to document reset-gpio-active-high property in > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt. Is something like this fine? linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt index 3be80c6..23ecb47 100644 --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt @@ -19,6 +19,11 @@ Optional properties: - fsl,tx-deemph-gen2-6db: Gen2 (6db) De-emphasis value. Default: 20 - fsl,tx-swing-full: Gen2 TX SWING FULL value. Default: 127 - fsl,tx-swing-low: TX launch amplitude swing_low value. Default: 127 +- reset-gpio: Should specify the GPIO for PHY reset. Its not polarity aware + and defaults to active-low reset sequence (L=reset state, H=operation state). +- reset-gpio-active-high: If present then the reset sequence using the GPIO + specified in the "reset-gpio" property is reversed (H=reset state, + L=operation state). -- ynezz _______________________________________________