From patchwork Mon Apr 18 15:05:18 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Boris BREZILLON X-Patchwork-Id: 8872881 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 32B029F1C1 for ; Mon, 18 Apr 2016 15:07:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1CB612024D for ; Mon, 18 Apr 2016 15:07:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 058DC201ED for ; Mon, 18 Apr 2016 15:07:01 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1asAkC-0001kq-1c; Mon, 18 Apr 2016 15:05:44 +0000 Received: from down.free-electrons.com ([37.187.137.238] helo=mail.free-electrons.com) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1asAk8-0001bf-J8; Mon, 18 Apr 2016 15:05:41 +0000 Received: by mail.free-electrons.com (Postfix, from userid 110) id 7C0AA25F; Mon, 18 Apr 2016 17:05:19 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from bbrezillon (LMontsouris-657-1-184-87.w90-63.abo.wanadoo.fr [90.63.216.87]) by mail.free-electrons.com (Postfix) with ESMTPSA id 7DF80233; Mon, 18 Apr 2016 17:05:18 +0200 (CEST) Date: Mon, 18 Apr 2016 17:05:18 +0200 From: Boris Brezillon To: Roger Quadros Subject: Re: [PATCH v5 39/50] mtd: nand: omap2: switch to mtd_ooblayout_ops Message-ID: <20160418170518.363f732d@bbrezillon> In-Reply-To: <5714F011.5080409@ti.com> References: <1459354505-32551-1-git-send-email-boris.brezillon@free-electrons.com> <1459354505-32551-40-git-send-email-boris.brezillon@free-electrons.com> <5714F011.5080409@ti.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160418_080540_944188_858A1E68 X-CRM114-Status: GOOD ( 27.25 ) X-Spam-Score: -2.9 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mips@linux-mips.org, Krzysztof Kozlowski , Harvey Hunt , Nicolas Ferre , Stefan Agner , linux-sunxi@googlegroups.com, linux-mtd@lists.infradead.org, punnaiah choudary kalluri , linux-api@vger.kernel.org, Robert Jarzmik , devel@driverdev.osuosl.org, Archit Taneja , linux-samsung-soc@vger.kernel.org, Kamal Dasu , Richard Weinberger , Chen-Yu Tsai , Kukjin Kim , bcm-kernel-feedback-list@broadcom.com, Ezequiel Garcia , Huang Shijie , Jean-Christophe Plagniol-Villard , Haojian Zhuang , Han Xu , linux-arm-kernel@lists.infradead.org, Priit Laes , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Ralf Baechle , Wenyou Yang , Kyungmin Park , Josh Wu , Alexandre Belloni , Maxime Ripard , Brian Norris , David Woodhouse , Daniel Mack Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, 18 Apr 2016 17:32:49 +0300 Roger Quadros wrote: > Boris, > > On 30/03/16 19:14, Boris Brezillon wrote: > > Implementing the mtd_ooblayout_ops interface is the new way of exposing > > ECC/OOB layout to MTD users. > > > > Signed-off-by: Boris Brezillon > > --- > > drivers/mtd/nand/omap2.c | 194 +++++++++++++++++++++++++++-------------------- > > 1 file changed, 113 insertions(+), 81 deletions(-) > > > > diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c > > index 4ebf16b..bca154a 100644 > > --- a/drivers/mtd/nand/omap2.c > > +++ b/drivers/mtd/nand/omap2.c > > @@ -169,8 +169,6 @@ struct omap_nand_info { > > u_char *buf; > > int buf_len; > > struct gpmc_nand_regs reg; > > - /* generated at runtime depending on ECC algorithm and layout selected */ > > - struct nand_ecclayout oobinfo; > > /* fields specific for BCHx_HW ECC scheme */ > > struct device *elm_dev; > > struct device_node *of_node; > > @@ -1639,19 +1637,108 @@ static bool omap2_nand_ecc_check(struct omap_nand_info *info, > > return true; > > } > > > > +static int omap_ooblayout_ecc(struct mtd_info *mtd, int section, > > + struct mtd_oob_region *oobregion) > > +{ > > + struct nand_chip *chip = mtd_to_nand(mtd); > > + int off = chip->options & NAND_BUSWIDTH_16 ? > > + BADBLOCK_MARKER_LENGTH : 1; > > IMO "off = 1" is valid only for OMAP_ECC_HAM1_CODE_HW and 8-bit NAND. > For all other layouts it is always set to BADBLOCK_MARKER_LENGTH. Indeed. [...] > > - /* all OOB bytes from oobfree->offset till end off OOB are free */ > > - ecclayout->oobfree->length = mtd->oobsize - ecclayout->oobfree->offset; > > /* check if NAND device's OOB is enough to store ECC signatures */ > > - if (mtd->oobsize < (ecclayout->eccbytes + BADBLOCK_MARKER_LENGTH)) { > > + min_oobbytes = (oobbytes_per_step * > > + (mtd->writesize / nand_chip->ecc.size)) + > > + (nand_chip->options & NAND_BUSWIDTH_16 ? > > + BADBLOCK_MARKER_LENGTH : 1); > > would it affect this as well? And here as well. I've generated a patch (see below) fixing those problems. > > > + if (mtd->oobsize < min_oobbytes) { > > dev_err(&info->pdev->dev, > > "not enough OOB bytes required = %d, available=%d\n", > > - ecclayout->eccbytes, mtd->oobsize); > > + min_oobbytes, mtd->oobsize); > > err = -EINVAL; > > goto return_error; > > } > > > > I will need to test this change with all possible configurations. > The number of configurations on OMAP is a bit overwhelming :(. Sorry about that, but at least now I have someone who can test it :). Thanks, Boris --->8--- diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c index 9b96f56..07d4039 100644 --- a/drivers/mtd/nand/omap2.c +++ b/drivers/mtd/nand/omap2.c @@ -1640,9 +1640,13 @@ static bool omap2_nand_ecc_check(struct omap_nand_info *info, static int omap_ooblayout_ecc(struct mtd_info *mtd, int section, struct mtd_oob_region *oobregion) { - struct nand_chip *chip = mtd_to_nand(mtd); - int off = chip->options & NAND_BUSWIDTH_16 ? - BADBLOCK_MARKER_LENGTH : 1; + struct omap_nand_info *info = mtd_to_omap(mtd); + struct nand_chip *chip = &info->nand; + int off = BADBLOCK_MARKER_LENGTH; + + if (info->ecc_opt == OMAP_ECC_HAM1_CODE_HW && + !(chip->options & NAND_BUSWIDTH_16)) + off = 1; if (section) return -ERANGE; @@ -1656,9 +1660,13 @@ static int omap_ooblayout_ecc(struct mtd_info *mtd, int section, static int omap_ooblayout_free(struct mtd_info *mtd, int section, struct mtd_oob_region *oobregion) { - struct nand_chip *chip = mtd_to_nand(mtd); - int off = chip->options & NAND_BUSWIDTH_16 ? - BADBLOCK_MARKER_LENGTH : 1; + struct omap_nand_info *info = mtd_to_omap(mtd); + struct nand_chip *chip = &info->nand; + int off = BADBLOCK_MARKER_LENGTH; + + if (info->ecc_opt == OMAP_ECC_HAM1_CODE_HW && + !(chip->options & NAND_BUSWIDTH_16)) + off = 1; if (section) return -ERANGE; @@ -1682,8 +1690,7 @@ static int omap_sw_ooblayout_ecc(struct mtd_info *mtd, int section, struct mtd_oob_region *oobregion) { struct nand_chip *chip = mtd_to_nand(mtd); - int off = chip->options & NAND_BUSWIDTH_16 ? - BADBLOCK_MARKER_LENGTH : 1; + int off = BADBLOCK_MARKER_LENGTH; if (section >= chip->ecc.steps) return -ERANGE; @@ -1702,8 +1709,7 @@ static int omap_sw_ooblayout_free(struct mtd_info *mtd, int section, struct mtd_oob_region *oobregion) { struct nand_chip *chip = mtd_to_nand(mtd); - int off = chip->options & NAND_BUSWIDTH_16 ? - BADBLOCK_MARKER_LENGTH : 1; + int off = BADBLOCK_MARKER_LENGTH; if (section) return -ERANGE; @@ -1737,7 +1743,7 @@ static int omap_nand_probe(struct platform_device *pdev) dma_cap_mask_t mask; unsigned sig; struct resource *res; - int min_oobbytes; + int min_oobbytes = BADBLOCK_MARKER_LENGTH; int oobbytes_per_step; pdata = dev_get_platdata(&pdev->dev); @@ -1921,6 +1927,9 @@ static int omap_nand_probe(struct platform_device *pdev) nand_chip->ecc.correct = omap_correct_data; mtd_set_ooblayout(mtd, &omap_ooblayout_ops); oobbytes_per_step = nand_chip->ecc.bytes; + + if (nand_chip->options & NAND_BUSWIDTH_16) + min_oobbytes = 1; break; case OMAP_ECC_BCH4_CODE_HW_DETECTION_SW: @@ -2038,10 +2047,8 @@ static int omap_nand_probe(struct platform_device *pdev) } /* check if NAND device's OOB is enough to store ECC signatures */ - min_oobbytes = (oobbytes_per_step * - (mtd->writesize / nand_chip->ecc.size)) + - (nand_chip->options & NAND_BUSWIDTH_16 ? - BADBLOCK_MARKER_LENGTH : 1); + min_oobbytes += (oobbytes_per_step * + (mtd->writesize / nand_chip->ecc.size)); if (mtd->oobsize < min_oobbytes) { dev_err(&info->pdev->dev, "not enough OOB bytes required = %d, available=%d\n",