From patchwork Tue Apr 26 20:41:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. McKenney" X-Patchwork-Id: 8945581 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D2293BF29F for ; Tue, 26 Apr 2016 20:43:17 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E9C99200DB for ; Tue, 26 Apr 2016 20:43:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF342200D6 for ; Tue, 26 Apr 2016 20:43:15 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1av9ne-00047n-75; Tue, 26 Apr 2016 20:41:38 +0000 Received: from e18.ny.us.ibm.com ([129.33.205.208]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1av9na-000459-TJ for linux-arm-kernel@lists.infradead.org; Tue, 26 Apr 2016 20:41:35 +0000 Received: from localhost by e18.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 26 Apr 2016 16:41:13 -0400 Received: from d01dlp03.pok.ibm.com (9.56.250.168) by e18.ny.us.ibm.com (146.89.104.205) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 26 Apr 2016 16:41:12 -0400 X-IBM-Helo: d01dlp03.pok.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com X-IBM-RcptTo: linux-arm-kernel@lists.infradead.org Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 7FC14C90057 for ; Tue, 26 Apr 2016 16:41:05 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u3QKfBBn41615594 for ; Tue, 26 Apr 2016 20:41:11 GMT Received: from d01av01.pok.ibm.com (localhost [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u3QKfArq003156 for ; Tue, 26 Apr 2016 16:41:11 -0400 Received: from paulmck-ThinkPad-W541 ([9.70.82.191]) by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u3QKfAOv003126; Tue, 26 Apr 2016 16:41:10 -0400 Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id 22CF016C0758; Tue, 26 Apr 2016 13:41:48 -0700 (PDT) Date: Tue, 26 Apr 2016 13:41:48 -0700 From: "Paul E. McKenney" To: Tony Lindgren Subject: Re: [PATCH arm 1/1] arm: Use _rcuidle tracepoint to allow use from idle Message-ID: <20160426204148.GR3715@linux.vnet.ibm.com> References: <20160426150031.GP5995@atomide.com> <20160426175214.GJ3715@linux.vnet.ibm.com> <20160426182939.GO5995@atomide.com> <20160426190755.GK3715@linux.vnet.ibm.com> <20160426193949.GP5995@atomide.com> <20160426154414.7bb33de4@gandalf.local.home> <20160426195158.GR5995@atomide.com> <20160426200613.GO3715@linux.vnet.ibm.com> <20160426201134.GA29779@linux.vnet.ibm.com> <20160426202538.GS5995@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160426202538.GS5995@atomide.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16042620-0045-0000-0000-000004085A8D X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160426_134135_098059_092C9013 X-CRM114-Status: GOOD ( 21.45 ) X-Spam-Score: -5.2 (-----) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: paulmck@linux.vnet.ibm.com Cc: Russell King , linux-kernel@vger.kernel.org, Steven Rostedt , linux-omap@vger.kernel.org, mingo@kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Apr 26, 2016 at 01:25:39PM -0700, Tony Lindgren wrote: > * Paul E. McKenney [160426 13:12]: > > On Tue, Apr 26, 2016 at 01:06:13PM -0700, Paul E. McKenney wrote: > > > On Tue, Apr 26, 2016 at 12:51:59PM -0700, Tony Lindgren wrote: > > > > * Steven Rostedt [160426 12:45]: > > > > > *Whack* *Whack* *Whack*!!! > > > > > > > > > > Signed-off-by: Steven Rostedt > > > > > --- > > > > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > > > > > index fb74dc1f7520..4fa43c02d682 100644 > > > > > --- a/drivers/clk/clk.c > > > > > +++ b/drivers/clk/clk.c > > > > > @@ -682,12 +682,12 @@ static void clk_core_disable(struct clk_core *core) > > > > > if (--core->enable_count > 0) > > > > > return; > > > > > > > > > > - trace_clk_disable(core); > > > > > + trace_clk_disable_rcuidle(core); > > > > > > > > > > if (core->ops->disable) > > > > > core->ops->disable(core->hw); > > > > > > > > > > - trace_clk_disable_complete(core); > > > > > + trace_clk_disable_complete_rcuidle(core); > > > > > > > > > > clk_core_disable(core->parent); > > > > > } > > > > > > > > Now the mole shows up here! > > > > > > And the patch shows up here! > > > > And I bet you will need this one as well... > > OK and now the mode is coming back after a short nap during idle: Seems a bit unfair to whack it just after a short nap, but here goes! Thanx, Paul ------------------------------------------------------------------------ commit 5c8e9cffebfc02acfbcfd18b46a6b1dbce96cbe3 Author: Paul E. McKenney Date: Tue Apr 26 13:38:55 2016 -0700 arm: Whack yet another event-trace-from-idle mole This commit applies another _rcuidle suffix to fix an RCU use from idle. > =============================== > [ INFO: suspicious RCU usage. ] > 4.6.0-rc5-next-20160426+ #1122 Not tainted > ------------------------------- > include/trace/events/rpm.h:69 suspicious rcu_dereference_check() usage! > > other info that might help us debug this: > > > RCU used illegally from idle CPU! > rcu_scheduler_active = 1, debug_locks = 0 > RCU used illegally from extended quiescent state! > 1 lock held by swapper/0/0: > #0: (&(&dev->power.lock)->rlock){-.-...}, at: [] __pm_runtime_resume+0x3c/0x64 > > stack backtrace: > CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.6.0-rc5-next-20160426+ #1122 > Hardware name: Generic OMAP36xx (Flattened Device Tree) > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > [] (show_stack) from [] (dump_stack+0xb0/0xe4) > [] (dump_stack) from [] (rpm_resume+0x5cc/0x7f4) > [] (rpm_resume) from [] (__pm_runtime_resume+0x4c/0x64) > [] (__pm_runtime_resume) from [] (omap2_gpio_resume_after_idle+0x54/0x68) > [] (omap2_gpio_resume_after_idle) from [] (omap3_enter_idle_bm+0xfc/0x1ec) > [] (omap3_enter_idle_bm) from [] (cpuidle_enter_state+0x80/0x3d4) > [] (cpuidle_enter_state) from [] (cpu_startup_entry+0x198/0x3a0) > [] (cpu_startup_entry) from [] (start_kernel+0x354/0x3c8) > [] (start_kernel) from [<8000807c>] (0x8000807c) Reported-by: Tony Lindgren Signed-off-by: Paul E. McKenney Cc: Tony Lindgren Cc: Russell King Cc: Steven Rostedt Cc: Cc: diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c index e4c2b8fdeff3..15b6d5b199d4 100644 --- a/drivers/base/power/runtime.c +++ b/drivers/base/power/runtime.c @@ -601,7 +601,7 @@ static int rpm_resume(struct device *dev, int rpmflags) struct device *parent = NULL; int retval = 0; - trace_rpm_resume(dev, rpmflags); + trace_rpm_resume_rcuidle(dev, rpmflags); repeat: if (dev->power.runtime_error) @@ -764,7 +764,7 @@ static int rpm_resume(struct device *dev, int rpmflags) spin_lock_irq(&dev->power.lock); } - trace_rpm_return_int(dev, _THIS_IP_, retval); + trace_rpm_return_int_rcuidle(dev, _THIS_IP_, retval); return retval; }