diff mbox

device tree description for AD5820 camera auto-focus coil

Message ID 20160602193027.GB7984@amd (mailing list archive)
State New, archived
Headers show

Commit Message

Pavel Machek June 2, 2016, 7:30 p.m. UTC
Add documentation for ad5820 device tree binding.

Signed-off-by: Pavel Machek <pavel@denx.de>

Comments

Sakari Ailus June 2, 2016, 9:27 p.m. UTC | #1
On Thu, Jun 02, 2016 at 09:30:27PM +0200, Pavel Machek wrote:
> 
> Add documentation for ad5820 device tree binding.
> 
> Signed-off-by: Pavel Machek <pavel@denx.de>

Thanks, Pavel!!

Can I pick the two patches (this one + the driver) or would you like to send
a pull request? In the latter case you can add:

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Pavel Machek June 3, 2016, 6:19 a.m. UTC | #2
On Fri 2016-06-03 00:27:46, Sakari Ailus wrote:
> On Thu, Jun 02, 2016 at 09:30:27PM +0200, Pavel Machek wrote:
> > 
> > Add documentation for ad5820 device tree binding.
> > 
> > Signed-off-by: Pavel Machek <pavel@denx.de>
> 
> Thanks, Pavel!!
> 
> Can I pick the two patches (this one + the driver) or would you like to send
> a pull request? In the latter case you can add:

Yes please, pick up the two patches.

Best regards,
									Pavel

> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>
Rob Herring (Arm) June 6, 2016, 1:29 p.m. UTC | #3
On Thu, Jun 02, 2016 at 09:30:27PM +0200, Pavel Machek wrote:
> 
> Add documentation for ad5820 device tree binding.
> 
> Signed-off-by: Pavel Machek <pavel@denx.de>
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ad5820.txt b/Documentation/devicetree/bindings/media/i2c/ad5820.txt
> new file mode 100644
> index 0000000..fb70ca5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ad5820.txt
> @@ -0,0 +1,19 @@
> +* Analog Devices AD5820 autofocus coil
> +
> +Required Properties:
> +
> +  - compatible: Must contain "adi,ad5820"
> +
> +  - reg: I2C slave address
> +
> +  - VANA-supply: supply of voltage for VANA pin
> +
> +Example:
> +
> +       ad5820: coil@0c {

Drop the leading 0. With that,

Acked-by: Rob Herring <robh@kernel.org>
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/ad5820.txt b/Documentation/devicetree/bindings/media/i2c/ad5820.txt
new file mode 100644
index 0000000..fb70ca5
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/ad5820.txt
@@ -0,0 +1,19 @@ 
+* Analog Devices AD5820 autofocus coil
+
+Required Properties:
+
+  - compatible: Must contain "adi,ad5820"
+
+  - reg: I2C slave address
+
+  - VANA-supply: supply of voltage for VANA pin
+
+Example:
+
+       ad5820: coil@0c {
+               compatible = "adi,ad5820";
+               reg = <0x0c>;
+
+               VANA-supply = <&vaux4>;
+       };
+