diff mbox

cpufreq: ti: Use generic platdev driver

Message ID 20160914204137.20346-1-d-gerlach@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Dave Gerlach Sept. 14, 2016, 8:41 p.m. UTC
Now that the cpufreq-dt-platdev is used to create the cpufreq-dt platform
device for all OMAP platforms and the platform code that did it
before has been removed, add ti,am33xx and ti,dra7xx to the machine list
in cpufreq-dt-platdev which had relied on the removed platform code to do
this previously.

Fixes: 7694ca6e1d6f ("cpufreq: omap: Use generic platdev driver")
Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
---
 drivers/cpufreq/cpufreq-dt-platdev.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Dave Gerlach Sept. 14, 2016, 9:36 p.m. UTC | #1
On 09/14/2016 03:41 PM, Dave Gerlach wrote:
> Now that the cpufreq-dt-platdev is used to create the cpufreq-dt platform
> device for all OMAP platforms and the platform code that did it
> before has been removed, add ti,am33xx and ti,dra7xx to the machine list
> in cpufreq-dt-platdev which had relied on the removed platform code to do
> this previously.
>
> Fixes: 7694ca6e1d6f ("cpufreq: omap: Use generic platdev driver")
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> ---

This got left out when OMAP was originally added to the 
cpufreq-dt-platdev, so cpufreq disappeared on am335x and dra7 platforms. 
This patch together with the series here [1] will fix this regression.

Regards,
Dave

[1] http://marc.info/?l=linux-pm&m=147388667613317&w=2

>   drivers/cpufreq/cpufreq-dt-platdev.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> index 0bb44d5b5df4..d5e8ba50f8a3 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -68,6 +68,8 @@ static const struct of_device_id machines[] __initconst = {
>
>   	{ .compatible = "sigma,tango4" },
>
> +	{ .compatible = "ti,am33xx", },
> +	{ .compatible = "ti,dra7", },
>   	{ .compatible = "ti,omap2", },
>   	{ .compatible = "ti,omap3", },
>   	{ .compatible = "ti,omap4", },
>
Viresh Kumar Sept. 15, 2016, 6:25 a.m. UTC | #2
On 14-09-16, 15:41, Dave Gerlach wrote:
> Now that the cpufreq-dt-platdev is used to create the cpufreq-dt platform
> device for all OMAP platforms and the platform code that did it
> before has been removed, add ti,am33xx and ti,dra7xx to the machine list
> in cpufreq-dt-platdev which had relied on the removed platform code to do
> this previously.
> 
> Fixes: 7694ca6e1d6f ("cpufreq: omap: Use generic platdev driver")
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>

Any stable trees you want this to be added to ?

> ---
>  drivers/cpufreq/cpufreq-dt-platdev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> index 0bb44d5b5df4..d5e8ba50f8a3 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -68,6 +68,8 @@ static const struct of_device_id machines[] __initconst = {
>  
>  	{ .compatible = "sigma,tango4" },
>  
> +	{ .compatible = "ti,am33xx", },
> +	{ .compatible = "ti,dra7", },
>  	{ .compatible = "ti,omap2", },
>  	{ .compatible = "ti,omap3", },
>  	{ .compatible = "ti,omap4", },

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Dave Gerlach Sept. 16, 2016, 9:29 p.m. UTC | #3
Hi,
On 09/15/2016 01:25 AM, Viresh Kumar wrote:
> On 14-09-16, 15:41, Dave Gerlach wrote:
>> Now that the cpufreq-dt-platdev is used to create the cpufreq-dt platform
>> device for all OMAP platforms and the platform code that did it
>> before has been removed, add ti,am33xx and ti,dra7xx to the machine list
>> in cpufreq-dt-platdev which had relied on the removed platform code to do
>> this previously.
>>
>> Fixes: 7694ca6e1d6f ("cpufreq: omap: Use generic platdev driver")
>> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
>
> Any stable trees you want this to be added to ?

I suppose it'll go for 4.7-stable as the change happened in v4.6.

>
>> ---
>>   drivers/cpufreq/cpufreq-dt-platdev.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
>> index 0bb44d5b5df4..d5e8ba50f8a3 100644
>> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
>> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
>> @@ -68,6 +68,8 @@ static const struct of_device_id machines[] __initconst = {
>>
>>   	{ .compatible = "sigma,tango4" },
>>
>> +	{ .compatible = "ti,am33xx", },
>> +	{ .compatible = "ti,dra7", },
>>   	{ .compatible = "ti,omap2", },
>>   	{ .compatible = "ti,omap3", },
>>   	{ .compatible = "ti,omap4", },
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>

Thanks,
Dave
Rafael J. Wysocki Sept. 16, 2016, 9:59 p.m. UTC | #4
On Friday, September 16, 2016 04:29:04 PM Dave Gerlach wrote:
> Hi,
> On 09/15/2016 01:25 AM, Viresh Kumar wrote:
> > On 14-09-16, 15:41, Dave Gerlach wrote:
> >> Now that the cpufreq-dt-platdev is used to create the cpufreq-dt platform
> >> device for all OMAP platforms and the platform code that did it
> >> before has been removed, add ti,am33xx and ti,dra7xx to the machine list
> >> in cpufreq-dt-platdev which had relied on the removed platform code to do
> >> this previously.
> >>
> >> Fixes: 7694ca6e1d6f ("cpufreq: omap: Use generic platdev driver")
> >> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> >
> > Any stable trees you want this to be added to ?
> 
> I suppose it'll go for 4.7-stable as the change happened in v4.6.

The commit in the fixes tag went in during the 4.7 cycle, so the fix should
go into 4.7.y, but I'm not going to push it as urgent material for 4.8.

Thanks,
Rafael
Dave Gerlach Sept. 19, 2016, 8:41 p.m. UTC | #5
On 09/16/2016 04:59 PM, Rafael J. Wysocki wrote:
> On Friday, September 16, 2016 04:29:04 PM Dave Gerlach wrote:
>> Hi,
>> On 09/15/2016 01:25 AM, Viresh Kumar wrote:
>>> On 14-09-16, 15:41, Dave Gerlach wrote:
>>>> Now that the cpufreq-dt-platdev is used to create the cpufreq-dt platform
>>>> device for all OMAP platforms and the platform code that did it
>>>> before has been removed, add ti,am33xx and ti,dra7xx to the machine list
>>>> in cpufreq-dt-platdev which had relied on the removed platform code to do
>>>> this previously.
>>>>
>>>> Fixes: 7694ca6e1d6f ("cpufreq: omap: Use generic platdev driver")
>>>> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
>>>
>>> Any stable trees you want this to be added to ?
>>
>> I suppose it'll go for 4.7-stable as the change happened in v4.6.
>
> The commit in the fixes tag went in during the 4.7 cycle, so the fix should
> go into 4.7.y, but I'm not going to push it as urgent material for 4.8.
>

Yes, that is fine, thanks a lot!

Regards,
Dave

> Thanks,
> Rafael
>
diff mbox

Patch

diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
index 0bb44d5b5df4..d5e8ba50f8a3 100644
--- a/drivers/cpufreq/cpufreq-dt-platdev.c
+++ b/drivers/cpufreq/cpufreq-dt-platdev.c
@@ -68,6 +68,8 @@  static const struct of_device_id machines[] __initconst = {
 
 	{ .compatible = "sigma,tango4" },
 
+	{ .compatible = "ti,am33xx", },
+	{ .compatible = "ti,dra7", },
 	{ .compatible = "ti,omap2", },
 	{ .compatible = "ti,omap3", },
 	{ .compatible = "ti,omap4", },