From patchwork Wed Sep 21 00:02:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 9342631 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 85517601C2 for ; Wed, 21 Sep 2016 00:03:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7986F29BCA for ; Wed, 21 Sep 2016 00:03:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6CDD029BCD; Wed, 21 Sep 2016 00:03:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D7D9729BCA for ; Wed, 21 Sep 2016 00:03:52 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bmUzm-0005gc-3S; Wed, 21 Sep 2016 00:02:38 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bmUzh-0005aX-9X for linux-arm-kernel@lists.infradead.org; Wed, 21 Sep 2016 00:02:34 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id CE6EF61659; Wed, 21 Sep 2016 00:02:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1474416132; bh=cYpdVTljjN/7MUeWFVk9dUCPlxUq3EVkKINfh7CnEoc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cXehD/5lT1TyeQ88Z+K3f2c7m+agJoEl1kbcEl6okb4zLBhxTxWIwMCMvgEURoTtt e9iS16+om4sIuREUtT0A/28DoXJOwoRYCl98l/JF9UgP2GZIZe53ga6ExJwTYPh6ne DNw3fvKDUjHnyAInhVkEH6IFy47K2vsezRGv+iZc= Received: from localhost (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: sboyd@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 495176141A; Wed, 21 Sep 2016 00:02:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1474416132; bh=cYpdVTljjN/7MUeWFVk9dUCPlxUq3EVkKINfh7CnEoc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cXehD/5lT1TyeQ88Z+K3f2c7m+agJoEl1kbcEl6okb4zLBhxTxWIwMCMvgEURoTtt e9iS16+om4sIuREUtT0A/28DoXJOwoRYCl98l/JF9UgP2GZIZe53ga6ExJwTYPh6ne DNw3fvKDUjHnyAInhVkEH6IFy47K2vsezRGv+iZc= DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 495176141A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Tue, 20 Sep 2016 17:02:11 -0700 From: Stephen Boyd To: Alexandre Belloni Subject: Re: [PATCH v3 1/5] clk: at91: move slow clock controller clocks to sckc.c Message-ID: <20160921000211.GH8319@codeaurora.org> References: <20160920205833.19638-1-alexandre.belloni@free-electrons.com> <20160920205833.19638-2-alexandre.belloni@free-electrons.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160920205833.19638-2-alexandre.belloni@free-electrons.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160920_170233_436892_00BB7DAD X-CRM114-Status: GOOD ( 12.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Michael Turquette , Nicolas Ferre , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 09/20, Alexandre Belloni wrote: > Move all clocks related to the slow clock controller to sckc.c. This avoids > extern definitions and allows to remove sckc.h > > Signed-off-by: Alexandre Belloni > --- Applied to clk-next drivers/clk/at91/sckc.c:146:13: warning: symbol 'of_at91sam9x5_clk_slow_osc_setup' was not declared. Should it be static? drivers/clk/at91/sckc.c:260:13: warning: symbol 'of_at91sam9x5_clk_slow_rc_osc_setup' was not declared. Should it be static? drivers/clk/at91/sckc.c:359:13: warning: symbol 'of_at91sam9x5_clk_slow_setup' was not declared. Should it be static? ----8<---- diff --git a/drivers/clk/at91/sckc.c b/drivers/clk/at91/sckc.c index f6ed711af738..311956abf4aa 100644 --- a/drivers/clk/at91/sckc.c +++ b/drivers/clk/at91/sckc.c @@ -143,8 +143,8 @@ at91_clk_register_slow_osc(void __iomem *sckcr, return hw; } -void __init of_at91sam9x5_clk_slow_osc_setup(struct device_node *np, - void __iomem *sckcr) +static void __init +of_at91sam9x5_clk_slow_osc_setup(struct device_node *np, void __iomem *sckcr) { struct clk_hw *hw; const char *parent_name; @@ -257,8 +257,8 @@ at91_clk_register_slow_rc_osc(void __iomem *sckcr, return hw; } -void __init of_at91sam9x5_clk_slow_rc_osc_setup(struct device_node *np, - void __iomem *sckcr) +static void __init +of_at91sam9x5_clk_slow_rc_osc_setup(struct device_node *np, void __iomem *sckcr) { struct clk_hw *hw; u32 frequency = 0; @@ -356,8 +356,8 @@ at91_clk_register_sam9x5_slow(void __iomem *sckcr, return hw; } -void __init of_at91sam9x5_clk_slow_setup(struct device_node *np, - void __iomem *sckcr) +static void __init +of_at91sam9x5_clk_slow_setup(struct device_node *np, void __iomem *sckcr) { struct clk_hw *hw; const char *parent_names[2];