From patchwork Sun Oct 9 07:49:10 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 9368395 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A1DFC6077E for ; Sun, 9 Oct 2016 07:52:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8F9DB290AB for ; Sun, 9 Oct 2016 07:52:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6E30F290CE; Sun, 9 Oct 2016 07:52:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 122E9290AB for ; Sun, 9 Oct 2016 07:52:05 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bt8rp-0005ZI-1S; Sun, 09 Oct 2016 07:49:53 +0000 Received: from mail.kernel.org ([198.145.29.136]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bt8rl-0005XU-2h for linux-arm-kernel@lists.infradead.org; Sun, 09 Oct 2016 07:49:50 +0000 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7FAB620274; Sun, 9 Oct 2016 07:49:26 +0000 (UTC) Received: from tiger (unknown [180.106.218.147]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4954F2026C; Sun, 9 Oct 2016 07:49:23 +0000 (UTC) Date: Sun, 9 Oct 2016 15:49:10 +0800 From: Shawn Guo To: Rob Herring Subject: Re: [PATCH v2 1/2] dt-bindings: add bindings doc for ZTE VOU display controller Message-ID: <20161009074910.GA15400@tiger> References: <1474727185-24180-1-git-send-email-shawn.guo@linaro.org> <1474727185-24180-2-git-send-email-shawn.guo@linaro.org> <20161003174429.GA26054@rob-hp-laptop> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20161003174429.GA26054@rob-hp-laptop> User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Scanned: ClamAV using ClamSMTP X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161009_004949_239207_9AFFC3D0 X-CRM114-Status: GOOD ( 18.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Daniel Vetter , Baoyou Xie , dri-devel@lists.freedesktop.org, Jun Nie , Shawn Guo , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Oct 03, 2016 at 12:44:29PM -0500, Rob Herring wrote: > > +Example: > > + > > +vou: vou@1440000 { > > + compatible = "zte,zx296718-vou"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + reg = <0x1440000 0x10000>; > > + ranges; > > You still have overlapping addresses. Explicitly list the sub ranges in > reg here used by the VOU driver if the driver usage doesn't overlap. If > there is overlap (2 drivers accessing the same range), then you need > some APIs between the components (or possibly regmap). The driver matching "zte,zx296718-vou" doesn't map or access the any 'reg' address. The 'reg' property here is more like a hint telling that the VOU block covers the address space of all child devices. I will simply drop the 'reg' property here. > Also, don't do an empty ranges here. Fill it in so the child nodes are > just offsets of 0x1440000 Okay. I thought that empty 'ranges' is fine as long as parent and child address spaces are identical (1:1 mapping). So with your suggestion, I made the changes below. Let me know if this is still not what you are asking for. Shawn -----8<----------------- Acked-by: Rob Herring diff --git a/Documentation/devicetree/bindings/display/zte,vou.txt b/Documentation/devicetree/bindings/display/zte,vou.txt index d03ba4c4810c..6bb4ab2517ef 100644 --- a/Documentation/devicetree/bindings/display/zte,vou.txt +++ b/Documentation/devicetree/bindings/display/zte,vou.txt @@ -56,14 +56,13 @@ vou: vou@1440000 { compatible = "zte,zx296718-vou"; #address-cells = <1>; #size-cells = <1>; - reg = <0x1440000 0x10000>; - ranges; + ranges = <0 0x1440000 0x10000>; - dpc: dpc@1440000 { + dpc: dpc@0 { compatible = "zte,zx296718-dpc"; - reg = <0x1440000 0x1000>, <0x1441000 0x1000>, - <0x1445000 0x1000>, <0x1446000 0x1000>, - <0x144a000 0x1000>; + reg = <0x0000 0x1000>, <0x1000 0x1000>, + <0x5000 0x1000>, <0x6000 0x1000>, + <0xa000 0x1000>; reg-names = "osd", "timing_ctrl", "dtrc", "vou_ctrl", "otfppu"; @@ -74,9 +73,9 @@ vou: vou@1440000 { "main_wclk", "aux_wclk"; }; - hdmi: hdmi@144c000 { + hdmi: hdmi@c000 { compatible = "zte,zx296718-hdmi"; - reg = <0x144c000 0x4000>; + reg = <0xc000 0x4000>; interrupts = ;