| Message ID | 20161029135839.6388-1-christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
For the spear or arm-soc guys to deal with... On Sat, Oct 29, 2016 at 03:58:39PM +0200, Christophe JAILLET wrote: > 'clk_get_sys()' returns an error pointer in case of error, not NULL. So > test it with IS_ERR. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > arch/arm/mach-spear/time.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-spear/time.c b/arch/arm/mach-spear/time.c > index 9ccffc1d0f28..4878ba90026d 100644 > --- a/arch/arm/mach-spear/time.c > +++ b/arch/arm/mach-spear/time.c > @@ -233,7 +233,7 @@ void __init spear_setup_of_timer(void) > } > > gpt_clk = clk_get_sys("gpt0", NULL); > - if (!gpt_clk) { > + if (IS_ERR(gpt_clk)) { > pr_err("%s:couldn't get clk for gpt\n", __func__); > goto err_iomap; > } > -- > 2.9.3 >
On Sat, Oct 29, 2016 at 7:28 PM, Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > 'clk_get_sys()' returns an error pointer in case of error, not NULL. So > test it with IS_ERR. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > arch/arm/mach-spear/time.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On Sat, Oct 29, 2016 at 03:58:39PM +0200, Christophe JAILLET wrote: > 'clk_get_sys()' returns an error pointer in case of error, not NULL. So > test it with IS_ERR. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Applied to fixes-non-critical, thanks. -Olof
diff --git a/arch/arm/mach-spear/time.c b/arch/arm/mach-spear/time.c index 9ccffc1d0f28..4878ba90026d 100644 --- a/arch/arm/mach-spear/time.c +++ b/arch/arm/mach-spear/time.c @@ -233,7 +233,7 @@ void __init spear_setup_of_timer(void) } gpt_clk = clk_get_sys("gpt0", NULL); - if (!gpt_clk) { + if (IS_ERR(gpt_clk)) { pr_err("%s:couldn't get clk for gpt\n", __func__); goto err_iomap; }
'clk_get_sys()' returns an error pointer in case of error, not NULL. So test it with IS_ERR. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- arch/arm/mach-spear/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)