| Message ID | 20161229084211.20442-5-andi.shyti@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Dec 29, 2016 at 05:42:11PM +0900, Andi Shyti wrote: > Because the pinctrl DTS is using the samsung.h macros, the > previously pin defines are anused. Remove them. > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi > index 9afed9fcf7e1..3c821e5c241e 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi > @@ -14,19 +14,6 @@ > > #include <dt-bindings/pinctrl/samsung.h> > > -#define PIN_PULL_NONE 0 > -#define PIN_PULL_DOWN 1 > -#define PIN_PULL_UP 3 > - > -#define PIN_DRV_LV1 0 > -#define PIN_DRV_LV2 2 > -#define PIN_DRV_LV3 1 > -#define PIN_DRV_LV4 3 > - > -#define PIN_IN 0 > -#define PIN_OUT 1 > -#define PIN_FUNC1 2 > - This should be squashed with 3/4 because logically it is strictly related to it and splitting it does not bring any benefits. Actually while looking at 3/4 I was surprised to see them not removed. Best regards, Krzysztof
> > #include <dt-bindings/pinctrl/samsung.h> > > > > -#define PIN_PULL_NONE 0 > > -#define PIN_PULL_DOWN 1 > > -#define PIN_PULL_UP 3 > > - > > -#define PIN_DRV_LV1 0 > > -#define PIN_DRV_LV2 2 > > -#define PIN_DRV_LV3 1 > > -#define PIN_DRV_LV4 3 > > - > > -#define PIN_IN 0 > > -#define PIN_OUT 1 > > -#define PIN_FUNC1 2 > > - > > This should be squashed with 3/4 because logically it is strictly > related to it and splitting it does not bring any benefits. Actually > while looking at 3/4 I was surprised to see them not removed. Yes, right :) Thanks, Andi
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi index 9afed9fcf7e1..3c821e5c241e 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi @@ -14,19 +14,6 @@ #include <dt-bindings/pinctrl/samsung.h> -#define PIN_PULL_NONE 0 -#define PIN_PULL_DOWN 1 -#define PIN_PULL_UP 3 - -#define PIN_DRV_LV1 0 -#define PIN_DRV_LV2 2 -#define PIN_DRV_LV3 1 -#define PIN_DRV_LV4 3 - -#define PIN_IN 0 -#define PIN_OUT 1 -#define PIN_FUNC1 2 - #define PIN(_func, _pin, _pull, _drv) \ _pin { \ samsung,pins = #_pin; \
Because the pinctrl DTS is using the samsung.h macros, the previously pin defines are anused. Remove them. Signed-off-by: Andi Shyti <andi.shyti@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi | 13 ------------- 1 file changed, 13 deletions(-)