From patchwork Tue Feb 7 14:15:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurentiu Tudor X-Patchwork-Id: 9560217 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A04D460547 for ; Tue, 7 Feb 2017 14:16:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9148428435 for ; Tue, 7 Feb 2017 14:16:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 83F212843A; Tue, 7 Feb 2017 14:16:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAD_ENC_HEADER,BAYES_00 autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4629D28438 for ; Tue, 7 Feb 2017 14:16:29 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cb6Z5-00030u-Gv; Tue, 07 Feb 2017 14:16:15 +0000 Received: from mail-bl2nam02on0053.outbound.protection.outlook.com ([104.47.38.53] helo=NAM02-BL2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cb6Yn-0002XC-Sn for linux-arm-kernel@lists.infradead.org; Tue, 07 Feb 2017 14:16:01 +0000 Received: from DM5PR03CA0016.namprd03.prod.outlook.com (10.175.104.26) by CY1PR0301MB0729.namprd03.prod.outlook.com (10.160.159.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.874.12; Tue, 7 Feb 2017 14:15:35 +0000 Received: from BL2FFO11OLC016.protection.gbl (2a01:111:f400:7c09::142) by DM5PR03CA0016.outlook.office365.com (2603:10b6:3:118::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.888.16 via Frontend Transport; Tue, 7 Feb 2017 14:15:35 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11OLC016.mail.protection.outlook.com (10.173.160.82) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.888.7 via Frontend Transport; Tue, 7 Feb 2017 14:15:35 +0000 Received: from rhuath.am.freescale.net (rhuath.am.freescale.net [10.81.117.102]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v17EFXHX023812; Tue, 7 Feb 2017 07:15:34 -0700 From: To: Subject: [PATCH 02/10] staging: fsl-mc: fix device ref counting Date: Tue, 7 Feb 2017 08:15:22 -0600 Message-ID: <20170207141530.12979-3-laurentiu.tudor@nxp.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170207141530.12979-1-laurentiu.tudor@nxp.com> References: <20170207141530.12979-1-laurentiu.tudor@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131309505354627871; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7916002)(39410400002)(39850400002)(39450400003)(39840400002)(39860400002)(39400400002)(39380400002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(86152003)(86362001)(54906002)(50986999)(7416002)(8656002)(53936002)(77096006)(33646002)(626004)(81156014)(8936002)(76176999)(8676002)(50226002)(110136004)(5003940100001)(81166006)(1076002)(305945005)(356003)(104016004)(47776003)(2950100002)(6916009)(6666003)(2906002)(105606002)(106466001)(38730400002)(189998001)(2876002)(92566002)(4326007)(68736007)(2351001)(97736004)(48376002)(85426001)(50466002)(36756003)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0301MB0729; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC016; 1:QyMAsAZXbpjHcF4n3w2GaJFWpUPrdMgOM6vwEPr3gEQx6GKVCS1BJUXpDfI9SsYVGsB/omy6wT24mZVULlrLefEflx5LzaJbGYJNDbVzbx2oe0BjAn4V0mP8AvP5MI1KFF9vKEMlD18mLBqS1fjJuis6yP49Qa6ptfDOl7aL+DA+MtDEa35Nlenv45lKlO38VmDTGNyZrtMXrQes2rOHPdSX/dKhYk05pDnXgoF1t4fYLAEdZ7R4czdexOKUH0pStRAdwpxf8VG9IqBdTLXRli085ZKAsLGzkl7YAAW3W57PzHHswNj16ABkn+dIA3JXY7z2IgYQFmEYy7/h8FD1N0T/zLIBLPba549HhHrYkeQ07qSKZTPswoVKIdowsTfZ2iawBCydBF2tXZ62thnJIjniOLobvGSa1UszdV4Ww5QJW+gU1AgIm8LMOoBB4GlTDKvmCWs6IUUV4MCGM1mJKiEnqNxbnQ73ddzFQfOUAo6Vp8MhiPiJi8SGLU/Fs4DoijCMZyxuvNlwxrrTYZIxYlbSGsa1O1ieTZxBRLDlfsGRkuJatP4d85g+cu/VCezqfNKk7TzxbrTpH+/H0DnVK8lNxkLxjVYoIS68qY+5ghYnzCfnZwLtCjVJcBGSFkK2uxHSYdhO1jZDymF5GHdEhEPfcEdJ5vQya6UWflgOMselLeVLpQwgYvZtPLtaUGlu5A2ZGUqTvfZZ/yd2vpswK2e7guo1rBpEMyrzr9pczP6GhJgX0z7VfXWPHApbn3ggGtAbkX8ldi47OQUAX3peKg== MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 0f7ec2df-a8e3-4a75-7b1f-08d44f63c8c2 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:CY1PR0301MB0729; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0729; 3:xy1Ty0iCr4CKthklFSw97t03miNQhxQGMCDbBojFdnnfVWDKXwHIZge38PEzIc0LAo26octuxLua283l9Zyi+R0QKKowLJuoGf43TA+ZztS+9N7S5Zunqkl3KR4N1bDEfEowcfTx1Da+VZxuzz21GhYXworoe5BhzHqbaZkvmEfTIh5PUXGSAbQ4Phy2hLPHIBLW9Ge+eD3l7F7oq+K3bFEnhZrd2FekYHYtZtrawBIu4Z9gYvU4l8YOpwpoKAAAyJL12YqLIUY5fgqxSJou7UjPQpYtxIqp8spesVP+Js/+IHCEI0wy7EoT12bb/iQbsFAYpbTTJ7uRurMoo+dSNDZyZXZ92dQSkXNADwBPaYKZDhyshfBcv5QP8Q+kImb6; 25:gxmjtfEuGQQ8Yq2n/WICoGlU//qG6OOBYQ2Ksop2ayBHqYTOU5ihV9MCN/Y00LYHtACqbNEcLjp0YPj0DQ8eTUDTz0i/arVDFpjrfUV/O2FYc07rHbi6MZZV875/gLX/QNbyHeQKXV3YW6d0cnU9f69bquWACZ90tiFohLX24HwGujpL67HjmGr2uOOrjTdK+IP3+j9hf8YpbDmFkxr9XzrghWQzweLjH0xQ/Wt0raOhh2TE5Km7WJUbzpLdQ+6Y9i90j+/FfJuxZCN42VUsxNPeT7gYty/CVDZCgtw66DnW1qzyNZdNmWQ5aG0iLAf856FZ8Xgp59ALvBrPj58QqF/AXZS0umGziKRCxO5lQvAepktqEeXbEiqiP7nU/1DljJFVDNzNKWMjjZxmgWji2uPSI5cjdqFfRNqTUsSEKxMn69IuDvilIBEqUQVURJN8 X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0729; 31:fGpLH/uZ148uQ8zf+H8oqh18cT0/YPP1eSPxyPfD2h7hoimVDvEQdJGc/65Vj+8hsqCS8YDqZSGFQABL3HCuY/RGSSJwFUnqBOJW9o/gyV6+Jp4KMO3ZzwnQIclgk/aTYR2YNOT6GksSmf1FpaS8TzDXIUOxV+9AYvs6d+vPv6zTF12ZSFVja8pc0eGpW+EqnbSpuIIuOic2CLdgwZsymRso+cfFJ+e+QsXvHpN5UrUYnbA8TQyqBPzMQYeCDLbIUqekDdyzs4GDLsduZfySfC+WGmmO445YqecUIw3BZJ8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(2017020603029)(13023025)(13024025)(8121501046)(13017025)(13018025)(13015025)(20170203043)(5005006)(10201501046)(3002001)(6055026)(6096035)(20161123563025)(20161123565025)(20161123559025)(20161123556025)(20161123561025); SRVR:CY1PR0301MB0729; BCL:0; PCL:0; RULEID:(400006); SRVR:CY1PR0301MB0729; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0729; 4:vEexPJURnQUs8sW3PMUYX20ggUUYfXuqhqlfCUqweGjefjHycC5dKrXlLM6HuYcGk8vmeOColJLfYjG2JOuYjjP/c92/BpK5C9x4aNIK60ZFGr9S9V8xzAp3jygi6tXvD+/73hCaJmFfgPNTGxhz7Su+XrS4hi4Jf7if2LEVgOYyEqiJ0uFG0tSL+l/XaQu5l6pfdt6uv83ILr2SZgnlwLclzUz1lJ3y1lNGRUtpW3Xy5ej/HKAlnH41ZDtApryj7iRaOQvNE4dAhUllf9ooiMGo2juAhGdJkrh1PShy+ZDDK1Mab9WYXLxxi0Q0QdGYc2VUtpodXlVrCnZh5ZDAkBASEDNitZbpo+VCn+tpk3zEB2ye42uGINmuqdNoChD9oJvmBwCkRiQTbkMPLd41VG3H848pZ0RuBw+Q9HFVUqzKTxBzbbR/EkkM/LERarYOp4T4b+p6gfYUmaxr1grx24q4vZh6BqOpQQFnxeeTVOiG9cEIVc/aJ8SXsrv1H1oiAzLRSaHu/WLX4g7Nwzizpsgmc8/GovRsdWVORtNivyeo5hKSUl+JwBkpstG9XWdZm/y6K+YIeZM56JGTQyNUoKxFChwGIXndXrCQuM1xSZ2MsajhjvnEQqU7dsRfiw6Ce/1yWTXiFqqsqBhDUqOFNIQt6kOnmjbRiWIbOR5Op4mlTo1Mla6R26smBLyjN0X96SF5jmwHj7EiKuyfr7atD5XRBOQB9dyJkluaZpFTeXF7vqu6FcJjF0g2FHRZN/ul30tXAvz1v6qsPkQdvHizmjAA3KXl2sqSvAOjOaBV2AA= X-Forefront-PRVS: 0211965D06 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0301MB0729; 23:3oDYG5kMPzfH9wx5gQsBJgqGzhrywhljRrzbIZi?= =?us-ascii?Q?GHxgvtqLTG4r26H1SPQxK5YHm4RGhQ6WaqSyak975U3gsn+Ed/80LUewp4V+?= =?us-ascii?Q?T0h6+sJefVujibVaZwiiJSeyWrlgqmH3oaxwxOUqcovA0PZDc8Wa4MAsvgJr?= =?us-ascii?Q?4v7LMmDQX8I5DYTQzVxozdRGt64WdhXHbLpwhQFrLRnoFk7utwmYlXZ4JNPi?= =?us-ascii?Q?vR6GIBzywJWqEJooegHOq2BkD9TgPWH5c33q9V73JzTanM40Ks0cgdXS17lo?= =?us-ascii?Q?Gpy9IU+Wm5HGqNTkFIRs16RV8CqtBW7hFXqycET+K/oWjhqvA0QMDzBeG0F7?= =?us-ascii?Q?RRRK5eh/m4eLswaLuQetz3WpH5oR53OMOJ4fr71uBEDU5Zri5IatIDD0D7qA?= =?us-ascii?Q?+P2cIetEBWraLLzPlsNYnD4mGQxVL/UDt5jMOnq1CXydWzxnkuCn7C/YeUyq?= =?us-ascii?Q?d3aivXVVAz5a2id4bvww1ocoxzave0bTiu2kGhvMb4OEV+G8mJpQI/LW7j4E?= =?us-ascii?Q?8LnY2tmWp9kNZZV/jxLndvHeU9KxfyhnNBBEKE4K/etGbJ58ibN/A7Yzlvhj?= =?us-ascii?Q?8zKvl9EgEPWQYjF+0TlGHNLgYInYJBbCZ2dNzOC9sJEMG6xtzYcEdX8VNO7M?= =?us-ascii?Q?ymyylPiTjtka14yFPPqZx/+CKIIs8jghzSu3mJv7XylQ71x5tAOy/jsh8EDG?= =?us-ascii?Q?QeHW0yXHi8GTXuoe7xVmSEngsoDhCyrNLsM8xrql1LWXZM+gizzaafEdtV5n?= =?us-ascii?Q?XAo7AtUMyfK9F5yORvfntEGlmwAoWCbSHSFCMyChgv7+M6+NjdvxDgJ7pIKU?= =?us-ascii?Q?mA+zy/aujM0h+eyshZaqHvvVI3r+FfoeqNX3/itt3N9ezdc9HLt1NfuwaH73?= =?us-ascii?Q?dasTu8L6PbGs7yB9Q2Y22l8ISZnbqBUlJ812/8CnKGZ9r28BEVDv1FlBDu1c?= =?us-ascii?Q?CuubR7zd0GeZdr4yqgVHYpbEOTTPp0lFREQ2RO1+UGi3Yhi/U4MkZWLuNbQt?= =?us-ascii?Q?YIT0sIJuUe/68GE8DPV5JqBLVkCIGPWrZlPVfk8HvHd4D6Eyej17z7WTLvaO?= =?us-ascii?Q?87RjLYbHkd66JYf0ZXgrQGC7l1eWLz75CWpLtopNPDu9ii7JUPqT2gBCvLod?= =?us-ascii?Q?hqaZL0iuIhVrv4uD5jlpg/XFUxdd1dG88K8TwzVzxqp/5VzMzCENE22jerva?= =?us-ascii?Q?1/gf0vtzl6oXgnFrG75NUCC9dKYNxT479ld3Y2yG26/CJcD89eekVbx983LB?= =?us-ascii?Q?/sqqX38/ZZJghFmFM/eHXOSmhpj2T2BuHcjm+pq/jnUdQ7zXhNe+pTjx4+ht?= =?us-ascii?Q?I5mD36gLqtAQ5jdeS+6LIOTGblSlVxFyeSk1DuUUMqFNPKw+4/omq8/Z+hNg?= =?us-ascii?Q?SrcQmEZ1e/csmHH4bhygWnyA6YEA=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0729; 6:LykgE2efXeMIhZzPsj42A9kd8Ec9cY7LNLan4kR3j2+Jrc/KBaidMQZo2yoOPu4IC0/kdzIR/+bfis4scdK/KMcnrdGW5a9ksvXUgd194m9u3CZczeTP6Mk/np43fY/dyUT6g7NuI1g0425KoKDsBSjYO6+e5DL3dd9guTpUoEItov2N7zt0/GUHavh5+PSP4juwkUthDENqNnRrJrLXmIV+gBawbu5CS5g8gZ3t6y9ifwpatJaVbdX24I3MG1NLAli8/kiScKhzmhFJr4kv1wDyRQbS1QKq/Trq1kT4IvoFnj5uOSQvk2HoGmJSgitr72zo1gYZ7pS5eVwsPOyDF9WkwnV/vfBHyBf2f64K5jNiKpNf9H5JG8lrJt0zSzWjGzdrIG2srCoWh/LD+BJsv9gawGqO88V19TxHBlYMdxc=; 5:klx/gZJwgUAF62dWyN4/91p3dXyL1PJbqsWZKcTkPf4k8FLMY0famsem/AKF//fHmtb41WIR/qgPv+bqsRo4QxBzxTIlEwAUk31zsWMFoOR5FDf1i8+2foflk18kv8QpiMhFDDPc+0kGC4iVxLMPtkb1vzr76mnA4UVkefeKf1RI7W1LnKzjxitviRsbJ8qe; 24:PZbromwu4GXgkbwg/1CTyMujJRagt0bp3A9R879rSRr1QG4XUx3cO+ew9C/KQuuaqc/futkaakB+WRTF7UmKYnk50T4lsJ+2gTCUszM5N4Q= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0729; 7:40lapecY7jjJqHDn6sFK8p9C1NQA1pOBcJB8F7LJWtQ4Ordh29sZC+1eb96Im0ebr5kKXAQkW27lDf8lcufc16RYgr75BJgrWvmYIRrg4XaAmuKBSH/9IlJJKt/0cNRHs5vWGjk0YwXUSehEI12JPdQ1dljVao0k3YB+afDEWwItWplD6uEjYwn2HcKKys4+yWEPQCj3iPi8S68nOuXbWJcpZqjl2yGzhG01NDJcLOmeonno4aO5CvxUv3aCPXSNbb7rxz0B7z7uZyz6BYkZTzQJTwXkXckrHIoFfY+1kBNcrVNYY/9FCvdQYsugecBPfAC+8qXl8J32zBTTFxUlgb8uLnTm6lKmFjAk345mjJBLifls07h/UUlzH62NBdtCoQGysZR0ekZJoSanRjLDs0V2ocrwhCfGWZSBWq0DXeheaNBoLfaM6i6+WgqNnXTmJmtVd77JAgS3lMbZUpTY6g4ecwXAPpH/PtvpgzV+n0H6ErS9eATLQtX1uAsd3FnmyTWEDvjF/89TjkwoOD+/VA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2017 14:15:35.2755 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB0729 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170207_061558_113752_2346129F X-CRM114-Status: GOOD ( 11.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, arnd@arndb.de, ruxandra.radulescu@nxp.com, roy.pledge@nxp.com, linux-kernel@vger.kernel.org, agraf@suse.de, catalin.horghidan@nxp.com, linux-arm-kernel@lists.infradead.org, ioana.ciornei@nxp.com, leoyang.li@nxp.com, bharat.bhushan@nxp.com, stuart.yoder@nxp.com, Laurentiu Tudor Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Laurentiu Tudor Drop unneeded get_device() call at device creation and, as per documentation, drop reference count after using device_find_child() return. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dprc-driver.c | 1 + drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c b/drivers/staging/fsl-mc/bus/dprc-driver.c index 4e416d8..e4b0341 100644 --- a/drivers/staging/fsl-mc/bus/dprc-driver.c +++ b/drivers/staging/fsl-mc/bus/dprc-driver.c @@ -188,6 +188,7 @@ static void dprc_add_new_devices(struct fsl_mc_device *mc_bus_dev, child_dev = fsl_mc_device_lookup(obj_desc, mc_bus_dev); if (child_dev) { check_plugged_state_change(child_dev, obj_desc); + put_device(&child_dev->dev); continue; } diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c index cc20dc4..7c6a43b 100644 --- a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c +++ b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c @@ -537,7 +537,6 @@ int fsl_mc_device_add(struct dprc_obj_desc *obj_desc, goto error_cleanup_dev; } - (void)get_device(&mc_dev->dev); dev_dbg(parent_dev, "added %s\n", dev_name(&mc_dev->dev)); *new_mc_dev = mc_dev;