From patchwork Tue Feb 7 14:15:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurentiu Tudor X-Patchwork-Id: 9560249 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 13CD06047A for ; Tue, 7 Feb 2017 14:18:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 050C428426 for ; Tue, 7 Feb 2017 14:18:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ED98A28429; Tue, 7 Feb 2017 14:18:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAD_ENC_HEADER,BAYES_00 autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7BAB128426 for ; Tue, 7 Feb 2017 14:18:16 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cb6as-0004rf-Kx; Tue, 07 Feb 2017 14:18:06 +0000 Received: from casper.infradead.org ([85.118.1.10]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cb6ZA-00035j-1C for linux-arm-kernel@bombadil.infradead.org; Tue, 07 Feb 2017 14:16:20 +0000 Received: from mail-bn3nam01on0070.outbound.protection.outlook.com ([104.47.33.70] helo=NAM01-BN3-obe.outbound.protection.outlook.com) by casper.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cb6Z6-0007jT-Ka for linux-arm-kernel@lists.infradead.org; Tue, 07 Feb 2017 14:16:18 +0000 Received: from BN6PR03CA0001.namprd03.prod.outlook.com (10.168.230.139) by CY1PR0301MB0730.namprd03.prod.outlook.com (10.160.159.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.874.12; Tue, 7 Feb 2017 14:15:36 +0000 Received: from BL2FFO11FD014.protection.gbl (2a01:111:f400:7c09::184) by BN6PR03CA0001.outlook.office365.com (2603:10b6:404:23::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.888.16 via Frontend Transport; Tue, 7 Feb 2017 14:15:35 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD014.mail.protection.outlook.com (10.173.160.222) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.888.7 via Frontend Transport; Tue, 7 Feb 2017 14:15:35 +0000 Received: from rhuath.am.freescale.net (rhuath.am.freescale.net [10.81.117.102]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v17EFXHZ023812; Tue, 7 Feb 2017 07:15:34 -0700 From: To: Subject: [PATCH 04/10] staging: fsl-mc: don't use devres api for refcounted objects Date: Tue, 7 Feb 2017 08:15:24 -0600 Message-ID: <20170207141530.12979-5-laurentiu.tudor@nxp.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170207141530.12979-1-laurentiu.tudor@nxp.com> References: <20170207141530.12979-1-laurentiu.tudor@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131309505356783890; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7916002)(39850400002)(39400400002)(39410400002)(39450400003)(39860400002)(39380400002)(39840400002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(38730400002)(76176999)(85426001)(53936002)(50986999)(48376002)(8936002)(1076002)(5660300001)(50466002)(105606002)(36756003)(305945005)(106466001)(97736004)(110136004)(77096006)(2351001)(6916009)(8656002)(54906002)(189998001)(104016004)(8676002)(5003940100001)(86362001)(86152003)(356003)(47776003)(2876002)(50226002)(7416002)(2906002)(2950100002)(6666003)(81156014)(81166006)(626004)(92566002)(4326007)(68736007)(33646002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0301MB0730; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD014; 1:ZmM5Tkn9DE8o0UNcMMc9VXpGxe2rlpHcFL61woMqFMA7O9tT/8TIy0s5tJMdf6r9HofcHFiTiLoZW5ZosezzQpvJUYWLl27xdyI1ExhP5g0o5sOZm0nydDgDRs3LrNjMx5ANDTMZFMxMNTVExw3PEic806O2q4LRLi4Q1M3SW4eTW+8oYIqmKxQLEyQz0Ssp7bpUFCPqIdicTRm//e4GydieV48aJQXYwGfdDv70L21EkPD0hMDTLXuopiTdyWDrh6dU1pQ/tbXfUT/qW+skZA/rbG3WrqRnos6ZOIotMIEkb/U/7zVyuu4QWmYJk/bK7a0tahc+KQja2jsV/5RDLH7LF3l5qSC1BiW9U/vyZrM9BZJr0P0W8HqNVVrm4ZDiBiwBcAPdIBk+s5FwcdD5i845cbUa8Zk8w48Y2UFbgRqwTTlJHfip6CVuliURclE1huqi40oEcXskTiw4YbI6/CuGjpf7KXfbyFfMhpwUeLQYTbZ8+rN1x3uC/sVQk+YGML5BjoawHseDS+9q6NeNwlgzbQNgL3CrUHKyEADrwRDfLvF+zL77UdKE7X+z/1ZzLpMeeqY6rgrJJ7vH1oGNaZRmnq3kyGl1DmC1Doq/0aZmwTZfxejH16cbkrk2/L8BHDl+zy/gwT21ceBMUyDFoBCCuxcnPQ4Qba5fsoT25hM2eytdQQXrz9TXvf6cMIPcDqZ8uOt4uAiwov/VOpBusP8wR9kcho9YmMIPa/JPl4IE9tXZyITY/94XZtMDzhrDSQPNef2x2CS9TjoVCi5+zA== MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: f0869fe7-671f-4976-ffb1-08d44f63c8e0 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:CY1PR0301MB0730; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0730; 3:6k7Ixo9lVxAUw57J90HAW6s56leOx1QbJi+uVnb4h11rP8VHH1CRWEB41eIDAxO4ETydJE2JPh7+BYQ0CxN/XiqXZXi3FJT5NxE606hmlCOxdfe8xLjuoehHvvcN1IDcrijcwyXkwGucKWItWhD/f9msx7yxNc65N7Xl/iHXV9hL3kUZ3CZHSeklw6gBSfTC35+XCwZZGel0/P3TILxfHBt6enllVowZvsI9QNvl/juL7fHkF3y7PvIXeI3zal5ily69gYC6GLTh48EMc6NhIWyOvk60PtXTZbWbeaRj8Ls/a4nnDEmon6Ja3ckPBMXSgfdAxQ5EEYRKIyvEy3xte8pEO9wZ82agQy5T6TojWkD5KMsqICzKphZhNpnE7x1/; 25:MIZF+htXhXscawdDjdfKT4taDrQ7lGQTbq/ZkclOorLHAlbVyd5+wSSYc8x0Zl2eXybRCblqseJvKKqH2DvXKSbToYTXFQWLuAxR54O/gLeoBLnL4eBU8vdJsgh0tJMBj/CEIEVB5iY7lGID/vIGwjo+kYIoRuZDmROxU6iKfidTtwqqlQzx1OaB2AonaA7YexeQJVZBTs7OcE7/5cfUTWzRYgpGGaGQjRKHQL98+Oz8GkgA64jLPNyMYFJcUM16ATKSfaFISnO+/gXXyhgSvjspKIkTyllPFDzN7ypIlKSyQmUklqgtdtjn4y9q/GIpFDSXy+G+BYfcGXX8LQudWaDja2qbVlh224hdS2keE1ensmp4Ej4kjC81tPCzkF1iC0N+lnFgq8/wrvg6cmEvoJ2jMCKao+xkWnMIiiz5ne+xrL8DsZTD4qzHwcYBAEwPDdVQW9b/Dtzov4j7usq7Eg== X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0730; 31:zfOqRhAu+1uYj8WlBMN457uqt7zxEcgNB1VHJxUGt8rz8lrHVcrDQBHhzYN3U3oh47Awmk+bQ6I7JGMadLOx/VYQ1KhmZ61plDwVcXxU1aUn6xSI6Rq93SrGZ3UDqzpynJhS7UsPjnqsm437x/Bw65YzEe6awG76sHg81NmdfsZFn/o42h9q0STFxdH+8dncrgF/cUN9xl3mhH6Mm63t3ZcPpP5bQtLrP/K6cpzkFfS5XdlI8cORSgKrDI+b1zF6I34/JxqYFj957Chnk2X3uK4m0PDrmLn1p6Khi4M122ZFOYJRp3Cd5dHeQzv7rrpV X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(5005006)(13023025)(2017020603029)(13015025)(13024025)(13018025)(8121501046)(13017025)(20170203043)(10201501046)(3002001)(6055026)(6096035)(20161123556025)(20161123563025)(20161123559025)(20161123561025)(20161123565025); SRVR:CY1PR0301MB0730; BCL:0; PCL:0; RULEID:(400006); SRVR:CY1PR0301MB0730; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0730; 4:Jr5vnSrv0U++1uXbZZkmpbZ9Y5WvxW52tWvIT0nmvovdmXzOT7vc64HUVA5nGtfQK43K+f6rKn3O1gjDRHaxFasJLgXp0S+fGI5PGnqUPtqgACyquHDs1o7iyl/LdXjtWraSJx2F4cPGihKGKYIihWGC4WjvuXDMgHPrpAXQcic7UMsB5fV6L9P3kt9DA+kv7rbL3aywOWq6fzFMNsGPYrbKeVFrzdiIgkkDVGrwgXOwEaHs9xEK5es/XmXBUCKtGyvXFDUeWnPhs6vK82yx334xMxWbbBpW8Cj3dLPnlk5F6SEXyQjJWRUdPrc0+tnr5DqTfJM8FCtbhoeKme7l7NFnNByWU+ObqyxuJdI7VDhDDmTPPcJgTwIOHdrhEx6i5kkT9/cimVST7FRx+1mk6+SwTfcU3wOCvhEH6ScXP4QMe1sr9847Dk+pZtEBt2lYJNKc00LVLaoZcipQ4eO0Rklbjb3WOPxZPaw5GUM+Q5KbOJAnd049aETBj2ks441zdYvyVQ5+C74Bcfelm5oSVr+z4zA8Pm33eapFFeHqEb7dGLXHngnFhDJ6cYEhBOdrh0fottip5bFNyaNtFVXtpMj45ubaniSiz8ivkCRt8eVSNSEotW1veXAJnUImuK1RhhaMn+ctTrG/Z0V6PL53lG1hjqXUzHrGIv8V1ti9pL1OVGuCXPHpNoHfU4lgu6ZadLQi8xaQjWL91PCKAbqmpgiIzSFtXV2D88+8Oj8ySjFH8ljxHJWRGpO6B7VCSSJY6DJF2vWArrX6aQLbDCeUiWtkGnTjz5fCxG6OA8y6ZSw= X-Forefront-PRVS: 0211965D06 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0301MB0730; 23:Wuvl0caHnYkGqX5hvhEextPpqnMH6V3L03FSQO6?= =?us-ascii?Q?tCTXMiE8ekjjVKRuKASbt0iN+aBDL0uyfcD9aPYHXKkNB3IC/mw/SmZtZ/0R?= =?us-ascii?Q?20LgnQ5X+LYWX56Z/t29b51eLJQL1eHn0nfQ5DxSNUQz4qc7Hk/D6tAiZmnz?= =?us-ascii?Q?WYA2VZjpLJ/hRx7fIQAgRbUHQLK5GSRSpb8a2Ce+2OlkyJdBqsRT7r/gxt+B?= =?us-ascii?Q?eBZI2VJQnb/rUNYs+0e3vyPmxq+UtsZYYdxJZIl5Q4/rxel5GxBXKtLhxlbB?= =?us-ascii?Q?FiyEo8fjaDZr07aVu9da7uab5NrMu0HZA9rrcVisyTQsibrSWgqMYQMq3Jm0?= =?us-ascii?Q?5JjaOiiOJft4HUZq6S9yD2iAGtZl2lYI1vDmcKiNTxYo9ZOlr4S18kgy7aOg?= =?us-ascii?Q?IgZttm9wc87JFgsEjgVu/5iNfebyhvUrfDkW839oJkbODlvsX591X6XcJe2I?= =?us-ascii?Q?Y0Ybqn7nPX5pnH8Kt2pkby2Fpx30O0w2W2SvZVe/NMPg4wNeUn6QaWWYkapH?= =?us-ascii?Q?nvaPGrChXhVY9PJ/OKrVACkxbg2t9sILDwpt1tcTp6kPlK9KoN5dVgztj745?= =?us-ascii?Q?9fLkiyGdiwlK9rNr7gXcAFv9KyIgNtaihjWiURkNo5NfS6bXzW/u1KmPkcs/?= =?us-ascii?Q?mhRVXK/keFSIvaYFcLf0z4LZDwFyNGJtJjoyQg7YlvFB7y3gfjpYzrEiMeLm?= =?us-ascii?Q?W7aLuBuZgCEe2UoSo539caKGSiaLoMF/+ug/9Xnef1yFbRauLfCQKayZSfNN?= =?us-ascii?Q?iLTbGf7oi5JrYJJcdyS1avXaFrGDHiRjJzqpfK9WiuXTaXirw6YsfJ1UWVFV?= =?us-ascii?Q?VAZW5jKWrNcluA59+eRox826U2vCrpKIPcdms1QHCIIYF4Dy3VwVxBKy3ivf?= =?us-ascii?Q?Ppugy0hxIOPjFdsyPsF+MOaOVS+/cUIuKevVrry1LwkSQ22EC58kOdk1HfjB?= =?us-ascii?Q?AYyBGoKCr7kCwaTlO5sA4a/2fSGIl15ranBsvqDoc18pjiR0zfz+O7gFhWv+?= =?us-ascii?Q?1Y2dZ5+I+TQDuYqlQMX/bu5hAa7WxUaxDqpq5gSCZT2Vl7v8xUF4fHf6QDJT?= =?us-ascii?Q?/W+zfGwIiLxCy3iLZzokj2FGRdtEgY6uKuUHGEYS8/+Gum8NeQdbNMTJhPpj?= =?us-ascii?Q?GXvs8lD0Qc3XJSdkb5Hp1gF4HVN31YpQelsFS5n6FyBz6DXiejhhxDdNbwTb?= =?us-ascii?Q?na4rS+MNlV82QR1mRXw2dCC9b1bCSfsJGBq8AKEy5gIewzq9odIIj1E6dpDi?= =?us-ascii?Q?JSIkBsjvRy3Mdz+lvvhMu6zRA6x6Dlj5awVn0QkmZjhaI9+DLGIYfBuOn9F+?= =?us-ascii?Q?i7B0fNZv3Chs9jzlYAiKhhU6PmRYYzYPivBveOoSAqwwUv9zQWYwG4gORby+?= =?us-ascii?Q?6NHWXkz9q/2HcgRUHfoLFZFuZUgA=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0730; 6:HOBKpMnC8njpWygaCxIdcAVC15u93bK6rrNpaEXuySW/lj4A23K7sZFcns1x9jKpt4SltXZAzQOLFdyzDkjqg3DJCfBtxaNB22+b14pPoyGf3I8gRqGJTxzG6fATmFSjsPFv5dkyyJ06FJ3K8QgCbwezBS/v67UXwCY2anNBNs4g2ZsvA7okWID3lMTrCaRvlozVChN/TDHFQLFwr6o7qYU9FAvYSKOCfLt7OMCdQG+GENltIpVu/6r++KqegWcaQ49XbPTvJlD/6QAE8KGyOfBFDmGJV7Oz281lgeTFWQuqD6L6spxiOnZ+PtO/+3ktWHT+M7Y39hMMkwS+h7mXjs4Z8V94cDU2mxegDun3ryeVKcyPy3S1ypvB99HrLw0QkTDkdea8yc2mE47ZRQW2zJa9xk+NYRmxNPMWBsYLVAk=; 5:hr5dAdnNFGkPsW8FJPycJE14FBPrJTnBdRLDYamUjSC8Esqtx1c9z9Rjh1GyXs/F+3BzS9N8nsa17v8tomLMP2msi57pvlcdJyG62VYq4uncNUMfzClxfvYETGu6w2rDfSKdF4NgpoKGSi0JNDTYFH+VpRXXrT6GAjP4cKWuEo5Fl8yoDdtcPWioG/Gc/K4R; 24:n5OYwtrcKPaf0J+nUgdfhcD/mQRO1unfT0TpONT/9BcA7Bt1dDTZWRhzy50feBivHBTHBsaHW9VA8zedU0zm/AXFqr1iKdbdoPQHpq5XDNA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0730; 7:5AZr5yFxB0hR98vHZyTVSQrH8H7BGj9oNEgEpm2UFl5CJWCGgcjOOU58czpmc8oTzgWFjH53u1S0BA32eu0xh36mVSZuZ58zmnQjLirNYi2muNaKA2zB3puN04d5Bcry6osdsdbqB2YqGX3zv14aCVXTE94mIU2QYTH1o/WkOVNiRj55wut5GNLIVMMf1I8afinFc775B0nL7ve1gthDdJlMdtU9XTyBAc2Tx6U2M45uoy2j2obYDrT6wn0ce328pCdyJlQOnYCc7EnAUb5DYRCfg2ft75TF3cKz6Db7eG2IWsFgwcYfZBNvXf6+W4Vetu/XJHsV6Pq5akdlIA+2xm1B3OWVGSCNUKp3agb6DdULuwdkR1CgLwURiKLxBQxPzzcDwVtZbIL88b0FPTG17L2G30Goy2bI2bQ3n4lM1RqyLki+MWXjpd+3cBIjPLAyJqQ3qKNjMeJdsyfSF+7WD0lDrvr9rt57SlQ8/CKNKOD4JdG9xJGW6i1qbzp5eIs9GFAE6Z8N55bbSzonYflNbg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2017 14:15:35.4755 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB0730 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170207_141616_896131_67A9F0FA X-CRM114-Status: GOOD ( 15.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, arnd@arndb.de, ruxandra.radulescu@nxp.com, roy.pledge@nxp.com, linux-kernel@vger.kernel.org, agraf@suse.de, catalin.horghidan@nxp.com, linux-arm-kernel@lists.infradead.org, ioana.ciornei@nxp.com, leoyang.li@nxp.com, bharat.bhushan@nxp.com, stuart.yoder@nxp.com, Laurentiu Tudor Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Laurentiu Tudor Mixing two memory management systems, in this case managed device resource api and refcounted objects is a bad idea. Lifetime of an object is controlled by its refcount so allocating it with other apis that have their own lifetime control is not ok. Drop devm_*() apis in favor of plain allocations. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c index 5963e98..f310687 100644 --- a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c +++ b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c @@ -430,7 +430,7 @@ static void fsl_mc_device_release(struct device *dev) mc_bus = to_fsl_mc_bus(mc_dev); if (mc_bus) - devm_kfree(mc_dev->dev.parent, mc_bus); + kfree(mc_bus); else kmem_cache_free(mc_dev_cache, mc_dev); } @@ -457,7 +457,7 @@ int fsl_mc_device_add(struct dprc_obj_desc *obj_desc, /* * Allocate an MC bus device object: */ - mc_bus = devm_kzalloc(parent_dev, sizeof(*mc_bus), GFP_KERNEL); + mc_bus = kzalloc(sizeof(*mc_bus), GFP_KERNEL); if (!mc_bus) return -ENOMEM; @@ -562,7 +562,7 @@ int fsl_mc_device_add(struct dprc_obj_desc *obj_desc, error_cleanup_dev: kfree(mc_dev->regions); if (mc_bus) - devm_kfree(parent_dev, mc_bus); + kfree(mc_bus); else kmem_cache_free(mc_dev_cache, mc_dev);