From patchwork Fri Mar 10 04:32:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 9614607 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9D7BD60414 for ; Fri, 10 Mar 2017 04:34:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8FFE8285A9 for ; Fri, 10 Mar 2017 04:34:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 84A57286EF; Fri, 10 Mar 2017 04:34:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 357D5285A9 for ; Fri, 10 Mar 2017 04:34:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=6gt+jo9KsUvPy1ujxlAtBuzlwTCfo/fZalxVVEityGQ=; b=sFJwwc0THDZHBW8ANBNw7/rO3C 6uO7byW2VUgM2ZOA9A+TS+6uXnjgZZlE9TWXFzHFhyFFmfI4jyppQxGlSupbccKmrscKeKgZNhHMc VhiOT1OTm1dT52Bpqc7efFI5vbkrSYWZ7DeZ4Dzqui0+PFc1dcDvn2Eie+a3tt6XTaIevEqd3EDhS TrdKBXYojs47V6VXQIAAL/OGLU8o4XvqmKkN12nHkg6yl54CERRxPShQuyMN+XI5AePm1fp7nLKRV +rPvPyZrZeLAAbefBIjZ5jsked0KavurgaCnZdHHgqYUfRyee2r4fTXgK8DiPASFVov80co69N3X0 V8siH8iA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cmCG9-0006p6-OI; Fri, 10 Mar 2017 04:34:33 +0000 Received: from mail-qk0-x22d.google.com ([2607:f8b0:400d:c09::22d]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cmCG4-0006j1-Jt for linux-arm-kernel@lists.infradead.org; Fri, 10 Mar 2017 04:34:31 +0000 Received: by mail-qk0-x22d.google.com with SMTP id p64so152221188qke.1 for ; Thu, 09 Mar 2017 20:34:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kdrimXQs/0vvBikM+18LhUgsp+KR29qz6Ch/VvqWz+0=; b=n6GK35TvoEr50gD8kl51KDW1Ky0rt5wJ/NEjme/v+V8CP6hXyp0BqHRmGyMLGemRYx uTsw5RjjO9YzGAeFjVlN7qRGqVi7LcBbwTpBs1DQWEIfBqcc7xLOE3vltO9KY+YmApGV dVd4jZcG6nxTjrA7tPhKPh/1eiC89AIhZl8fo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kdrimXQs/0vvBikM+18LhUgsp+KR29qz6Ch/VvqWz+0=; b=tfqq54kOyeFGQyV67zkG6/D+P6b4jldFJtfW3PWq2hU+HqyMS/CTzAR40JvlDNpY/H mLrmpV2b79E6V3NOczsSUvOO2gtQs4sZv4iMGOzkCco9xKhMtL9zAKYRXEDvoxrIMtOm evLDMRRY0BICzQKIi0C2K619BWDrw91MfqK7muwOZvTO3mB+W/tmzwgxgcOQaihoDEtL EExMTF512mWimKRFEshrqOAzHcpLOOyvOM5WgHszOkYce2JGKpr1jOkLqgeEcVg4Npiu XsSk1vueGgk2e9Tst8zizonTf3RnoKZeuw242SrMHIC/cnDp6P4LuYm8yjBz5dmOVOX4 tv4g== X-Gm-Message-State: AFeK/H0bVTM1Jg+qO+QZVEXe8/F4AV5j3seWKoxhfuFwi3I7JxH5pEqsl1sqMu5db1zLxpSz X-Received: by 10.55.144.6 with SMTP id s6mr18595950qkd.140.1489120446457; Thu, 09 Mar 2017 20:34:06 -0800 (PST) Received: from boxwood.roam.corp.google.com (cpe-75-189-128-87.nc.res.rr.com. [75.189.128.87]) by smtp.gmail.com with ESMTPSA id n19sm5697731qtn.35.2017.03.09.20.34.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Mar 2017 20:34:05 -0800 (PST) From: Sean Paul To: linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: [PATCH 02/41] drm/rockchip: Get rid of some unnecessary code Date: Thu, 9 Mar 2017 23:32:17 -0500 Message-Id: <20170310043305.17216-3-seanpaul@chromium.org> X-Mailer: git-send-email 2.12.0.246.ga2ecc84866-goog In-Reply-To: <20170310043305.17216-1-seanpaul@chromium.org> References: <20170310043305.17216-1-seanpaul@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170309_203428_766394_B74E0ED6 X-CRM114-Status: GOOD ( 10.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , David Airlie , Tomasz Figa , Sean Paul , linux-arm-kernel@lists.infradead.org, Mark Yao MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Tomasz Figa Current code implements prepare_fb and cleanup_fb callbacks only to grab/release fb references, which is already done by atomic framework when creating/destryoing plane state. Also there are some unused fields vop and vop_win structs. Let's remove these unused bits. Signed-off-by: Tomasz Figa Signed-off-by: Sean Paul Tested-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 2151e1cee4b4..0539afb6b7c8 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -108,9 +108,6 @@ struct vop { struct drm_device *drm_dev; bool is_enabled; - /* mutex vsync_ work */ - struct mutex vsync_mutex; - bool vsync_work_pending; struct completion dsp_hold_completion; /* protected by dev->event_lock */ @@ -1592,8 +1589,6 @@ static int vop_bind(struct device *dev, struct device *master, void *data) spin_lock_init(&vop->reg_lock); spin_lock_init(&vop->irq_lock); - mutex_init(&vop->vsync_mutex); - ret = devm_request_irq(dev, vop->irq, vop_isr, IRQF_SHARED, dev_name(dev), vop); if (ret)