From patchwork Fri Mar 17 21:01:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Kaehlcke X-Patchwork-Id: 9631587 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 467DC60245 for ; Fri, 17 Mar 2017 21:02:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 37C852860C for ; Fri, 17 Mar 2017 21:02:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 29A392861A; Fri, 17 Mar 2017 21:02:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E15402860C for ; Fri, 17 Mar 2017 21:02:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=mJDSoiliULJ5j6xkw/31x23r4OzgbElDetLmFqqhLl8=; b=l8L CMtEP4KoBOz2mI9OQ29JvYVsc7YOjlW6POTKyftXHgEh2qRTBU7ekdwS7MrPAZunohomNBJ21NtpD VdFOgzqFSyn0wCUc5Rj4HdjJ8qcIkp473Y2iK2k3TeCFH4yTkdblGW42Did8UOW3WWJwt4k5lq/Mf 6pQF97GjcjzY81Hi1j6vghxIFvCRVb0vTkPLewcFHTA1dQ4wjtqYfhRifWGS7h+CIJaVe4uHC38H8 BAWmGCLansYvjgfS/7axM7YW40epNJ2aghnuhOgAgGnab4UGcnhHXaH4AKb5rCFcklGi5hBFwNejQ RHdGNVyswemhMAmypAP4JpxZsGyVgxg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1coz15-0001ms-VM; Fri, 17 Mar 2017 21:02:31 +0000 Received: from mail-pg0-f43.google.com ([74.125.83.43]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1coz10-0001ju-2f for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2017 21:02:29 +0000 Received: by mail-pg0-f43.google.com with SMTP id n190so48816057pga.0 for ; Fri, 17 Mar 2017 14:02:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=JAFLDGSJiCx9NGxdDeGpuvC3sk/A8G5FeNhC1WFaWuQ=; b=gWk82V65mlKmDvJFRIxNJ2zHUVQnyxsgoWhOiWksxCVs79lE/y2X9FNobrsQLuEM3X 2271xpWSM5xvuxyUdGMu1l0JTIvPrOb9G4dztwC8hwC2JQyzk/NpDVrs3MxO1eJZFPsQ kYDfRI8N07Qk1jYFT6ohznCa9tOnQ8dvEYC4/tKG2MCdIgfxUWji2aiqsX/51gcjfzWQ Za75DebkxeGY+jhRjMN9R8Cmk7W2ZZhl58nV17I3bBtj5o4Wra15rD5OYXdTmjoPvcyh UBnWIPlM7/eDkDvhFjW1doyEpGRqAGyvEJcxeMzQv6FBQn2hQf8UMsZuYLG2G5v2i2Ct 31FA== X-Gm-Message-State: AFeK/H0ZMsz/XG6oAOtDdgstIYFQRXH+vGCIIUDZnekwja3cMCfZZqnsolM+sO6Om1fdKTnM X-Received: by 10.99.45.3 with SMTP id t3mr18411014pgt.162.1489784524602; Fri, 17 Mar 2017 14:02:04 -0700 (PDT) Received: from mka.mtv.corp.google.com ([172.22.66.174]) by smtp.gmail.com with ESMTPSA id k184sm18679812pgc.23.2017.03.17.14.02.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Mar 2017 14:02:03 -0700 (PDT) From: Matthias Kaehlcke To: Andrew-CT Chen , Mauro Carvalho Chehab , Matthias Brugger Subject: [PATCH] [media] vcodec: mediatek: Remove double parentheses Date: Fri, 17 Mar 2017 14:01:33 -0700 Message-Id: <20170317210133.9662-1-mka@chromium.org> X-Mailer: git-send-email 2.12.0.367.g23dc2f6d3c-goog X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170317_140226_151497_18BFCE11 X-CRM114-Status: GOOD ( 12.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, Julia Lawall , Matthias Kaehlcke , Hans Verkuil , PoChun Lin , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The extra pairs of parentheses are not needed and cause clang warnings like this: drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:158:32: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] if ((inst->work_bufs[i].size == 0)) ~~~~~~~~~~~~~~~~~~~~~~~~^~~~ drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:158:32: note: remove extraneous parentheses around the comparison to silence this warning if ((inst->work_bufs[i].size == 0)) ~ ^ ~ drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:158:32: note: use '=' to turn this equality comparison into an assignment if ((inst->work_bufs[i].size == 0)) ^~ = Signed-off-by: Matthias Kaehlcke --- drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c b/drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c index 544f57186243..129cc74b4fe4 100644 --- a/drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c +++ b/drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c @@ -155,7 +155,7 @@ static void vp8_enc_free_work_buf(struct venc_vp8_inst *inst) /* Buffers need to be freed by AP. */ for (i = 0; i < VENC_VP8_VPU_WORK_BUF_MAX; i++) { - if ((inst->work_bufs[i].size == 0)) + if (inst->work_bufs[i].size == 0) continue; mtk_vcodec_mem_free(inst->ctx, &inst->work_bufs[i]); } @@ -172,7 +172,7 @@ static int vp8_enc_alloc_work_buf(struct venc_vp8_inst *inst) mtk_vcodec_debug_enter(inst); for (i = 0; i < VENC_VP8_VPU_WORK_BUF_MAX; i++) { - if ((wb[i].size == 0)) + if (wb[i].size == 0) continue; /* * This 'wb' structure is set by VPU side and shared to AP for