From patchwork Tue Mar 21 13:42:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 9636637 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3F3CC60216 for ; Tue, 21 Mar 2017 13:46:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3910F27C0B for ; Tue, 21 Mar 2017 13:46:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2D2D327D29; Tue, 21 Mar 2017 13:46:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A2DCE27C0B for ; Tue, 21 Mar 2017 13:46:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=PvRH5DQRoj7AQYHpdPjWT2B8QwGdskoeLvIeO5wBSIg=; b=WwjvnVtnJR2afsLhu4u07X/Pa3 hndDQ2Z94uRwHneawCJj0r5Qycq4h5gw2taT9RChHQkLuEridY0T9fF7JNyz13LQBIeuyc85SRBPu a0WfNUQYPKL8osWXUY672/ibmMWEMmfQgumRsyUzm26FGByspbKqTYesd+SKIizuFyQ9jKLGHLavG iZbaT6Baxsh0gM3WOLuDDpa95bRHOjJVcJEW1+2s6tvpDBruDAIQ98vM5GPm5Z2QGoLFXLNE4zRT7 3zNduSZg8kFqPtvy6FyuKHy6nSp4+a+syZMOGSkHbCEUPbyYTPCGsIhE2Il0X/xMSKSuOQx/xNWrt FR8/Pprw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cqK7P-0002yj-Qo; Tue, 21 Mar 2017 13:46:35 +0000 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cqK3V-00083I-4x for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2017 13:42:37 +0000 Received: by mail-pg0-x244.google.com with SMTP id 81so17183127pgh.3 for ; Tue, 21 Mar 2017 06:42:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PADk511T6UvFEEkC+EgYF4H9lwlmZDln8FBwQxNzJSs=; b=VOweWaZ1CjMQzd7bjrnJcs+7ItBomMSf1pjYjnmrvixAMwyP7qzC9IxWKtca4x9kpJ ZceCQHF4DXooCTW5SNEWlHnZnvZZT9hnNrhTEZIH9M30a+5ckjfM5erPWA3SAIqAODKs LlZYL4gg4EGs0woZ6nb0BeBng+2+jlt2Qvlnq4UKSbDIBSqoYVGAia4z1n8GbQ+yiX45 N+D/OX9dVYA8x1n+Zryix3Amw0LLsRN10kjG2M+L1Po7cmd1xKS7GpKUl1NxBI9rD1F1 mNrkz3c743VMWK+y/BAS/K4ml9EX57IBXRRCDtTOa9xXmD4c7K0xDNt4GaRKgdXc3n3g 012A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PADk511T6UvFEEkC+EgYF4H9lwlmZDln8FBwQxNzJSs=; b=MH522g98aW+ltcarM095krX/3UQNoegXtXCdEBJ6ZK5CLiE9ZSmsDsv2N47Q25iFP+ j3Y+maexkNw/pOVY1BVYiJtCFyTBDjx385xdYOFOboBRh20YhUYoTZWDzzYd+ziZ1UV4 aeIQJ+D8jN83x45nYH/+w7xa/EUk8JQWsuKDdbPd7O7enNjaniuTid770ekf0QenVFRR 0z4E6PZeIkWe5bxvMBvhm1pGbj+TMUJk4P3gxu0OMU8qTh4gMGD/4m1NwWlP9Vw1N6Yy WpP2iRXkNK2bCyAMlv+tbsi502NQaWr+xsIHyA+VsjStCcNNV0SQLJJR9ZuI6DL6jgp8 ySVw== X-Gm-Message-State: AFeK/H0FzB5Eqbdi+nNE2qPMMNYiuAsxE496dEvovrRBCwxXfCCBi00rvpEXuG8tI6h3bA== X-Received: by 10.98.104.4 with SMTP id d4mr40477366pfc.2.1490103731078; Tue, 21 Mar 2017 06:42:11 -0700 (PDT) Received: from squirtle.lan (c-73-19-0-61.hsd1.wa.comcast.net. [73.19.0.61]) by smtp.gmail.com with ESMTPSA id x21sm39898761pfa.71.2017.03.21.06.42.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Mar 2017 06:42:10 -0700 (PDT) From: Andrey Smirnov To: linux-pci@vger.kernel.org Subject: [PATCH v7 4/4] PCI: imx6: Do not switch speed if Gen2 is disabled Date: Tue, 21 Mar 2017 06:42:03 -0700 Message-Id: <20170321134203.26325-5-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170321134203.26325-1-andrew.smirnov@gmail.com> References: <20170321134203.26325-1-andrew.smirnov@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170321_064233_444064_23B28335 X-CRM114-Status: GOOD ( 14.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dong Aisheng , Andrey Smirnov , linux-kernel@vger.kernel.org, Fabio Estevam , Bjorn Helgaas , yurovsky@gmail.com, linux-arm-kernel@lists.infradead.org, Lucas Stach MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Save a bit of time and avoid going through link speed change procedure in configuration where link max speed is limited to Gen1 in DT. Cc: yurovsky@gmail.com Cc: Lucas Stach Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: Dong Aisheng Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Andrey Smirnov Reviewed-by: Lucas Stach --- drivers/pci/dwc/pci-imx6.c | 52 +++++++++++++++++++++++----------------------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c index c731e41..9407c03 100644 --- a/drivers/pci/dwc/pci-imx6.c +++ b/drivers/pci/dwc/pci-imx6.c @@ -533,40 +533,40 @@ static int imx6_pcie_establish_link(struct imx6_pcie *imx6_pcie) tmp &= ~PCIE_RC_LCR_MAX_LINK_SPEEDS_MASK; tmp |= PCIE_RC_LCR_MAX_LINK_SPEEDS_GEN2; dw_pcie_writel_dbi(pci, PCIE_RC_LCR, tmp); - } else { - dev_info(dev, "Link: Gen2 disabled\n"); - } - - /* - * Start Directed Speed Change so the best possible speed both link - * partners support can be negotiated. - */ - tmp = dw_pcie_readl_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL); - tmp |= PORT_LOGIC_SPEED_CHANGE; - dw_pcie_writel_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL, tmp); - if (imx6_pcie->variant != IMX7D) { /* - * On i.MX7, DIRECT_SPEED_CHANGE behaves differently - * from i.MX6 family when no link speed transition - * occurs and we go Gen1 -> yep, Gen1. The difference - * is that, in such case, it will not be cleared by HW - * which will cause the following code to report false - * failure. + * Start Directed Speed Change so the best possible + * speed both link partners support can be negotiated. */ + tmp = dw_pcie_readl_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL); + tmp |= PORT_LOGIC_SPEED_CHANGE; + dw_pcie_writel_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL, tmp); + + if (imx6_pcie->variant != IMX7D) { + /* + * On i.MX7, DIRECT_SPEED_CHANGE behaves differently + * from i.MX6 family when no link speed transition + * occurs and we go Gen1 -> yep, Gen1. The difference + * is that, in such case, it will not be cleared by HW + * which will cause the following code to report false + * failure. + */ + + ret = imx6_pcie_wait_for_speed_change(imx6_pcie); + if (ret) { + dev_err(dev, "Failed to bring link up!\n"); + goto err_reset_phy; + } + } - ret = imx6_pcie_wait_for_speed_change(imx6_pcie); + /* Make sure link training is finished as well! */ + ret = imx6_pcie_wait_for_link(imx6_pcie); if (ret) { dev_err(dev, "Failed to bring link up!\n"); goto err_reset_phy; } - } - - /* Make sure link training is finished as well! */ - ret = imx6_pcie_wait_for_link(imx6_pcie); - if (ret) { - dev_err(dev, "Failed to bring link up!\n"); - goto err_reset_phy; + } else { + dev_info(dev, "Link: Gen2 disabled\n"); } tmp = dw_pcie_readl_dbi(pci, PCIE_RC_LCSR);