From patchwork Wed Mar 22 20:38:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Garnier X-Patchwork-Id: 9640023 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C3B3660327 for ; Wed, 22 Mar 2017 20:39:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B546428461 for ; Wed, 22 Mar 2017 20:39:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A831D28485; Wed, 22 Mar 2017 20:39:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3636228461 for ; Wed, 22 Mar 2017 20:39:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=8NXyIp4eL5v4oLHOiDpsjbkIR1sMOVcvR31c+IEnMTQ=; b=W0D ocbzXTfuFJBLCo7yZDH2bwSaOFPauZBDbHF+vjYKZVd3oNK0IDzmXH1oaqBbN1neOX4qVPzlRQjkL oGiqZRsxQOpZv1ap5LUA53XYzsWvtLYKhR6D3/YiHs0vtqH9a/qxWnGjHWA9ST+qznfE1yxGt+QJ9 ScBDWJ8bNqJzBNqGKQtjFOm/hdqHYgCPansws6kIWqYHFpi4BbbX2hHOSokQ9XcinneJOeHlde+7o 7W7ZgskRIdBBbGzEDvzNiU/ol2LeaxiUIkjJGaqW7/A9Oii3rYKVntVzdR9H6+qxwkNPCPOaWSrjp E/Vopv3cywfqlzOd1yi6GuijGL1NKPA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cqn2E-0002F4-0r; Wed, 22 Mar 2017 20:39:10 +0000 Received: from mail-pf0-x235.google.com ([2607:f8b0:400e:c00::235]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cqn29-0002Cy-U9 for linux-arm-kernel@lists.infradead.org; Wed, 22 Mar 2017 20:39:08 +0000 Received: by mail-pf0-x235.google.com with SMTP id o190so14667722pfo.0 for ; Wed, 22 Mar 2017 13:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=KqIxq5omk7Ua9zpBChPtSaIVPCqtcxtWZUe71Tx/J4E=; b=qb7eFTmakr8+B1sLCMCaIqM67WMRoV9A0eg1bs8JvC2CfKTvwvccoRNV6KVoAGZBse wz1QGy/WOHb33vTRuEEpRB0XYDzr8Rrae/W4hWiTV0EVdwzIHWXZB12bfrfiBKY3yqff UZXUDaCsvf/iEHqMcU4L6KQJ5g9lC9+v/0EWX1HLaAVRO7MODR/Jmqifm1S2rY/aBF+i g8uSKHnU2udq0lLbmpBDtUjh+0lNM4un5KMW6KHecbAa8Bg74kPoqfLJ9fpEiu6Wi9+K M/+2DRVZtez4owwon4lQ7Wo4kJ8mpYAt1ysUq2otf42yu77XtuFVT6orbskLUDf710a1 JiHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=KqIxq5omk7Ua9zpBChPtSaIVPCqtcxtWZUe71Tx/J4E=; b=Vzd/VQ6edZeqi6I43Sk6fKUDSHAVvSRaHaIcjjfO298RHNQe6kqdUZF2auPh/q3ixg 2p2iOWXSzsHjcdiBhGtoCdFi2DHJn/LA2EFvUvdOOuxTZZkEj/OYW/26k9s6mmkgoaDd mysoBMXa1fpY0ue7ZYn80lxy/e/eTBR2S+UoOn7xzWGb4teiQDBI2X4ZBDr1Euxpkl6d opNyeVAKhGEoRVI8jRc6NBrYkhdqt+ABtnh0EOdlHevFCQE46+KkZhXG0Bd5qFe7HE4M F6ZQmHl5jNbQYuz2xWbRc1UD9XDnwm7rB5zssUBNAfo4yuDaoYAydbx3/2qYW/QwXqMV ydKA== X-Gm-Message-State: AFeK/H0K3Vlx1Am91tav/WPr3tLCE7It22bHCLhi40AfJqYubqD6fL/zK4m/hJBGxoZauK9w X-Received: by 10.99.67.1 with SMTP id q1mr47117816pga.210.1490215124868; Wed, 22 Mar 2017 13:38:44 -0700 (PDT) Received: from skynet.sea.corp.google.com ([100.100.206.164]) by smtp.gmail.com with ESMTPSA id x21sm5630781pfa.71.2017.03.22.13.38.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 22 Mar 2017 13:38:44 -0700 (PDT) From: Thomas Garnier To: Martin Schwidefsky , Heiko Carstens , Dave Hansen , David Howells , Al Viro , Arnd Bergmann , Thomas Garnier , =?UTF-8?q?Ren=C3=A9=20Nyffenegger?= , Andrew Morton , "Paul E . McKenney" , Ingo Molnar , Thomas Gleixner , Oleg Nesterov , Pavel Tikhomirov , Stephen Smalley , Ingo Molnar , "H . Peter Anvin" , Andy Lutomirski , Paolo Bonzini , Rik van Riel , Kees Cook , Josh Poimboeuf , Borislav Petkov , Brian Gerst , "Kirill A . Shutemov" , Christian Borntraeger , Russell King , Vladimir Murzin , Will Deacon , Catalin Marinas , Mark Rutland , James Morse Subject: [PATCH v4 1/4] syscalls: Restore address limit after a syscall Date: Wed, 22 Mar 2017 13:38:31 -0700 Message-Id: <20170322203834.67556-1-thgarnie@google.com> X-Mailer: git-send-email 2.12.1.500.gab5fba24ee-goog X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170322_133906_009541_F7FF22CA X-CRM114-Status: GOOD ( 16.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This patch ensures a syscall does not return to user-mode with a kernel address limit. If that happened, a process can corrupt kernel-mode memory and elevate privileges. For example, it would mitigation this bug: - https://bugs.chromium.org/p/project-zero/issues/detail?id=990 If the CONFIG_BUG_ON_DATA_CORRUPTION option is enabled, an incorrect state will result in a BUG_ON. The CONFIG_ARCH_NO_SYSCALL_VERIFY_PRE_USERMODE_STATE option is also added so each architecture can optimize this change. Signed-off-by: Thomas Garnier --- Based on next-20170322 --- arch/s390/Kconfig | 1 + include/linux/syscalls.h | 18 +++++++++++++++++- init/Kconfig | 7 +++++++ kernel/sys.c | 8 ++++++++ 4 files changed, 33 insertions(+), 1 deletion(-) diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig index a2dcef0aacc7..b73f5b87bc99 100644 --- a/arch/s390/Kconfig +++ b/arch/s390/Kconfig @@ -103,6 +103,7 @@ config S390 select ARCH_INLINE_WRITE_UNLOCK_BH select ARCH_INLINE_WRITE_UNLOCK_IRQ select ARCH_INLINE_WRITE_UNLOCK_IRQRESTORE + select ARCH_NO_SYSCALL_VERIFY_PRE_USERMODE_STATE select ARCH_SAVE_PAGE_KEYS if HIBERNATION select ARCH_SUPPORTS_ATOMIC_RMW select ARCH_SUPPORTS_NUMA_BALANCING diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h index 980c3c9b06f8..e659076adf6c 100644 --- a/include/linux/syscalls.h +++ b/include/linux/syscalls.h @@ -191,6 +191,19 @@ extern struct trace_event_functions exit_syscall_print_funcs; SYSCALL_METADATA(sname, x, __VA_ARGS__) \ __SYSCALL_DEFINEx(x, sname, __VA_ARGS__) +asmlinkage void verify_pre_usermode_state(void); + +#ifndef CONFIG_ARCH_NO_SYSCALL_VERIFY_PRE_USERMODE_STATE +#define __CHECK_USER_CALLER() \ + bool user_caller = segment_eq(get_fs(), USER_DS) +#define __VERIFY_PRE_USERMODE_STATE() \ + if (user_caller) verify_pre_usermode_state() +#else +#define __CHECK_USER_CALLER() +#define __VERIFY_PRE_USERMODE_STATE() +#endif + + #define __PROTECT(...) asmlinkage_protect(__VA_ARGS__) #define __SYSCALL_DEFINEx(x, name, ...) \ asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \ @@ -199,7 +212,10 @@ extern struct trace_event_functions exit_syscall_print_funcs; asmlinkage long SyS##name(__MAP(x,__SC_LONG,__VA_ARGS__)); \ asmlinkage long SyS##name(__MAP(x,__SC_LONG,__VA_ARGS__)) \ { \ - long ret = SYSC##name(__MAP(x,__SC_CAST,__VA_ARGS__)); \ + long ret; \ + __CHECK_USER_CALLER(); \ + ret = SYSC##name(__MAP(x,__SC_CAST,__VA_ARGS__)); \ + __VERIFY_PRE_USERMODE_STATE(); \ __MAP(x,__SC_TEST,__VA_ARGS__); \ __PROTECT(x, ret,__MAP(x,__SC_ARGS,__VA_ARGS__)); \ return ret; \ diff --git a/init/Kconfig b/init/Kconfig index c859c993c26f..c4efc3a95e4a 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -1929,6 +1929,13 @@ config PROFILING config TRACEPOINTS bool +# +# Set by each architecture that want to optimize how verify_pre_usermode_state +# is called. +# +config ARCH_NO_SYSCALL_VERIFY_PRE_USERMODE_STATE + bool + source "arch/Kconfig" endmenu # General setup diff --git a/kernel/sys.c b/kernel/sys.c index 196c7134bee6..411163ac9dc3 100644 --- a/kernel/sys.c +++ b/kernel/sys.c @@ -2459,3 +2459,11 @@ COMPAT_SYSCALL_DEFINE1(sysinfo, struct compat_sysinfo __user *, info) return 0; } #endif /* CONFIG_COMPAT */ + +/* Called before coming back to user-mode */ +asmlinkage void verify_pre_usermode_state(void) +{ + if (CHECK_DATA_CORRUPTION(!segment_eq(get_fs(), USER_DS), + "incorrect get_fs() on user-mode return")) + set_fs(USER_DS); +}