From patchwork Thu Mar 30 00:29:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Berger X-Patchwork-Id: 9652795 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0FCF96034B for ; Thu, 30 Mar 2017 00:31:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 00AF128552 for ; Thu, 30 Mar 2017 00:31:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E964028564; Thu, 30 Mar 2017 00:31:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 874E028552 for ; Thu, 30 Mar 2017 00:31:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=aJI/RG/Kia4XVhTA+zXgsnAumRrWQuUYz5l20+i7cPE=; b=ZHlpoRgM9S5eucSTGObhlO9eAn u5bnPlqE4MOoQM6LPazMIWQ6ZANki1xgzmm6v4D7XJ+SNFnfjnoZrB8KguNhyDEP8HARi8uz/8Nkr fhz/Y4BeDYXKP60AgzXTwDkALs5L40bnc4NaTsBHW+O6fIgzfOaRAVjapCbVMDFfKXwJOYJIEtIyi 238N+ZoL6O/hKC+YF3tAzHyPtHm8YWQo3DBmTbLMNhjfKZBWMZK8wHaSMEScVcNl9thUO4owmHved L+EnkKFvWl2mBx4kzrlYmw7R2bl7dt/NK9oXtmp14KtHPbBrDWfLk1EGiFIYN74yYMaBzG71z3wNy wiz7Ulnw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1ctNzk-0004EQ-QR; Thu, 30 Mar 2017 00:31:20 +0000 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1ctNyb-0001u5-I2 for linux-arm-kernel@lists.infradead.org; Thu, 30 Mar 2017 00:30:13 +0000 Received: by mail-qk0-x242.google.com with SMTP id p22so4344258qka.0 for ; Wed, 29 Mar 2017 17:29:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sRfy/21dStXl1hKHE4WeD5AivjZKnxSuPVFxljv1BI0=; b=ewrvtbOCGEZeOgjyq9MgIm3aqRErN6qlpkc2ojaU+In4qiwiqOu/U4N1edJnxFGR52 r/IGEejYjnjEHoCciRgaLKBxDw5zYPvujqr9uc/4mVnM98HFixmMeVBx91bnGKTWR8zZ 8jA9E84/f3Ravy+ERRjuqCNFDrVArDX4Dqd3MFAfWSYy/5kgzuQvpJ+cncOOK49GTPPk BTBQvtfXBSD8Q4PmFB0u2DErO6ap3eT7MEQ5EUJRs60p/aNkY0fwoExgchO6w+FUL4+Q pu0VICgf4FhZCkN5OY4ZWsufwXMRKSnCNxIuthfKJhPLbrMOCia/wmd01CtVxajWeVoG 8+2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sRfy/21dStXl1hKHE4WeD5AivjZKnxSuPVFxljv1BI0=; b=Y5UINanqmdR8OalyGELM8y4wCoWEWQcUiKh9AeSh+LNQFfdvNs608n0VPGWuJeLuAx LfbWRhFiGCLMbKPzQ9S/yECBPJ53TsOvuz2RNm4db4shPDVKC8NdpDc3M3c0O6U0KWx8 VlR/z5mgMXRqsN+TRBgVPzM4IklrKEh+91Kc7bKJCc27dOF4nybhpILB3vqiErBvQpHp eY2vorafweIuidBvLHgx+kx7WlObMnjseLSTWZE1BqiAD8qZJQGrLvirA5EhKB4Exztq AygnK5l620E1YlwzuzEBPjhAn94UuDbtiZR21VEFQFwamqY6ulKKkvasVAa/NzFd5axX +NXg== X-Gm-Message-State: AFeK/H1HaMtNfTb2eX2IB1MaC/WaH26p4eLk2VeC0iJ/s/leprk0FibRZJRhzkZqutZdbw== X-Received: by 10.55.142.69 with SMTP id q66mr3288387qkd.13.1490833789381; Wed, 29 Mar 2017 17:29:49 -0700 (PDT) Received: from stb-bld-02.irv.broadcom.com ([192.19.255.250]) by smtp.gmail.com with ESMTPSA id t47sm368450qte.45.2017.03.29.17.29.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Mar 2017 17:29:48 -0700 (PDT) From: Doug Berger To: mark.rutland@arm.com Subject: [PATCH v3 4/6] bus: brcmstb_gisb: remove low-level ARM hooks Date: Wed, 29 Mar 2017 17:29:12 -0700 Message-Id: <20170330002914.7371-5-opendmb@gmail.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170330002914.7371-1-opendmb@gmail.com> References: <20170330002914.7371-1-opendmb@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170329_173010_232664_0597687F X-CRM114-Status: GOOD ( 10.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: treding@nvidia.com, f.fainelli@gmail.com, mirza.krak@gmail.com, catalin.marinas@arm.com, linus.walleij@linaro.org, suzuki.poulose@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, jonathanh@nvidia.com, bgolaszewski@baylibre.com, devicetree@vger.kernel.org, robh+dt@kernel.org, bcm-kernel-feedback-list@broadcom.com, gregory.0xf0@gmail.com, olof@lixom.net, Doug Berger , computersforpeace@gmail.com, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The ARM architecture can provide meaningful diagnostic output from the GISB arbiter solely from interrupts and notifiers without the need to hook the low level fault handlers. Signed-off-by: Doug Berger --- drivers/bus/brcmstb_gisb.c | 30 ------------------------------ 1 file changed, 30 deletions(-) diff --git a/drivers/bus/brcmstb_gisb.c b/drivers/bus/brcmstb_gisb.c index a2e1c5c25a3a..3fbc116e6b95 100644 --- a/drivers/bus/brcmstb_gisb.c +++ b/drivers/bus/brcmstb_gisb.c @@ -28,11 +28,6 @@ #include #include -#ifdef CONFIG_ARM -#include -#include -#endif - #ifdef CONFIG_MIPS #include #endif @@ -228,27 +223,6 @@ static int brcmstb_gisb_arb_decode_addr(struct brcmstb_gisb_arb_device *gdev, return 0; } -#ifdef CONFIG_ARM -static int brcmstb_bus_error_handler(unsigned long addr, unsigned int fsr, - struct pt_regs *regs) -{ - int ret = 0; - struct brcmstb_gisb_arb_device *gdev; - - /* iterate over each GISB arb registered handlers */ - list_for_each_entry(gdev, &brcmstb_gisb_arb_device_list, next) - ret |= brcmstb_gisb_arb_decode_addr(gdev, "bus error"); - /* - * If it was an imprecise abort, then we need to correct the - * return address to be _after_ the instruction. - */ - if (fsr & (1 << 10)) - regs->ARM_pc += 4; - - return ret; -} -#endif - #ifdef CONFIG_MIPS static int brcmstb_bus_error_handler(struct pt_regs *regs, int is_fixup) { @@ -415,10 +389,6 @@ static int __init brcmstb_gisb_arb_probe(struct platform_device *pdev) list_add_tail(&gdev->next, &brcmstb_gisb_arb_device_list); -#ifdef CONFIG_ARM - hook_fault_code(22, brcmstb_bus_error_handler, SIGBUS, 0, - "imprecise external abort"); -#endif #ifdef CONFIG_MIPS board_be_handler = brcmstb_bus_error_handler; #endif